Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant "rotate" from Keys API #25714

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Remove redundant "rotate" from Keys API #25714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8d4a43
Remove redundant "rotate" from Keys API
heaths Sep 7, 2023
a287b5f
Remove now-unnecessary exemptions
heaths Sep 7, 2023
2ff0da7
Fix description on Notify
heaths Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.3-preview/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2193,10 +2193,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2205,11 +2204,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.4-preview.1/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2221,10 +2221,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2233,11 +2232,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.5-preview.1/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2199,10 +2199,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2211,11 +2210,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.3/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2194,10 +2194,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2206,11 +2205,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.4/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2194,10 +2194,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -2206,11 +2205,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
4 changes: 0 additions & 4 deletions specification/keyvault/data-plane/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,10 +496,6 @@ directive:
from: securitydomain.json
where: $.definitions.TransferKey.properties.key_format
reason: Consistency with other properties
- suppress: EnumUniqueValue
from: keys.json
where: $.definitions.LifetimeActionsType.properties.type
reason: SDK, docs workaround for current service behavior.
- suppress: DOUBLE_FORWARD_SLASHES_IN_URL
from: rbac.json
reason: / is a valid scope in this scenario.
Expand Down
9 changes: 2 additions & 7 deletions ...ication/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,10 +593,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -605,11 +604,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions ...ication/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,10 +611,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -623,11 +622,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions ...ication/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-11-01-preview/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,10 +611,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -623,11 +622,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions ...ication/keyvault/resource-manager/Microsoft.KeyVault/preview/2022-02-01-preview/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,10 +612,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -624,11 +623,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2022-07-01/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -625,11 +624,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2022-11-01/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -625,11 +624,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions ...cation/keyvault/resource-manager/Microsoft.KeyVault/stable/2022-11-01/keysManagedHsm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,10 +542,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -554,11 +553,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2023-02-01/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -625,11 +624,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 2 additions & 7 deletions ...cation/keyvault/resource-manager/Microsoft.KeyVault/stable/2023-02-01/keysManagedHsm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,10 +542,9 @@
"properties": {
"type": {
"type": "string",
"description": "The type of the action.",
"description": "The type of the action. The value should be compared case-insensitively.",
"enum": [
"Rotate",
"rotate",
"Notify"
],
"x-ms-enum": {
Expand All @@ -554,11 +553,7 @@
"values": [
{
"value": "Rotate",
"description": "Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead."
},
{
"value": "rotate",
"description": "Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead."
"description": "Rotate the key based on the key policy."
},
{
"value": "Notify",
Expand Down
9 changes: 0 additions & 9 deletions specification/keyvault/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,15 +261,6 @@ directive:
from: keysManagedHsm.json
reason: This is to keep compatibility with existing data plane property. The 'release_policy' property for KeyCreateParameters does not support camelCase.

- suppress: EnumUniqueValue
from: keys.json
where: $.definitions.Action.properties.type
reason: SDK, docs workaround for current service behavior.
- suppress: EnumUniqueValue
from: keysManagedHsm.json
where: $.definitions.ManagedHsmAction.properties.type
reason: SDK, docs workaround for current service behavior.

- suppress: INVALID_REQUEST_PARAMETER
from: keyvault.json
reason: The Vaults_List API endpoint only supports version 2015-11-01.
Expand Down