Conor joplin search microsoft.search 2023 11 01 #25938

conor-joplin · 2023-09-22T21:07:32Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…1 to version 2023-11-01

openapi-pipeline-app · 2023-09-22T21:07:36Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-09-22T21:07:36Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 16 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
search.json	2023-11-01(b934efa)	2022-09-01(main)
search.json	2023-11-01(b934efa)	2021-04-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'UserAssignedManagedIdentities' removed or renamed? New: Microsoft.Search/stable/2023-11-01/search.json#L1352:3 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L1268:3
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'stopped' from the old version. New: Microsoft.Search/stable/2023-11-01/search.json#L2155:9 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2120:9
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'UserAssigned, SystemAssigned, UserAssigned' from the old version. New: Microsoft.Search/stable/2023-11-01/search.json#L2423:9 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2557:9
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'isDataAction' renamed or removed? New: Microsoft.Search/stable/2023-11-01/search.json#L2359:7 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2346:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'origin' renamed or removed? New: Microsoft.Search/stable/2023-11-01/search.json#L2359:7 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2346:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'properties' renamed or removed? New: Microsoft.Search/stable/2023-11-01/search.json#L2359:7 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2346:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'message' renamed or removed? New: Microsoft.Search/stable/2023-11-01/search.json#L2321:7 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2304:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'bypass' renamed or removed? New: Microsoft.Search/stable/2023-11-01/search.json#L1659:7 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L1591:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'disabledDataExfiltrationOptions' renamed or removed? New: Microsoft.Search/stable/2023-11-01/search.json#L2100:7 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2053:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'eTag' renamed or removed? New: Microsoft.Search/stable/2023-11-01/search.json#L2100:7 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2053:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'userAssignedIdentities' renamed or removed? New: Microsoft.Search/stable/2023-11-01/search.json#L2412:7 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2546:7
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: Microsoft.Search/stable/2023-11-01/search.json#L2142:9 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2095:9
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: Microsoft.Search/stable/2023-11-01/search.json#L1881:9 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L1785:9
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: Microsoft.Search/stable/2023-11-01/search.json#L1895:9 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L1821:9
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: Microsoft.Search/stable/2023-11-01/search.json#L1478:9 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L1394:9
⚠️ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: Microsoft.Search/stable/2023-11-01/search.json#L2423:9 Old: Microsoft.Search/preview/2021-04-01-preview/search.json#L2557:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.5)	new version	base version
package-2023-11	package-2023-11(b934efa)	default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` MissingXmsErrorResponse	Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Search/stable/2023-11-01/search.json#L348
`❌` MissingXmsErrorResponse	Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Search/stable/2023-11-01/search.json#L612
`❌` DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Search/stable/2023-11-01/search.json#L865
`❌` MissingXmsErrorResponse	Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Search/stable/2023-11-01/search.json#L872
`❌` MissingXmsErrorResponse	Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Search/stable/2023-11-01/search.json#L1095
`❌` MissingTypeObject	The schema 'AdminKeyResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1427
`❌` MissingTypeObject	The schema 'QueryKey' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1442
`❌` MissingTypeObject	The schema 'ListQueryKeysResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1457
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Search/stable/2023-11-01/search.json#L1459
`❌` MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1476
`❌` MissingTypeObject	The schema 'PrivateEndpointConnection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1644
`❌` MissingTypeObject	The schema 'NetworkRuleSet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1658
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Search/stable/2023-11-01/search.json#L1660
`❌` MissingTypeObject	The schema 'IpRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1670
`❌` MissingTypeObject	The schema 'PrivateEndpointConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1679
`❌` MissingTypeObject	The schema 'privateEndpoint' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1681
`❌` MissingTypeObject	The schema 'PrivateEndpointConnectionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1796
`❌` MissingTypeObject	The schema 'SharedPrivateLinkResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1845
`❌` MissingTypeObject	The schema 'SharedPrivateLinkResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1859
`❌` MissingTypeObject	The schema 'SharedPrivateLinkResourceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1913
`❌` MissingTypeObject	The schema 'PrivateLinkResourcesResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1931
`❌` MissingTypeObject	The schema 'PrivateLinkResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1945
`❌` MissingTypeObject	The schema 'PrivateLinkResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1960
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Search/stable/2023-11-01/search.json#L1983
`❌` MissingTypeObject	The schema 'ShareablePrivateLinkResourceType' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L1994
`❌` MissingTypeObject	The schema 'ShareablePrivateLinkResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L2009
`❌` MissingTypeObject	The schema 'SearchService' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L2029
`❌` MissingTypeObject	The schema 'SearchServiceUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L2055
`❌` MissingTypeObject	The schema 'SearchServiceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L2099
`❌` MissingTypeObject	The schema 'SearchServiceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Search/stable/2023-11-01/search.json#L2281

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-22T21:07:37Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d56d45a. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Search [View full logs] [Release SDK Changes]
- Azure.ResourceManager.Search.1.2.0-alpha.20231009.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from d56d45a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-search [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group SearchManagementClientOperationsMixin
info	[Changelog]   - Added operation group UsagesOperations
info	[Changelog]   - Model SearchService has a new parameter semantic_search
info	[Changelog]   - Model SearchServiceUpdate has a new parameter semantic_search

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from d56d45a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-search [View full logs] [Release SDK Changes]
- pom.xml

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d56d45a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/search/armsearch [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `AADAuthFailureMode` with values `AADAuthFailureModeHttp401WithBearerChallenge`, `AADAuthFailureModeHttp403`
info	[Changelog] - New enum type `PrivateLinkServiceConnectionProvisioningState` with values `PrivateLinkServiceConnectionProvisioningStateCanceled`, `PrivateLinkServiceConnectionProvisioningStateDeleting`, `PrivateLinkServiceConnectionProvisioningStateFailed`, `PrivateLinkServiceConnectionProvisioningStateIncomplete`, `PrivateLinkServiceConnectionProvisioningStateSucceeded`, `PrivateLinkServiceConnectionProvisioningStateUpdating`
info	[Changelog] - New enum type `SearchEncryptionComplianceStatus` with values `SearchEncryptionComplianceStatusCompliant`, `SearchEncryptionComplianceStatusNonCompliant`
info	[Changelog] - New enum type `SearchEncryptionWithCmk` with values `SearchEncryptionWithCmkDisabled`, `SearchEncryptionWithCmkEnabled`, `SearchEncryptionWithCmkUnspecified`
info	[Changelog] - New enum type `SearchSemanticSearch` with values `SearchSemanticSearchDisabled`, `SearchSemanticSearchFree`, `SearchSemanticSearchStandard`
info	[Changelog] - New function `*ClientFactory.NewManagementClient() *ManagementClient`
info	[Changelog] - New function `*ClientFactory.NewUsagesClient() *UsagesClient`
info	[Changelog] - New function `NewManagementClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagementClient, error)`
info	[Changelog] - New function `*ManagementClient.UsageBySubscriptionSKU(context.Context, string, string, *SearchManagementRequestOptions, *ManagementClientUsageBySubscriptionSKUOptions) (ManagementClientUsageBySubscriptionSKUResponse, error)`
info	[Changelog] - New function `NewUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UsagesClient, error)`
info	[Changelog] - New function `*UsagesClient.NewListBySubscriptionPager(string, *SearchManagementRequestOptions, *UsagesClientListBySubscriptionOptions) *runtime.Pager[UsagesClientListBySubscriptionResponse]`
info	[Changelog] - New struct `DataPlaneAADOrAPIKeyAuthOption`
info	[Changelog] - New struct `DataPlaneAuthOptions`
info	[Changelog] - New struct `EncryptionWithCmk`
info	[Changelog] - New struct `QuotaUsageResult`
info	[Changelog] - New struct `QuotaUsageResultName`
info	[Changelog] - New field `GroupID`, `ProvisioningState` in struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New field `AuthOptions`, `DisableLocalAuth`, `EncryptionWithCmk`, `SemanticSearch` in struct `ServiceProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 39 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d56d45a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-search [View full logs] [Release SDK Changes]

azure-arm-search-3.2.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group Usages
info	[Changelog]   - Added Interface DataPlaneAadOrApiKeyAuthOption
info	[Changelog]   - Added Interface DataPlaneAuthOptions
info	[Changelog]   - Added Interface EncryptionWithCmk
info	[Changelog]   - Added Interface QuotaUsageResult
info	[Changelog]   - Added Interface QuotaUsageResultName
info	[Changelog]   - Added Interface QuotaUsagesListResult
info	[Changelog]   - Added Interface UsageBySubscriptionSkuOptionalParams
info	[Changelog]   - Added Interface UsagesListBySubscriptionNextOptionalParams
info	[Changelog]   - Added Interface UsagesListBySubscriptionOptionalParams
info	[Changelog]   - Added Type Alias AadAuthFailureMode
info	[Changelog]   - Added Type Alias PrivateLinkServiceConnectionProvisioningState
info	[Changelog]   - Added Type Alias SearchEncryptionComplianceStatus
info	[Changelog]   - Added Type Alias SearchEncryptionWithCmk
info	[Changelog]   - Added Type Alias SearchSemanticSearch
info	[Changelog]   - Added Type Alias UsageBySubscriptionSkuResponse
info	[Changelog]   - Added Type Alias UsagesListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias UsagesListBySubscriptionResponse
info	[Changelog]   - Interface PrivateEndpointConnectionProperties has a new optional parameter groupId
info	[Changelog]   - Interface PrivateEndpointConnectionProperties has a new optional parameter provisioningState
info	[Changelog]   - Interface SearchService has a new optional parameter authOptions
info	[Changelog]   - Interface SearchService has a new optional parameter disableLocalAuth
info	[Changelog]   - Interface SearchService has a new optional parameter encryptionWithCmk
info	[Changelog]   - Interface SearchService has a new optional parameter semanticSearch
info	[Changelog]   - Interface SearchServiceUpdate has a new optional parameter authOptions
info	[Changelog]   - Interface SearchServiceUpdate has a new optional parameter disableLocalAuth
info	[Changelog]   - Interface SearchServiceUpdate has a new optional parameter encryptionWithCmk
info	[Changelog]   - Interface SearchServiceUpdate has a new optional parameter semanticSearch
info	[Changelog]   - Added Enum KnownPrivateLinkServiceConnectionProvisioningState
info	[Changelog]   - Added Enum KnownSearchSemanticSearch

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from d56d45a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️search [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from d56d45a. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.search.DefaultTag [View full logs]

Az.Search.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.search.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-22T21:07:38Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/search/armsearch	https://apiview.dev/Assemblies/Review/f54a098fd9ec4ff282c9d8ddb2ff3bd9
.Net	Azure.ResourceManager.Search	https://apiview.dev/Assemblies/Review/8034224d8aba464b85e5302b1c89a337
JavaScript	@azure/arm-search	https://apiview.dev/Assemblies/Review/73c6a86642c744ac8dc4108c08392ef5

openapi-workflow-bot · 2023-09-22T21:20:54Z

Hi @conor-joplin! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

specification/search/resource-manager/Microsoft.Search/stable/2023-11-01/search.json

BevLoh · 2023-10-04T22:04:44Z

@rkmanda , can you help resolve the merging requirement issue?

Following required labels are missing:
❌ Approved-SdkBreakingChange-Go

We aren't able to find the details on what is breaking.

openapi-pipeline-app · 2023-10-09T01:08:39Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

* Adds base for updating Microsoft.Search from version stable/2022-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Applying changes for the new 2023-11-01 API version * Fixing introduced linting warnings * update semantic description * Adding parameter location to new parameters --------- Co-authored-by: Conor Joplin <cojoplin@microsoft.com> Co-authored-by: Efrain Retana <efrainretana@microsoft.com>

conor-joplin and others added 4 commits September 22, 2023 13:59

Adds base for updating Microsoft.Search from version stable/2022-09-0…

bbaeebc

…1 to version 2023-11-01

Updates readme

cd0c379

Updates API version in new specs and examples

435c0d5

Applying changes for the new 2023-11-01 API version

f6ed083

conor-joplin requested review from tjacobhi and BevLoh as code owners September 22, 2023 21:07

openapi-assignment-bot bot assigned rkmanda Sep 22, 2023

This was referenced Sep 22, 2023

[AutoPR search] Conor joplin search microsoft.search 2023 11 01 azure-sdk/azure-resource-manager-schemas#3298

Closed

[AutoPR sdk/resourcemanager/search/armsearch] Conor joplin search microsoft.search 2023 11 01 azure-sdk/azure-sdk-for-go#7368

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Sep 22, 2023

AzureRestAPISpecReview added ARMReview CI-MissingBaseCommit new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 22, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Sep 22, 2023

azure-sdk mentioned this pull request Sep 22, 2023

[AutoPR Azure.ResourceManager.Search] Conor joplin search microsoft.search 2023 11 01 azure-sdk/azure-sdk-for-net#5276

Closed

Fixing introduced linting warnings

05795ba

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Sep 22, 2023

raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 28, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 28, 2023

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Sep 28, 2023

Alancere reviewed Sep 28, 2023

View reviewed changes

specification/search/resource-manager/Microsoft.Search/stable/2023-11-01/search.json Show resolved Hide resolved

Alancere reviewed Sep 28, 2023

View reviewed changes

specification/search/resource-manager/Microsoft.Search/stable/2023-11-01/search.json Show resolved Hide resolved

efrainretana and others added 2 commits September 28, 2023 08:34

update semantic description

88837d2

Adding parameter location to new parameters

b934efa

BevLoh approved these changes Oct 4, 2023

View reviewed changes

tjacobhi approved these changes Oct 4, 2023

View reviewed changes

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Oct 7, 2023

BevLoh added the MergeRequested label Oct 7, 2023

ms-zhenhua merged commit d56d45a into main Oct 9, 2023
30 of 31 checks passed

ms-zhenhua deleted the conor-joplin-search-Microsoft.Search-2023-11-01 branch October 9, 2023 01:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conor joplin search microsoft.search 2023 11 01 #25938

Conor joplin search microsoft.search 2023 11 01 #25938

conor-joplin commented Sep 22, 2023

openapi-pipeline-app bot commented Sep 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 22, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 22, 2023 •

edited

Loading

openapi-workflow-bot bot commented Sep 22, 2023

BevLoh commented Oct 4, 2023

openapi-pipeline-app bot commented Oct 9, 2023

Conor joplin search microsoft.search 2023 11 01 #25938

Conor joplin search microsoft.search 2023 11 01 #25938

Conversation

conor-joplin commented Sep 22, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Sep 22, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Sep 22, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 22, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 22, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Sep 22, 2023

BevLoh commented Oct 4, 2023

openapi-pipeline-app bot commented Oct 9, 2023

openapi-pipeline-app bot commented Sep 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 22, 2023 •

edited

Loading