Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2023-10-03-preview #26059

Merged
merged 62 commits into from
Nov 14, 2023

remove secrets

539cbd0
Select commit
Loading
Failed to load commit list.
Merged

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2023-10-03-preview #26059

remove secrets
539cbd0
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff failed Nov 14, 2023 in 2m 55s

~[NotRequired_Staging] Swagger LintDiff failed

ppe/LintDiff: 5 Errors, 14 Warnings
View more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-preview-2023-10 package-preview-2023-10(539cbd0) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 2: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 3: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 4: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 5: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 6: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 7: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 8: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 9: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 10: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 11: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined')
Location: azure-rest-api-specs/blob/539cbd070abbf9fb9a004a9e36f9c7109d12fde8/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 2: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 3: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 4: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 5: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 6: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 7: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 8: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 9: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 10: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 11: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 12: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 13: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 14: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 15: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 16: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 17: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 18: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 19: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined')
Location: azure-rest-api-specs/blob/539cbd070abbf9fb9a004a9e36f9c7109d12fde8/#L1
⚠️ AllProxyResourcesShouldHaveDelete The resource NetworkConfiguration does not have a corresponding delete operation.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json#L989 		RPC-Delete-V1-05
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkSecurityPerimeterConfigurations_GetByPrivateLinkScope' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json#L840


The following errors/warnings exist before current PR submission:

Rule Message
❌ ArmResourcePropertiesBag Top level property names should not be repeated inside the properties bag for ARM resource 'MachineExtension'. Properties [properties.type] conflict with ARM top level properties. Please rename these.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json#L3558
❌ TrackedResourcePatchOperation Tracked resource 'License' must have patch operation that at least supports the update of tags.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json#L2897
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'Machine' has extra properties ['resources'].
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json#L2789
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: PrivateLinkScopeGet
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json#L691
⚠️ PageableOperation Based on the response model schema, operation 'PrivateLinkScopes_GetValidationDetailsForMachine' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json#L660
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: PrivateLinkScopeGet
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json#L652
⚠️ PageableOperation Based on the response model schema, operation 'PrivateLinkScopes_GetValidationDetails' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json#L621
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Gets private endpoint connection.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json#L443
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Gets private endpoint connection.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json#L394
⚠️ DeprecatedXmsCodeGenerationSetting The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/privateLinkScopes.json#L5
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GET Agent Versions
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json#L1920
⚠️ PageableOperation Based on the response model schema, operation 'AgentVersion_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json#L1841
⚠️ PageableOperation Based on the response model schema, operation 'NetworkProfile_Get' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json#L1675
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create or Update a Machine Extension
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json#L1246
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Machines by resource group
Location: Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json#L1093
View more details on openapi-pipeline-app