-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeSpec] Upgrade to 0.49.0 #26200
[TypeSpec] Upgrade to 0.49.0 #26200
Conversation
Hi @mikeharder, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO. |
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
azure.codesigning.json | 2023-06-15-preview(ecb6886) | 2023-06-15-preview(main) |
EventGrid.json | 2023-06-01-preview(ecb6886) | 2023-06-01-preview(main) |
Rule | Message |
---|---|
1042 - ChangedParameterOrder |
The order of parameter 'operationId' was changed. New: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L149:9 Old: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L149:9 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
2023-06-15-preview | 2023-06-15-preview(ecb6886) | 2023-06-15-preview(main) |
package-2023-06-01-preview | package-2023-06-01-preview(ecb6886) | package-2023-06-01-preview(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L89 |
AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L170 |
Security definition should have a description. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L43 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L54 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L63 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L70 |
|
Parameter should have a description. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L77 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L153 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L156 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L159 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L226 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L233 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L284 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L287 |
|
Schema name should be Pascal case. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L320 |
|
Schema name should be Pascal case. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L354 |
|
Schema name should be Pascal case. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L367 |
|
Schema name should be Pascal case. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L381 |
|
Security definition should have a description. Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L45 |
|
OperationId should be of the form 'Noun_Verb' Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L58 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L67 |
|
Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L115 |
|
Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L115 |
|
OperationId should be of the form 'Noun_Verb' Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L116 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L122 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L129 |
|
Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L184 |
|
OperationId should be of the form 'Noun_Verb' Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L185 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L191 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L198 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 4 Errors, 0 Warnings failed [Detail]
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
OpenAPI
namespace toTypeSpec.OpenAPI
microsoft/typespec#2439