Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new preview version "2023-10-01-preview" with new APIs #26215

Merged
merged 12 commits into from
Oct 19, 2023

change v5 to v3 to resolve SDK failures

8a491c7
Select commit
Loading
Failed to load commit list.
Merged

Adding new preview version "2023-10-01-preview" with new APIs #26215

change v5 to v3 to resolve SDK failures
8a491c7
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded Oct 17, 2023 in 3m 7s

Swagger LintDiff succeeded

LintDiff
View more details.

Details

compared tags (via openapi-validator v2.1.6) new version base version
package-2022-07-01-preview package-2022-07-01-preview(8a491c7) package-2022-07-01-preview(main)
package-2022-07-01 package-2022-07-01(8a491c7) package-2022-07-01(main)
package-2023-10-01-preview package-2023-10-01-preview(8a491c7) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getbillinginfo' in:'BillingInfo_Get'. Consider updating the operationId
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L895
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L899
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L901
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L904
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L907
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L928
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listconnectedpartnerresources' in:'ConnectedPartnerResources_List'. Consider updating the operationId
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L945
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L949
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L951
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L954
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L957
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L978
⚠️ LocationMustHaveXmsMutability Property location must have 'x-ms-mutability':['read', 'create'] extension defined.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L1524		 RPC-Put-V1-14


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L325
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L493
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L526
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L558
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L610
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L662
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L717
❌ LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L718
❌ PostResponseCodes An async POST operation must set ''x-ms-long-running-operation' : true'.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L718
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L754
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L782
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L837
❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L842
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L889
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L941
❌ ResourceNameRestriction The resource name parameter 'ruleSetName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L941
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L1076
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L1113
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2022-07-01-preview/NewRelic.json#L1208
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L325
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L493
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L526
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L558
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L610
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L662
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L717
❌ LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L718
❌ PostResponseCodes An async POST operation must set ''x-ms-long-running-operation' : true'.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L718
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L754
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L782
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L837
❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L842
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L992
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L1044
❌ ResourceNameRestriction The resource name parameter 'ruleSetName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L1044
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L1179
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L1216
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/preview/2023-10-01-preview/NewRelic.json#L1311
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L325
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L493
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L526
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L558
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L610
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L662
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L717
❌ LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L718
❌ PostResponseCodes An async POST operation must set ''x-ms-long-running-operation' : true'.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L718
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L754
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L782
❌ ResourceNameRestriction The resource name parameter 'monitorName' should be defined with a 'pattern' restriction.
Location: NewRelic.Observability/stable/2022-07-01/NewRelic.json#L837
View more details on openapi-pipeline-app