Riya/removeskulist #26376

riyasimon23 · 2023-10-25T21:52:18Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
We had initially implemented an API to return skus available for the Redis Enterprise service. After being informed that the right way to do this is by implementing the SKU contract where ARM returns the skus after contacting the service RP, we recently rolled out changes to support that. We do not need to expose the previous API anymore. This API was not usable by customers since we had not rolled out the manifest changes for the previous implementation so this will not have customer impact.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…specs

openapi-pipeline-app · 2023-10-25T21:52:23Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-10-25T21:52:23Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
redisenterprise.json	2022-11-01-preview(75f0a5c)	2022-11-01-preview(main)
redisenterprise.json	2023-03-01-preview(75f0a5c)	2023-03-01-preview(main)
redisenterprise.json	2023-08-01-preview(75f0a5c)	2023-08-01-preview(main)
redisenterprise.json	2023-10-01-preview(75f0a5c)	2023-10-01-preview(main)

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/locations/{location}/skus' removed or restructured? Old: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1202:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/locations/{location}/skus' removed or restructured? Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1271:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/locations/{location}/skus' removed or restructured? Old: Microsoft.Cache/preview/2023-08-01-preview/redisenterprise.json#L1271:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/locations/{location}/skus' removed or restructured? Old: Microsoft.Cache/preview/2023-10-01-preview/redisenterprise.json#L1271:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-preview-2023-10	package-preview-2023-10(75f0a5c)	package-preview-2023-10(main)
package-preview-2023-08	package-preview-2023-08(75f0a5c)	package-preview-2023-08(main)
package-preview-2023-03	package-preview-2023-03(75f0a5c)	package-preview-2023-03(main)
package-preview-2022-11	package-preview-2022-11(75f0a5c)	package-preview-2022-11(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L115
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L220
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L231
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L264
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L400
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L446
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L446
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L562
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L617
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L654
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L669
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L669
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L715
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L715
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L765
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L777
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L777
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L778
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L824
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L836
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L836
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L837
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L883
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L895
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L924
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L940
`❌` ResourceNameRestriction	The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L940
`❌` ProvisioningStateSpecifiedForLROPut	200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L984
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L984
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1037

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-25T21:52:24Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-python-track2 - track2_azure-mgmt-redisenterprise - Approved - 2.1.0b2

+	Removed operation group SkusOperations

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b36917f. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.RedisEnterprise [View full logs] [Release SDK Changes]
- Azure.ResourceManager.RedisEnterprise.1.1.0-alpha.20231031.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from b36917f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-redisenterprise [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation RedisEnterpriseOperations.check_name_availability
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Removed operation group SkusOperations
info	[Changelog]   - Renamed operation PrivateEndpointConnectionsOperations.delete to PrivateEndpointConnectionsOperations.begin_delete

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from b36917f. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-redisenterprise [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b36917f. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/redisenterprise/armredisenterprise [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Operation `*PrivateEndpointConnectionsClient.Delete` has been changed to LRO, use `*PrivateEndpointConnectionsClient.BeginDelete` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ResourceStateScaling`, `ResourceStateScalingFailed` added to enum type `ResourceState`
info	[Changelog] - New value `SKUNameEnterpriseE200`, `SKUNameEnterpriseE400`, `SKUNameEnterpriseE5` added to enum type `SKUName`
info	[Changelog] - New enum type `CmkIdentityType` with values `CmkIdentityTypeSystemAssignedIdentity`, `CmkIdentityTypeUserAssignedIdentity`
info	[Changelog] - New enum type `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
info	[Changelog] - New function `*Client.CheckNameAvailability(context.Context, CheckNameAvailabilityParameters, *ClientCheckNameAvailabilityOptions) (ClientCheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `*DatabasesClient.BeginFlush(context.Context, string, string, string, FlushParameters, *DatabasesClientBeginFlushOptions) (*runtime.Poller[DatabasesClientFlushResponse], error)`
info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
info	[Changelog] - New struct `CheckNameAvailabilityParameters`
info	[Changelog] - New struct `ClusterPropertiesEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity`
info	[Changelog] - New struct `FlushParameters`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New field `Identity`, `SystemData` in struct `Cluster`
info	[Changelog] - New field `Encryption` in struct `ClusterProperties`
info	[Changelog] - New field `Identity` in struct `ClusterUpdate`
info	[Changelog] - New field `SystemData` in struct `Database`
info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `SystemData` in struct `PrivateLinkResource`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 48 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b36917f. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-redisenterprisecache [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-redisenterprisecache-3.0.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation Databases.beginFlush
info	[Changelog]   - Added operation Databases.beginFlushAndWait
info	[Changelog]   - Added operation PrivateEndpointConnections.beginDelete
info	[Changelog]   - Added operation PrivateEndpointConnections.beginDeleteAndWait
info	[Changelog]   - Added operation RedisEnterprise.checkNameAvailability
info	[Changelog]   - Added Interface CheckNameAvailabilityParameters
info	[Changelog]   - Added Interface ClusterPropertiesEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity
info	[Changelog]   - Added Interface DatabasesFlushHeaders
info	[Changelog]   - Added Interface DatabasesFlushOptionalParams
info	[Changelog]   - Added Interface FlushParameters
info	[Changelog]   - Added Interface ManagedServiceIdentity
info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
info	[Changelog]   - Added Interface RedisEnterpriseCheckNameAvailabilityOptionalParams
info	[Changelog]   - Added Interface SystemData
info	[Changelog]   - Added Interface UserAssignedIdentity
info	[Changelog]   - Added Type Alias CmkIdentityType
info	[Changelog]   - Added Type Alias CreatedByType
info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
info	[Changelog]   - Interface Cluster has a new optional parameter encryption
info	[Changelog]   - Interface Cluster has a new optional parameter identity
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter encryption
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter identity
info	[Changelog]   - Interface PrivateEndpointConnectionsDeleteOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface PrivateEndpointConnectionsDeleteOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Added Enum KnownCmkIdentityType
info	[Changelog]   - Added Enum KnownCreatedByType
info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
info	[Changelog]   - Enum KnownResourceState has a new value Scaling
info	[Changelog]   - Enum KnownResourceState has a new value ScalingFailed
info	[Changelog]   - Enum KnownSkuName has a new value EnterpriseE200
info	[Changelog]   - Enum KnownSkuName has a new value EnterpriseE400
info	[Changelog]   - Enum KnownSkuName has a new value EnterpriseE5
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation PrivateEndpointConnections.delete

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from b36917f. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.2
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.2>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.2` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️redisenterprise [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from b36917f. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.redisenterprise.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.redisenterprise.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-25T21:52:25Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/redisenterprise/armredisenterprise	https://apiview.dev/Assemblies/Review/b4c647b369334b8fa6dc1ea0893241f1
Java	azure-resourcemanager-redisenterprise	https://apiview.dev/Assemblies/Review/be1e54ba9f6b428c82e3fd2328691cac
.Net	Azure.ResourceManager.RedisEnterprise	https://apiview.dev/Assemblies/Review/2107d5aa9105488792c89525d9226ca8
JavaScript	@azure/arm-redisenterprisecache	https://apiview.dev/Assemblies/Review/a8347ba231d84f9db9973d714b374255

openapi-workflow-bot · 2023-10-30T00:34:47Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

riyasimon23 · 2023-10-30T05:45:00Z

Breaking changes new intake created: https://msazure.visualstudio.com/b32aa71e-8ed2-41b2-9d77-5bc261222004/_workitems/edit/25626928

riyasimon23 · 2023-10-30T18:03:24Z

Hi @msyyc, I am requesting a breaking changes review for CI-BreakingChange-Python-Track2. Please let me know if there are questions or some fixes more to do from my end.

riyasimon23 · 2023-10-30T18:13:35Z

@rkmanda Hi, I had a question on how the public docs will be updated for ARM internal API (https://armwiki.azurewebsites.net/api_contracts/SKUContract.html?tabs=resource-type-level). The document mentions that individual RPs shouldn't specify the API in their spec. Is there anything from our end to onboard the documentation for this API? Similar to how Microsoft.Compute has: https://learn.microsoft.com/en-us/rest/api/compute/resource-skus/list?tabs=HTTP

rkmanda · 2023-10-31T00:26:08Z

@rkmanda Hi, I had a question on how the public docs will be updated for ARM internal API (https://armwiki.azurewebsites.net/api_contracts/SKUContract.html?tabs=resource-type-level). The document mentions that individual RPs shouldn't specify the API in their spec. Is there anything from our end to onboard the documentation for this API? Similar to how Microsoft.Compute has: https://learn.microsoft.com/en-us/rest/api/compute/resource-skus/list?tabs=HTTP

no action required for internal APIs

riyasimon23 · 2023-10-31T17:44:51Z

/pr RequestMerge

openapi-pipeline-app · 2023-10-31T18:00:39Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

* updates to preview api version removing unshipped SKUs API

Riya Simon and others added 4 commits February 22, 2022 14:01

Update example value for module argument

9efb79f

Merge branch 'Azure:main' into main

2edc6b5

Merge branch 'main' of https://github.com/riyasimon23/azure-rest-api-…

b79092c

…specs

update 2023-10-01

c7a9330

openapi-assignment-bot bot assigned rkmanda Oct 25, 2023

This was referenced Oct 25, 2023

[AutoPR redisenterprise/resource-manager] Riya/removeskulist azure-sdk/azure-resource-manager-schemas#3494

Draft

[AutoPR azure-resourcemanager-redisenterprise] Riya/removeskulist azure-sdk/azure-sdk-for-java#7808

Closed

updates to preview api version

35afca5

This was referenced Oct 25, 2023

[AutoPR Azure.ResourceManager.RedisEnterprise] Riya/removeskulist azure-sdk/azure-sdk-for-net#5802

Closed

[AutoPR sdk/resourcemanager/redisenterprise/armredisenterprise] Riya/removeskulist azure-sdk/azure-sdk-for-go#7824

Closed

edit enum

bc6fb0f

This was referenced Oct 25, 2023

[AutoPR track2_azure-mgmt-redisenterprise] Riya/removeskulist azure-sdk/azure-sdk-for-python#5086

Closed

[AutoPR @azure/arm-redisenterprisecache] Riya/removeskulist azure-sdk/azure-sdk-for-js#7268

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Oct 25, 2023

riyasimon23 added 5 commits October 26, 2023 15:00

updates

9e0652b

fix validation

0514b6b

updating redisenterprise

d23a06f

missing bracket

e3528b4

prettier fix

6e1a56f

riyasimon23 requested a review from TimLovellSmith October 30, 2023 00:33

changing order of skuname

75f0a5c

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 30, 2023

riyasimon23 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 30, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 30, 2023

riyasimon23 requested a review from msyyc October 30, 2023 18:01

msyyc added the Approved-SdkBreakingChange-Python label Oct 30, 2023

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 31, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 31, 2023

github-actions bot added the MergeRequested label Oct 31, 2023

TimLovellSmith approved these changes Oct 31, 2023

View reviewed changes

TimLovellSmith merged commit b36917f into Azure:main Oct 31, 2023
29 of 31 checks passed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Oct 31, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Oct 31, 2023

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023

Riya/removeskulist (#26376)

b059207

* updates to preview api version removing unshipped SKUs API

zman-ms pushed a commit that referenced this pull request Jan 10, 2024

Riya/removeskulist (#26376)

db6ea37

* updates to preview api version removing unshipped SKUs API

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Riya/removeskulist #26376

Riya/removeskulist #26376

riyasimon23 commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-workflow-bot bot commented Oct 30, 2023

riyasimon23 commented Oct 30, 2023

riyasimon23 commented Oct 30, 2023

riyasimon23 commented Oct 30, 2023

rkmanda commented Oct 31, 2023

riyasimon23 commented Oct 31, 2023

openapi-pipeline-app bot commented Oct 31, 2023

Riya/removeskulist #26376

Riya/removeskulist #26376

Conversation

riyasimon23 commented Oct 25, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Oct 25, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Oct 25, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 25, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 25, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Oct 30, 2023

riyasimon23 commented Oct 30, 2023

riyasimon23 commented Oct 30, 2023

riyasimon23 commented Oct 30, 2023

rkmanda commented Oct 31, 2023

riyasimon23 commented Oct 31, 2023

openapi-pipeline-app bot commented Oct 31, 2023

riyasimon23 commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 25, 2023 •

edited

Loading