Adding privatedns to allowedresource types for dnsZoneResourceIds #26415

bfoley13 · 2023-10-26T17:49:59Z

Adding private dns zones as applicable resourceTypes for dnsZoneResourceIds. Enables private DNS for app routing addon.

openapi-pipeline-app · 2023-10-26T17:50:03Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR has breaking changes in the generated SDK for python (label: CI-BreakingChange-Python-Track2). Refer to step 3 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-10-26T17:50:04Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 8 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
managedClusters.json	2023-10-02-preview(8dfa0c7)	2023-09-01(main)
managedClusters.json	2023-10-02-preview(8dfa0c7)	2023-09-02-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-10-02-preview/managedClusters.json#L4292:9 Old: aks/stable/2023-09-01/managedClusters.json#L3507:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-10-02-preview/managedClusters.json#L4296:9 Old: aks/stable/2023-09-01/managedClusters.json#L3535:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-10-02-preview/managedClusters.json#L4300:9 Old: aks/stable/2023-09-01/managedClusters.json#L3552:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-10-02-preview/managedClusters.json#L4304:9 Old: aks/stable/2023-09-01/managedClusters.json#L3579:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-10-02-preview/managedClusters.json#L4309:9 Old: aks/stable/2023-09-01/managedClusters.json#L3602:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-10-02-preview/managedClusters.json#L4365:9 Old: aks/stable/2023-09-01/managedClusters.json#L3676:9
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-10-02-preview/managedClusters.json#L4396:11 Old: aks/stable/2023-09-01/managedClusters.json#L3725:11
⚠️ 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: aks/preview/2023-10-02-preview/managedClusters.json#L5282:13 Old: aks/stable/2023-09-01/managedClusters.json#L4491:13

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-preview-2023-10	package-preview-2023-10(8dfa0c7)	package-preview-2023-10(FumingZhang-containerservice-Microsoft.ContainerService-2023-10-02-preview)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: aks/preview/2023-10-02-preview/managedClusters.json#L52
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: aks/preview/2023-10-02-preview/managedClusters.json#L53
`❌` ParametersInPointGet	Query parameter resource-type should be removed. Point Get's MUST not have query parameters other than api version. Location: aks/preview/2023-10-02-preview/managedClusters.json#L80
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: aks/preview/2023-10-02-preview/managedClusters.json#L137
`❌` ResourceNameRestriction	The resource name parameter 'roleName' should be defined with a 'pattern' restriction. Location: aks/preview/2023-10-02-preview/managedClusters.json#L278
`❌` ParametersInPost	server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-10-02-preview/managedClusters.json#L336
`❌` ParametersInPost	server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-10-02-preview/managedClusters.json#L381
`❌` ParametersInPost	format is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-10-02-preview/managedClusters.json#L381
`❌` ParametersInPost	server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-10-02-preview/managedClusters.json#L429
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L553
`❌` PatchResponseCodes	Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: aks/preview/2023-10-02-preview/managedClusters.json#L660
`❌` PatchIdentityProperty	The patch operation body parameter schema should contain property 'identity'. Location: aks/preview/2023-10-02-preview/managedClusters.json#L679
`❌` LroPatch202	The async patch operation should return 202. Location: aks/preview/2023-10-02-preview/managedClusters.json#L689
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L699
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L749
`❌` ResourceNameRestriction	The resource name parameter 'configName' should be defined with a 'pattern' restriction. Location: aks/preview/2023-10-02-preview/managedClusters.json#L809
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/preview/2023-10-02-preview/managedClusters.json#L979
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1023
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1175
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1291
`❌` OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1452
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1472
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1491
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1537
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1553
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1600
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1616
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1657
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1673
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-10-02-preview/managedClusters.json#L1710

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-26T17:50:05Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-containerservice - 27.0.0

+	Renamed operation TrustedAccessRoleBindingsOperations.create_or_update to TrustedAccessRoleBindingsOperations.begin_create_or_update
+	Renamed operation TrustedAccessRoleBindingsOperations.delete to TrustedAccessRoleBindingsOperations.begin_delete

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 00cb64b10e4e713ef94f600753c85564430a0e8b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-containerservice [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ManagedClustersOperations.get_guardrails_versions
info	[Changelog]   - Added operation ManagedClustersOperations.list_guardrails_versions
info	[Changelog]   - Model AgentPool has a new parameter artifact_streaming_profile
info	[Changelog]   - Model AgentPool has a new parameter capacity_reservation_group_id
info	[Changelog]   - Model AgentPool has a new parameter enable_custom_ca_trust
info	[Changelog]   - Model AgentPool has a new parameter gpu_profile
info	[Changelog]   - Model AgentPool has a new parameter message_of_the_day
info	[Changelog]   - Model AgentPool has a new parameter network_profile
info	[Changelog]   - Model AgentPool has a new parameter security_profile
info	[Changelog]   - Model AgentPool has a new parameter windows_profile
info	[Changelog]   - Model AgentPoolUpgradeSettings has a new parameter node_soak_duration_in_minutes
info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter kube_proxy_config
info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter monitoring
info	[Changelog]   - Model ManagedCluster has a new parameter ai_toolchain_operator_profile
info	[Changelog]   - Model ManagedCluster has a new parameter creation_data
info	[Changelog]   - Model ManagedCluster has a new parameter enable_namespace_resources
info	[Changelog]   - Model ManagedCluster has a new parameter guardrails_profile
info	[Changelog]   - Model ManagedCluster has a new parameter ingress_profile
info	[Changelog]   - Model ManagedCluster has a new parameter metrics_profile
info	[Changelog]   - Model ManagedCluster has a new parameter node_provisioning_profile
info	[Changelog]   - Model ManagedCluster has a new parameter node_resource_group_profile
info	[Changelog]   - Model ManagedClusterAPIServerAccessProfile has a new parameter enable_vnet_integration
info	[Changelog]   - Model ManagedClusterAPIServerAccessProfile has a new parameter subnet_id
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter artifact_streaming_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter capacity_reservation_group_id
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter enable_custom_ca_trust
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter gpu_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter message_of_the_day
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter network_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter security_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter windows_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter artifact_streaming_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter capacity_reservation_group_id
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter enable_custom_ca_trust
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter gpu_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter message_of_the_day
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter network_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter security_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter windows_profile
info	[Changelog]   - Model ManagedClusterAzureMonitorProfile has a new parameter logs
info	[Changelog]   - Model ManagedClusterAzureMonitorProfileMetrics has a new parameter app_monitoring_open_telemetry_metrics
info	[Changelog]   - Model ManagedClusterHTTPProxyConfig has a new parameter effective_no_proxy
info	[Changelog]   - Model ManagedClusterLoadBalancerProfile has a new parameter backend_pool_type
info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter daemonset_eviction_for_empty_nodes
info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter daemonset_eviction_for_occupied_nodes
info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter expanders
info	[Changelog]   - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter ignore_daemonsets_utilization
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter custom_ca_trust_certificates
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter image_integrity
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter node_restriction
info	[Changelog]   - Model ManagedClusterStorageProfileDiskCSIDriver has a new parameter version
info	[Changelog]   - Model ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler has a new parameter addon_autoscaling
info	[Changelog]   - Operation AgentPoolsOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget
info	[Changelog]   - Operation ManagedClustersOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Renamed operation TrustedAccessRoleBindingsOperations.create_or_update to TrustedAccessRoleBindingsOperations.begin_create_or_update
info	[Changelog]   - Renamed operation TrustedAccessRoleBindingsOperations.delete to TrustedAccessRoleBindingsOperations.begin_delete

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 00cb64b10e4e713ef94f600753c85564430a0e8b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 00cb64b10e4e713ef94f600753c85564430a0e8b. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/containerservice/armcontainerservice [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `AgentPoolTypeVirtualMachines` added to enum type `AgentPoolType`
info	[Changelog] - New value `OSSKUWindowsAnnual` added to enum type `OSSKU`
info	[Changelog] - New enum type `NodeProvisioningMode` with values `NodeProvisioningModeAuto`, `NodeProvisioningModeManual`
info	[Changelog] - New struct `AgentPoolArtifactStreamingProfile`
info	[Changelog] - New struct `AgentPoolGPUProfile`
info	[Changelog] - New struct `ManagedClusterAIToolchainOperatorProfile`
info	[Changelog] - New struct `ManagedClusterNodeProvisioningProfile`
info	[Changelog] - New field `NodeSoakDurationInMinutes` in struct `AgentPoolUpgradeSettings`
info	[Changelog] - New field `ArtifactStreamingProfile`, `GpuProfile` in struct `ManagedClusterAgentPoolProfile`
info	[Changelog] - New field `ArtifactStreamingProfile`, `GpuProfile` in struct `ManagedClusterAgentPoolProfileProperties`
info	[Changelog] - New field `AiToolchainOperatorProfile`, `NodeProvisioningProfile` in struct `ManagedClusterProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 17 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 00cb64b10e4e713ef94f600753c85564430a0e8b. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-containerservice [View full logs] [Preview SDK Changes]

azure-arm-containerservice-19.5.0-beta.1.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Interface ManagedClusterSnapshot
info	[Changelog]   - Added Interface ManagedClusterSnapshotListResult
info	[Changelog]   - Added Interface ManagedClusterSnapshotsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsDeleteOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsGetOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsListByResourceGroupNextOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsListByResourceGroupOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsListNextOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsListOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsUpdateTagsOptionalParams
info	[Changelog]   - Added Interface NetworkMonitoring
info	[Changelog]   - Added Interface NetworkProfileForSnapshot
info	[Changelog]   - Added Interface PortRange
info	[Changelog]   - Added Interface TrustedAccessRole
info	[Changelog]   - Added Interface TrustedAccessRoleBinding
info	[Changelog]   - Added Interface TrustedAccessRoleBindingListResult
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsDeleteHeaders
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsDeleteOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsGetOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsListNextOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsListOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleListResult
info	[Changelog]   - Added Interface TrustedAccessRoleRule
info	[Changelog]   - Added Interface TrustedAccessRolesListNextOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRolesListOptionalParams
info	[Changelog]   - Added Type Alias AddonAutoscaling
info	[Changelog]   - Added Type Alias AgentPoolSSHAccess
info	[Changelog]   - Added Type Alias BackendPoolType
info	[Changelog]   - Added Type Alias GuardrailsSupport
info	[Changelog]   - Added Type Alias IpvsScheduler
info	[Changelog]   - Added Type Alias Level
info	[Changelog]   - Added Type Alias MachinesGetResponse
info	[Changelog]   - Added Type Alias MachinesListNextResponse
info	[Changelog]   - Added Type Alias MachinesListResponse
info	[Changelog]   - Added Type Alias ManagedClustersGetGuardrailsVersionsResponse
info	[Changelog]   - Added Type Alias ManagedClustersListGuardrailsVersionsNextResponse
info	[Changelog]   - Added Type Alias ManagedClustersListGuardrailsVersionsResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsGetResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListNextResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsUpdateTagsResponse
info	[Changelog]   - Added Type Alias Mode
info	[Changelog]   - Added Type Alias NodeProvisioningMode
info	[Changelog]   - Added Type Alias Protocol
info	[Changelog]   - Added Type Alias RestrictionLevel
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingProvisioningState
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsDeleteResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsGetResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsListNextResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsListResponse
info	[Changelog]   - Added Type Alias TrustedAccessRolesListNextResponse
info	[Changelog]   - Added Type Alias TrustedAccessRolesListResponse
info	[Changelog]   - Interface AgentPool has a new optional parameter artifactStreamingProfile
info	[Changelog]   - Interface AgentPool has a new optional parameter capacityReservationGroupID
info	[Changelog]   - Interface AgentPool has a new optional parameter enableCustomCATrust
info	[Changelog]   - Interface AgentPool has a new optional parameter gpuProfile
info	[Changelog]   - Interface AgentPool has a new optional parameter messageOfTheDay
info	[Changelog]   - Interface AgentPool has a new optional parameter networkProfile
info	[Changelog]   - Interface AgentPool has a new optional parameter securityProfile
info	[Changelog]   - Interface AgentPool has a new optional parameter windowsProfile
info	[Changelog]   - Interface AgentPoolsDeleteOptionalParams has a new optional parameter ignorePodDisruptionBudget
info	[Changelog]   - Interface AgentPoolUpgradeSettings has a new optional parameter nodeSoakDurationInMinutes
info	[Changelog]   - Interface ContainerServiceNetworkProfile has a new optional parameter kubeProxyConfig
info	[Changelog]   - Interface ContainerServiceNetworkProfile has a new optional parameter monitoring
info	[Changelog]   - Interface ManagedCluster has a new optional parameter aiToolchainOperatorProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter creationData
info	[Changelog]   - Interface ManagedCluster has a new optional parameter enableNamespaceResources
info	[Changelog]   - Interface ManagedCluster has a new optional parameter guardrailsProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter ingressProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter metricsProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter nodeProvisioningProfile
info	[Changelog]   - Interface ManagedCluster has a new optional parameter nodeResourceGroupProfile
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter artifactStreamingProfile
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter capacityReservationGroupID
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter enableCustomCATrust
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter gpuProfile
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter messageOfTheDay
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter networkProfile
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter securityProfile
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter windowsProfile
info	[Changelog]   - Interface ManagedClusterAPIServerAccessProfile has a new optional parameter enableVnetIntegration
info	[Changelog]   - Interface ManagedClusterAPIServerAccessProfile has a new optional parameter subnetId
info	[Changelog]   - Interface ManagedClusterAzureMonitorProfile has a new optional parameter logs
info	[Changelog]   - Interface ManagedClusterAzureMonitorProfileMetrics has a new optional parameter appMonitoringOpenTelemetryMetrics
info	[Changelog]   - Interface ManagedClusterHttpProxyConfig has a new optional parameter effectiveNoProxy
info	[Changelog]   - Interface ManagedClusterLoadBalancerProfile has a new optional parameter backendPoolType
info	[Changelog]   - Interface ManagedClusterPropertiesAutoScalerProfile has a new optional parameter daemonsetEvictionForEmptyNodes
info	[Changelog]   - Interface ManagedClusterPropertiesAutoScalerProfile has a new optional parameter daemonsetEvictionForOccupiedNodes
info	[Changelog]   - Interface ManagedClusterPropertiesAutoScalerProfile has a new optional parameter expanders
info	[Changelog]   - Interface ManagedClusterPropertiesAutoScalerProfile has a new optional parameter ignoreDaemonsetsUtilization
info	[Changelog]   - Interface ManagedClustersDeleteOptionalParams has a new optional parameter ignorePodDisruptionBudget
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter customCATrustCertificates
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter imageIntegrity
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter nodeRestriction
info	[Changelog]   - Interface ManagedClusterStorageProfileDiskCSIDriver has a new optional parameter version
info	[Changelog]   - Interface ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler has a new optional parameter addonAutoscaling
info	[Changelog]   - Added Enum KnownAddonAutoscaling
info	[Changelog]   - Added Enum KnownAgentPoolSSHAccess
info	[Changelog]   - Added Enum KnownBackendPoolType
info	[Changelog]   - Added Enum KnownGuardrailsSupport
info	[Changelog]   - Added Enum KnownIpvsScheduler
info	[Changelog]   - Added Enum KnownLevel
info	[Changelog]   - Added Enum KnownMode
info	[Changelog]   - Added Enum KnownNodeProvisioningMode
info	[Changelog]   - Added Enum KnownProtocol
info	[Changelog]   - Added Enum KnownRestrictionLevel
info	[Changelog]   - Added Enum KnownTrustedAccessRoleBindingProvisioningState
info	[Changelog]   - Enum KnownAgentPoolType has a new value VirtualMachines
info	[Changelog]   - Enum KnownNetworkPolicy has a new value None
info	[Changelog]   - Enum KnownNodeOSUpgradeChannel has a new value SecurityPatch
info	[Changelog]   - Enum KnownOssku has a new value Mariner
info	[Changelog]   - Enum KnownOssku has a new value WindowsAnnual
info	[Changelog]   - Enum KnownPublicNetworkAccess has a new value SecuredByPerimeter
info	[Changelog]   - Enum KnownSnapshotType has a new value ManagedCluster
info	[Changelog]   - Enum KnownWorkloadRuntime has a new value KataMshvVmIsolation

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 00cb64b10e4e713ef94f600753c85564430a0e8b. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.ContainerService [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.ContainerService.1.2.0-alpha.20231026.1.nupkg
```
info	[Changelog]
```

️❌ azure-resource-manager-schemas failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 00cb64b10e4e713ef94f600753c85564430a0e8b. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.1
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.1>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.1` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
cannot force update branch 'sdkAuto/26415/containerservice' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/26415/containerservice' as it is the current HEAD of the repository.

️✔️containerservice [View full logs]

️✔️containerservice [View full logs]

error	Fatal error: cannot force update branch 'sdkAuto/26415/containerservice' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		containerservice
error		containerservice

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 00cb64b10e4e713ef94f600753c85564430a0e8b. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.containerservice.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.containerservice.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-26T17:50:06Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/containerservice/armcontainerservice	https://apiview.dev/Assemblies/Review/1b84a9d38b1243348f167cfa4e8f798b
Java	azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated	https://apiview.dev/Assemblies/Review/a39710d1c66f4fa58c69956e0833151f
.Net	Azure.ResourceManager.ContainerService	There is no API change compared with the previous version
JavaScript	@azure/arm-containerservice	https://apiview.dev/Assemblies/Review/d49fa2095fc641468724bdc2013a66ae
Swagger	Microsoft.ContainerService	https://apiview.dev/Assemblies/Review/918fd6e29e0241039d5aa2042dfa99d1

FumingZhang

lgtm

will merge the change tomorrow if no other comments

…6415) * Adding privatedns to allowedresource types for dnsZoneResourceIds * fix style

Adding privatedns to allowedresource types for dnsZoneResourceIds

ec224b3

bfoley13 requested review from palma21, weinong, alvinli222, matthchr and circy9 as code owners October 26, 2023 17:50

fix style

8dfa0c7

azure-sdk mentioned this pull request Oct 26, 2023

[AutoPR sdk/resourcemanager/containerservice/armcontainerservice] Adding privatedns to allowedresource types for dnsZoneResourceIds azure-sdk/azure-sdk-for-go#7846

Closed

AzureRestAPISpecReview added the resource-manager label Oct 26, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Oct 26, 2023

FumingZhang reviewed Oct 27, 2023

View reviewed changes

FumingZhang merged commit 3786d86 into FumingZhang-containerservice-Microsoft.ContainerService-2023-10-02-preview Oct 30, 2023

FumingZhang deleted the brfole/private-dns-changes branch October 30, 2023 08:11

FumingZhang pushed a commit that referenced this pull request Nov 8, 2023

Adding privatedns to allowedresource types for dnsZoneResourceIds (#2…

cef042b

…6415) * Adding privatedns to allowedresource types for dnsZoneResourceIds * fix style

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding privatedns to allowedresource types for dnsZoneResourceIds #26415

Adding privatedns to allowedresource types for dnsZoneResourceIds #26415

bfoley13 commented Oct 26, 2023

openapi-pipeline-app bot commented Oct 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 26, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 26, 2023 •

edited

Loading

FumingZhang left a comment

Adding privatedns to allowedresource types for dnsZoneResourceIds #26415

Adding privatedns to allowedresource types for dnsZoneResourceIds #26415

Conversation

bfoley13 commented Oct 26, 2023

openapi-pipeline-app bot commented Oct 26, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Oct 26, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 26, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 26, 2023 • edited Loading

Generated ApiView

FumingZhang left a comment

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Oct 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 26, 2023 •

edited

Loading