Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx: configurationName can only ever be default (per the API/docs) so hardcoding this value #26883

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

nginx: configurationName can only ever be default (per the API/docs) so hardcoding this value #26883

wants to merge 1 commit into from

Conversation

tombuildsstuff
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • The value for configurationName can only ever be set to default - therefore this isn't a configurable value and shouldn't be exposed as such. This is leading to this known issue within Nginx because the API only allows a single value for configurationName (causing this issue).

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

  • For general PR approval workflow, see the diagram at the top of this comment.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 29, 2023 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 29, 2023 •
edited
Loading

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
swagger.json 2022-08-01(9d0699a) 2022-08-01(main)
swagger.json 2023-04-01(9d0699a) 2023-04-01(main)
Rule Message
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Nginx.NginxPlus/nginxDeployments/{deploymentName}/configurations/{configurationName}' removed or restructured?
Old: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L302:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Nginx.NginxPlus/nginxDeployments/{deploymentName}/configurations/{configurationName}' removed or restructured?
Old: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L302:5
❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L302:5
❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L302:5
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️❌LintDiff: 11 Errors, 18 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-04-01 package-2023-04-01(9d0699a) package-2023-04-01(main)
package-2022-08-01 package-2022-08-01(9d0699a) package-2022-08-01(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L302		 RPC-Uri-V1-05
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L396
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L410		 RPC-Delete-V1-01
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L437		 RPC-Async-V1-07
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L446
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L302		 RPC-Uri-V1-05
❌ RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L346
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L396
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L410		 RPC-Delete-V1-01
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L437		 RPC-Async-V1-07
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L446
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L314
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L317
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L323
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L360
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L363
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L369
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L421
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L424
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L430
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L314
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L317
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L323
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L360
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L363
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L369
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L421
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L424
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L430


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L29
❌ ResourceNameRestriction The resource name parameter 'certificateName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L29
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L137
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L151
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L185
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L194
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L206
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L254
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L458
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L551
❌ PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L565
❌ UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L590
❌ LroPatch202 The async patch operation should return 202.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L598
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L614
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L625
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L652
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L661
❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L779
❌ TrackedResourcePatchOperation Tracked resource 'NginxCertificate' must have patch operation that at least supports the update of tags.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L837
❌ TrackedResourcePatchOperation Tracked resource 'NginxConfiguration' must have patch operation that at least supports the update of tags.
Location: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L932
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L29
❌ ResourceNameRestriction The resource name parameter 'certificateName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L29
❌ RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L80
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L137
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L151
❌ LroLocationHeader A 202 response should include an Location response header.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L185
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L194
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L206
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L254
❌ ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/stable/2023-04-01/swagger.json#L458
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
Rule Message
❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L181:22
ExampleUrl: stable/2022-08-01/examples/Certificates_Delete.json
❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L433:22
ExampleUrl: stable/2022-08-01/examples/Configurations_Delete.json
❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L648:22
ExampleUrl: stable/2022-08-01/examples/Deployments_Delete.json
❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L181:22
ExampleUrl: stable/2022-08-01/examples/Certificates_Delete.json
❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L433:22
ExampleUrl: stable/2022-08-01/examples/Configurations_Delete.json
❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: NGINX.NGINXPLUS/stable/2022-08-01/swagger.json#L648:22
ExampleUrl: stable/2022-08-01/examples/Deployments_Delete.json
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 29, 2023 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/nginx/armnginx - 4.0.0
+	Function `*ConfigurationsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, *ConfigurationsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, *ConfigurationsClientBeginCreateOrUpdateOptions)`
+	Function `*ConfigurationsClient.BeginDelete` parameter(s) have been changed from `(context.Context, string, string, string, *ConfigurationsClientBeginDeleteOptions)` to `(context.Context, string, string, *ConfigurationsClientBeginDeleteOptions)`
+	Function `*ConfigurationsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, *ConfigurationsClientGetOptions)` to `(context.Context, string, string, *ConfigurationsClientGetOptions)`
❌azure-sdk-for-js - @azure/arm-nginx - 4.0.0
+	Operation Configurations.beginCreateOrUpdate has a new signature
+	Operation Configurations.beginCreateOrUpdateAndWait has a new signature
+	Operation Configurations.beginDelete has a new signature
+	Operation Configurations.beginDeleteAndWait has a new signature
+	Operation Configurations.get has a new signature
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from d3fa3a3687ddf4f5daf0a17bbb25e79f94320b97. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/nginx/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Nginx [View full logs]  [Preview SDK Changes] 
    warn	Skip artifact folder because it doesn't exist: artifacts/packages
️❌ azure-sdk-for-python-track2 failed [Detail]
  • ❌Code Generator Failed [Logs] Generate from d3fa3a3687ddf4f5daf0a17bbb25e79f94320b97. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.4` to update!
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh]  4304800 bytes remaining to read
cmderr	[automation_generate.sh] xz: (stdin): Unexpected end of input
cmderr	[automation_generate.sh] tar: Unexpected EOF in archive
cmderr	[automation_generate.sh] tar: Unexpected EOF in archive
cmderr	[automation_generate.sh] tar: Error is not recoverable: exiting now
cmderr	[automation_generate.sh]   Error: failed to download archive for 16.15.0
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from d3fa3a3687ddf4f5daf0a17bbb25e79f94320b97. SDK Automation 14.0.0 
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-nginx [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from d3fa3a3687ddf4f5daf0a17bbb25e79f94320b97. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/nginx/armnginx [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*ConfigurationsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, *ConfigurationsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, *ConfigurationsClientBeginCreateOrUpdateOptions)`
info	[Changelog] - Function `*ConfigurationsClient.BeginDelete` parameter(s) have been changed from `(context.Context, string, string, string, *ConfigurationsClientBeginDeleteOptions)` to `(context.Context, string, string, *ConfigurationsClientBeginDeleteOptions)`
info	[Changelog] - Function `*ConfigurationsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, *ConfigurationsClientGetOptions)` to `(context.Context, string, string, *ConfigurationsClientGetOptions)`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from d3fa3a3687ddf4f5daf0a17bbb25e79f94320b97. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-nginx [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation Configurations.beginCreateOrUpdate has a new signature
info	[Changelog]   - Operation Configurations.beginCreateOrUpdateAndWait has a new signature
info	[Changelog]   - Operation Configurations.beginDelete has a new signature
info	[Changelog]   - Operation Configurations.beginDeleteAndWait has a new signature
info	[Changelog]   - Operation Configurations.get has a new signature
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from d3fa3a3687ddf4f5daf0a17bbb25e79f94320b97. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.4
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.4` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️❌ azure-powershell failed [Detail]
  • ❌Pipeline Framework Failed [Logs] Generate from d3fa3a3687ddf4f5daf0a17bbb25e79f94320b97. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Connection reset by peer
Error: SSL error: syscall failure: Connection reset by peer
  • ️✔️Az.nginx.DefaultTag [View full logs]  
    error	Fatal error: SSL error: syscall failure: Connection reset by peer
error	The following packages are still pending:
error		Az.nginx.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 29, 2023 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/nginx/armnginx Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java azure-resourcemanager-nginx Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript @azure/arm-nginx Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger NGINX.NGINXPLUS Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 29, 2023
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.

This was referenced Nov 29, 2023
Draft
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager RPaaS labels Nov 29, 2023
@openapi-workflow-bot openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

This was referenced Nov 29, 2023
Closed
Closed
Closed
tombuildsstuff added a commit to hashicorp/pandora that referenced this pull request Nov 29, 2023
@tombuildsstuff
tools/importer-rest-api-specs: adding a workaround covering Azure/azu…
a0d4de5 
…re-rest-api-specs#26883
@tombuildsstuff tombuildsstuff mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rkmanda rkmanda

Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager RPaaS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tombuildsstuff @rkmanda @AzureRestAPISpecReview