Azure VMware Solution 2023-09-01 in TypeSpec #28023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/1628d55466662ec03975068d8ec9a7ea760b0474/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-09-01/vmware.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-03-01/vmware.json", "details":"incompatible properties : tags " |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/1628d55466662ec03975068d8ec9a7ea760b0474/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-09-01/vmware.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/vmware/resource-manager/Microsoft.AVS/preview/2021-01-01-preview/vmware.json", "details":"incompatible properties : tags " |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| package-2023-09-01 | package-2023-09-01(1628d55) | default(main) |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.AVS/privateClouds/{}/workloadNetworks/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/vmware/resource-manager/readme.md json: Microsoft.AVS/stable/2023-03-01/vmware.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
cataggar
commented
Mar 1, 2024
This was referenced Mar 1, 2024
[AutoPR @azure/arm-avs] Azure VMware Solution 2023-09-01 in TypeSpec
azure-sdk/azure-sdk-for-js#8839
Closed
AzureRestAPISpecReview
added
ARMReview
new-api-version
resource-manager
SuppressionReviewRequired
TypeSpec
|
The LintDiff EvenSegmentedPathForPutOperation errors look like false positives, so I created Azure/azure-sdk-tools#7801 . |
|
Changes look fine could you please add specific suppressions rahter than for the whole file for the suppression review ? |
This was referenced Mar 15, 2024
cataggar
added
the
WaitForARMFeedback
openapi-workflow-bot
bot
removed
the
ARMSignedOff
|
All suppressions have paths. LintDiff is passing. Please grant suppression approval. I would like this PR merged. |
raosuhas
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/pr RequestMerge |
raosuhas
approved these changes
Mar 15, 2024
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Mar 15, 2024
* copy 2023-03-01 * update readme * add TypeSpec * TypeSpec examples * tsp compile * these examples were renamed * set default tag to new API version * Properties of a PATCH request body must not have default value, property:internet. * remove Maintenances (Azure#28028) * new audience parameter must be optional * remove custom rename from 2023-09-01 API (Azure#28105) * remove ProvisionedNetwork ProxyResource (Azure#28108) * remove AvailabilityZones from 2023-09-01 API (Azure#28111) * "quota", not "quote" * "quota" fix in swagger * remove "workloadNetworkName": "default" from example * TypeSpec compiler v0.54.0 * suppress namedOutputs again * suppress 200s in deletes * suppress missing-x-ms-identifiers * format tspconfig.yaml * suppress false positives (Azure#28220) * use common LocationParameter (Azure#28221) * remove LintDiff suppressions in readme (Azure#28222) * add minimal suppressions back (Azure#28234) * do not specify x-ms-long-running-operation-options for VirtualMachines_RestrictMovement * specify paths for suppressions (Azure#28281)
vxfield
pushed a commit
that referenced
this pull request
Mar 28, 2024
* copy 2023-03-01 * update readme * add TypeSpec * TypeSpec examples * tsp compile * these examples were renamed * set default tag to new API version * Properties of a PATCH request body must not have default value, property:internet. * remove Maintenances (#28028) * new audience parameter must be optional * remove custom rename from 2023-09-01 API (#28105) * remove ProvisionedNetwork ProxyResource (#28108) * remove AvailabilityZones from 2023-09-01 API (#28111) * "quota", not "quote" * "quota" fix in swagger * remove "workloadNetworkName": "default" from example * TypeSpec compiler v0.54.0 * suppress namedOutputs again * suppress 200s in deletes * suppress missing-x-ms-identifiers * format tspconfig.yaml * suppress false positives (#28220) * use common LocationParameter (#28221) * remove LintDiff suppressions in readme (#28222) * add minimal suppressions back (#28234) * do not specify x-ms-long-running-operation-options for VirtualMachines_RestrictMovement * specify paths for suppressions (#28281)
7 tasks
hiaga
pushed a commit
to hiaga/azure-rest-api-specs
that referenced
this pull request
May 21, 2024
Resolved comments
[Batch] Azure Batch Data Plane 2024-02-01.19.0 (#27505)
Added the summary property to the data services (#27829)
* Added the summary property for the data registry service API.
* Added the summary properties for the data v2 service APIs.
* Added the summary properties for the data v1 service APIs.
* Added the summary properties for the data v2 service APIs.
Relay : Updated with optional property trustedServiceAccessEnabled in NetworkRuleSet (#27709)
* Updated with optional property trustedServiceAccessEnabled in NetworkRuleSet
* fix prettier check failures
[Microsoft.Marketplace][Discovery][ApiKeys] - Adding documentation for self-service discovery api keys (#27470)
* Adding apiKey documentation
* Fixing document name typo
* Fixing code formatting to use prettier
* Moving readme file to correct nesting location
* PR validation fixes
* Formatting with prettier
* PR Validation fixes
* NextPageLink
* Removing nextPageLink
* Removing redundant sub parameter from examples
* More fixes
* nextLink fixes
* fixing subscriptionId capital
* Adding ref to subscriptionId
* Adding subscription param
* updating post path type
* Fixing path to capital
* reverting capital in post path
* Adding "discovery" to path
* revert to previous path name
* Adding key alias
* Updating key api examples
* Linting errors fix
* Removing x-ms-pageable
* More bugfixes
* Changing dictionary type
* Fixing prettier issues
* Fix pageable
* fix ref and pageable
* Fixing pageable value issue
* changing nextLink property
* Replaceing null value of nextLink
* Reading api keys as objects
* Change return type of listing controller
* Updating create key
* Fixing prettier issues
* Change return type of api key
* Updating object descriptions
* Updating technical descriptions
* Adding full stops to descriptions
* Fixing API Keys description
* Adding missing full stop
* Fixing PR comments
* Updating to standard error response
* Fixing invalid object examples
openai, update tsp for *AsPlainText op, request as multipart/form-data, and response as text/plain (#26412)
[Hub generated spec] recoveryservicesbackup microsoft.recovery services 2024 01 01 (#27775)
* Adds base for updating Microsoft.RecoveryServices from version stable/2023-08-01 to version 2024-01-01
* Updates readme
* Updates API version in new specs and examples
* Update readme.md: Removing multiple default tags to resolve avocado error.
* Update readme.md: Remove tag
* resolved issues with readme
---------
Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com>
NGINX@2024-01-01-preview: Add to readme.md (#27891)
Add PostgreSqlV2 Connector (#27893)
* Add PostgreSqlV2 Connector
* Add PostgreSqlV2 Connector
* Add PostgreSqlV2 Connector
* Add PostgreSqlV2 Connector
* Add PostgreSqlV2 Connector
* Add PostgreSqlV2 Connector
Batch DataPlane TypeSpec (#26381)
Batch TypeSpec Definition
---------
Co-authored-by: NickKouds <nickouds@hotmail.com>
Co-authored-by: hoppe <hoppewang@microsoft.com>
Co-authored-by: David Watrous <dave.watrous@microsoft.com>
Co-authored-by: Sanjana Kapur <sanjanakapur@microsoft.com>
Create Api Version Microsoft.Search 2024-03-01-preview (#27450)
* Adds base for updating Microsoft.Search from version preview/2021-04-01-preview to version 2024-03-01-preview
* Updates readme
* Updates API version in new specs and examples
* Update semantic description for free tier
* Update 2024-03-01-Preview api version to have 2023-11-01 api changes
* Add quota usages
* Update quota usages descriptions and types +lint
* swagger prettier changes
* Address comments, update descriptions and grammar
* Add NSP contracts to API version.
* Fix missing token.
* Fix missing tokens.
* Fix reference issues.
* refactor nsp changes.
* Fix minor semantic issues
* Add descriptions.
* Fix description
* Prettier fixes
* Add pattern for SearchServiceParameter to comply with pattern RPC policy
* Update branding and descriptions
* Add suppressions for LroErrorContent and AvoidAdditionalProperties
* Align versioning on all common types
* Further update descriptions to improve locale changes and readability
---------
Co-authored-by: Jacob Hill <thhill@microsoft.com>
[Microsoft.DeviceRegistry] Migrated Microsoft.DeviceRegistry 2023-11-01-preview API to TypeSpec (#27566)
* Migrated Microsoft.DeviceRegistry 2023-11-01-preview API to TypeSpec
* Fixed AssetEndpointProfiles examples path
* Fixed operations examples
* Regenerated swagger file
* Added example reference for GetOperationStatus API
* Fixed AssetEndpointProfiles examples
* Moved to v3 common types (TypeSpec default)
* - Fixed EventsObservabilityMode reference name in Assets
- Generated swaggers with latest tsp compiler
* Fixed Asset Endpoint Profile anonymous auth mode description
Update Route Directions API (#27651)
* first commit
* update
* update
---------
Co-authored-by: Will Huang <huangwill@microsoft.com>
Clean-up Data swagger files (#27720)
* Update readme.md: Common/stable/2023-06-01
current: Common/stable/2023-07-01
Updated: Common/stable/2023-06-01
* Moved swagger files: Data v1/v2 & Render v1 to directories consistent with the other Azure Maps swagger files.
* Changed 'Macao' to 'Macao SAR'.
* Data service updates
Fix two broken links in Route v2 (2023-10-01-preview) (#27904)
* Fixed broken route-v2 links.
* Fixed broken route-v2 links.
Broken links (#27906)
[npm-install.yml] Ignore errors from "npm ls -a" (#27934)
- Step is only informational
[Hub Generated] Publish private branch 'raghumunukutla-supportrp-Microsoft.Support-2023-06-01-preview' (#27544)
* Adds base for updating Microsoft.Support from version preview/2022-09-01-preview to version 2023-06-01-preview
* Updates readme
* Updates API version in new specs and examples
* Changes for updating swagger and corresponding examples
* Added one example
* Changes to address check failures
* Changes to fix breaking changes
* Changes to address couple of other checks
* Minor change
* Minor fix
* Changes as per PR comments
* Changes for adding support to classifyProblems at tenant scope
* Minor change
* Changes for addressing comments
* 1. Changes for adding classifyservices apis for both tenant and subscription scope
2. Changes for adding a new property related service for problem classification api
* Minor changes to fix failures related to automated checks
* Changes as per review comments
* Minor changes for updating the examples
* Minor change for updating examples
* Changes as per PR comments
* Minor change
* Minro change to example file
* Changes for adding: "x-ms-parameter-location" to parameters
* Changes for adding suppressions for additional properties
* On top of signed off private preview PR, below are couple of changes added in this commit:
- Remove readonly for enrollmentId which is now also sent as create ticket payload
- Adding a new api(lookUpResourceId) which was in a different version of private preview(2019-05-01-preview)
* Minor change for fixing the model validation
* Changes for updating type from number to integer as suggested by CLI team
* Changes as per review comments
* Changes for adding suppression
* Based on recommendation from Java SDK team.
* Changes in the operationid to have commandlets generated in a desired way for powershell/cli
---------
Co-authored-by: Vijaya Munukutla <vimunuku@microsoft.com>
Addressing .net sdk comments (#27708)
* Addressing .net sdk comments
* Change the name from DiscoSourceKind to DiscoverySourceKind for csharp sdk
* Change disco to discovery in operations
* use ValidateResult as the returns type of validate endpoint
* Change the key name of SavedFilter from filterName to savedFilterName
* Re-added the ValidateResult model as it breaks validate endpoint
* Move all path parameters to endpoint
* Change single word model name
* Regenerate json spec
* Update saved filter examples
* Sync with main
* Fix prettier in examples
* Update model names
* use clientName instead of projectedName. Suppress property name conflict
* Use projected name instead of client name
* run typespec validation
* Fix breaking change
* Update examples
* Use projected name for routes as well
* Run typespec validation
* Add more comments
* Add doc for observedportstate value
* Update request model name
* Change Request to Payload
* Change Request to Payload
* Update request to payload
* update json file
Moving Microsoft.Workloads/SapDiscoverySites with API version 2023-10-01-preview to Public repo for Public preview (Onboarded to typespec) (#27791)
* Initial commit based on https://github.com/Azure/azure-rest-api-specs-pr/pull/16889
* synced with https://github.com/Azure/azure-rest-api-specs-pr/pull/16889
* Synced with https://github.com/Azure/azure-rest-api-specs-pr/pull/16924
* added supressions for lintDiff errors
* updated descriptions based on PM suggestions
* supressed PatchBodyParametersSchema as "This API is inaccessible from end user and is there for purposes to make sure service can make patch calls for updating properties"
Update readme.python.md (#27956)
Release sql microsoft.sql 2023 08 01 preview (#27828)
* Adds base for updating Microsoft.Sql from version preview/2023-05-01-preview to version 2023-08-01-preview
* Updates readme
* Updates API version in new specs and examples
* Add the memory MB parameter for LocationCapabilities.json for 2023-08-01-preview api version (#26820)
* Revert client tag to package-composite-v5 (#26809)
* DAG API 2023-08-01 for Chimera DRv2 (#27236)
* Chimera DRv2 DAG REST API Swagger update
* spelling updatre
* adding x-ms-identifiers
* Adding pattern
* location header update
* addressing comments
* reverting to v1
* ResourceNameRestriction
* Adding Swagger files for 2023-08-01 preview Api Release (#27417)
* adding swagger files for 2023-08-01 Api release
* resolving spell check issues and exceptions to words like Freemium and others
* resolving spell check errors msdtcdns and msdtc's
* resolving erros
* resolving model validation errors
* adding changes for model validation error
* adding changes for model validation errors
* adding 202 response headers for virtualclusterdelete.json file
* resolving lint diff errors
* resolving model validation errors and comments
* resolving error
* resolving symentic errors
* resolving avocado errors
* resolving uniquex-ms-enum error
* reverting the changes
* resolving typing mistake
* reverting the changes for MaintenanceWindows
* removed the extra json file added in readme file
* removing another occurence
---------
Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>
---------
Co-authored-by: UrosKrsticMIPerf <150959695+UrosKrsticMIPerf@users.noreply.github.com>
Co-authored-by: Ji Wang <jiwang5@microsoft.com>
Co-authored-by: ms-mjovkovic <140057686+ms-mjovkovic@users.noreply.github.com>
Co-authored-by: Ravi Gautam <ravigautam@microsoft.com>
Update Examples (#27928)
Wiboris batch microsoft.batch 2024 02 01 (#27675)
* Adding support for version 2024-02-01
adding in a missing format (#27952)
Revert "Mvvsubbu databricks microsoft.databricks 2024 02 01 preview" (#27884)
* Revert "Mvvsubbu databricks microsoft.databricks 2024 02 01 preview (#27607)"
This reverts commit 39608b2c1c7b7dc06cb99abb9d733665cfce9a75.
* Updating Package Tag in Readme file
Johnkoh msft azuredatatransfer microsoft.azure data transfer 2024 01 25 (#27925)
* Adds base for updating Microsoft.AzureDataTransfer from version preview/2023-10-11-preview to version 2024-01-25
* Updates readme
* Updates API version in new specs and examples
* Add BillingTier to new messagingOptions property
* Run prettier
Noneumar alertsmanagement microsoft.alerts management 2024 01 01 preview (#27216)
* Adds base for updating Microsoft.AlertsManagement from version preview/2023-08-01-preview to version 2023-12-01-preview
* Updates readme
* Updates API version in new specs and examples
* New 2023-12-01-preview private API version.
* updated the swagger
* Added preview API 2024-01-01-preview
* fixed readme
* fixed readme
* fixed readme
* after review
* changed correlationTime to correlationDateTime
* Updated the hasEnrichments description.
* Added missing fields
update readme.typescript,md from edgemarketplace (#27990)
* update readme.typescript,md from edgemarketplace
* update
[Public][main][awsconnector] Update cSpell.json (#27996)
[EventGrid] System Events in TypeSpec (#27672)
* [Do not Merge] Eventgrid to CADL (#19819)
* Initial commit
* formatted
* fix appconfig
* API management fix
* keyvault
* Storage
* signalR
* servicebus
* resources
* redis
* policy insights
* eventhub
* Iothub
* cr
* cr-2
* web
* maps
* healthcare APi
* media services
* media services
* ACS
* Eg omdels
* updating healthcare api enum for cadl
* change number in Maps.cadl to float64
* changing Map<k,V> to Record<V>
* update service title and version for healthcareapi
* fix containerregistry
* container registry updated
* updating container service cadl
* eventgrid service version
* eventhub cadl service version
* healthcare api cadl
* iothub cadl
* keyvault cadl
* machine learning cadl
* maps cadl
* policyInsights cadl
* redis cache cadl
* resources cadl
* servicebus cadl
* signalRservice cadl
* web cadl -- may need improvements
* updating cadl inheritance story
* made a remove an add on communication
* trying 2 namespaces
* cleaning up container
* 2nd anmespace for baseevent container
* adding in docs to healthcare cadl
* add doc for healthcareresourcetype enum
* save recent
* two namespaces mediaservices
* policy insights 2 namespaces
* two namespaces resources
* two namespaces sb
* 2 namespace signalr
* storage 2 namespaces
* 2 namespaces web cadl
* ran prettier on cadl
* working on adding publish to EG cadl
* updating EG cadl
* updated cadl version
* remove service
* remove repo level files
* changing baseEvents to alias
* adding evnetgrid subnamespace to all files
* inital generated swagger files from cadl
* generation step initial
* generation step initial2
* changing gen steps
* change extends to spread
* added in apimanagementgateway to cadl
* cadl databox
* updating cadl to align with public client
* adding auth and apiversion fix
* adding cadl output and operations file to show overlaod
* overload?
* eg
* try overlaod again
* save here try to see why models are not showing
* save
* generalevent publish function
* shared route
* remove commented code
* rename to typespec
* eventgrid updates
* refactoring
* zonedDateTime to utcDateTime
* update eg versioning
* remove unused folders
* update eg tsp
* fix web warnings
* storage warnings
* fix signalr warnings
* addressing warnings
* update warnings
* typespec openapi.json
* addressed warnings
* gen swagger to compare
* update format
* update mapping script
* updates
* fix appconfig
* update ACS
* update containerservice
* regen and edits
* update databox
* update script
* update healthcare
* iothub
* updating mapping script
* update ref
* enum doc .45
* update to valueof string
* update preview tag
* extra period appconfig
* update communication tsp
* update containerservice
* update databox
* iohtub upstate
* update healthcareAPis
* media services read visb
* add storage events
* refactor EG
* changed integer to int64
* int64
* update readme
* move location of tsp-config for generation
* updates for gen testing
* tsp format
* blank line
* delete gen file
* changes
* add script
* update import
* update
* update client
* add tsp
* remove autorest import
* iotHub update
* typo viop -> voip
* update int type
* update type
* eventhub int32
* update maps
* update tsp
* update auth
* add eg system events
* remove excess models
* work on versioning -- part 1
* generate only eventgrid sys events
* typspec sys events
* remove uneeded import
* tsp format
* add doc
* add app config models
* mark internal for gen of v1
* Revert "mark internal for gen of v1"
This reverts commit 15c09989a6ceda3688983787d22dd646b175d2a3.
* @usage
* add ACS event change
* use @usage
* move systemEvents into preview version for compile
* update to just output
* add access public
* add acess to script
* remove commented
* system events not specific to version
* change import level
* update generate swagger
* initializing "write in typespec doc"
* move typespec guide to typespec readme
* Resource Notifications pr 25848
* add acsrouter events
* update model lists
* u[date .net changes
* update tsp communication error
* move around file placement for tempTypeSpecFile
* move out of folder
* renme
* rename
* resolving warnings
* all in one file
* two client customization
* remove todo
* format
* combine files to add communicationIdentifierModel to client.tsp
* Update README.md
* Update README.md
* add resourceNotifications
* ... to extends ***
* WIP- media services
* suppress composition-over-inheritance
* update swagger with sys events
* int64 instead of int32
* change to string record
* update json
* gen sysEvents separately with dummy operation for ease of viewing
* remove dummyOperation
* richard generate diff updates
* richard gen tsp changes part 2
* remove dummy operation from client
* make non-anon model IotHub
* anon model sku fix
* script update + enums added to client_systemEvents
* changes after customization folder
* tsp format and Usage.output only
* update script
* starting changes for PR
* update readme
* remove diffs
* change namespace to Microsoft.EventGrid.SystemEvents
* move swagger location
* most recents sys events merged
* encode?
* typo
* add package name for CI
* add examples folder
* no need for url endpoint
* remove http
* change docs, move imports
* add metadata
* update docstrings
* try to resolve examples issue
* remove script
* start updating samples
* add commError back
* remove api-version
* rename samples back to examples
* try adding blank opId
* add opID
* need version
* add examples with operationID
* update exmaples
* prettier
* prettier
* ran prettier
* remove floats
* update readme
* enum to union
* add quotes
* update
* update compile
* commit
* Revert "update compile"
This reverts commit d642125aa2b2f28e1601aa8af0dbf17353580fee.
* compile with 0.39.1
* fixes from projectedName
* compile
* fixing incorrect usage of friendlyName
* fix x-ms-client-names
* change to clientName
* Revert "change to clientName"
This reverts commit 6d6654865a8d71f960e56ae41e5fa6afb22e0f58.
* compile
* add a swagger.tsp for swagger needed edits
* clientName
* use tsp gen events
* make namespace models
* update desc
* update
* update readme again
* .NET diff changes
* modelAsString true
* diff from .NET generated
* ordering
* ordering
* ordering
* order
* dont use unknown use record unknown
* make record,string/ tags
* timeToLive
* type of labelValue is unknown
* follow wire
---------
Co-authored-by: Rakshith Bhyravabhotla <rakshith.bhyravabhotla@gmail.com>
Add TypeSpec for Azure.Communication.Messages service (#27405)
* Add GA swagger
* add typespec
* generated swagger by TypeSpec
* add repeatability headers
* Update client.tsp
* try adding internal to the methods
* mark response public
* make clients internal for all languages
* mark more as public
* fix naming - StreamClient
* remove StreamClient, move into NotificationMessagesClient
* fix typo - application/octet-stream
* change body to content
* renaming
* some changes to model access
* change the access decorator to csharp only
* experiment with polymorphism
* Update client.tsp
* add @access(Access.public, "csharp"), fix WhatsAppMessageTemplateValueSubType
* Update models.tsp
* Update models.tsp
* add name as a field to MessageTemplateValue
* add @visibility("create")
* try @visibility("read", "query", "create", "update", "delete")
* try Array<MessageTemplateValue>
* change client
* make MessageTemplateResponse and WhatsAppMessageTemplateResponse internal
* Update CommunicationServicesMessages.json
* more discriminators
* Update models.tsp
* Update models.tsp
* Update models.tsp
* address comment for adding SupportsClientRequestId
"ServiceTraits should also includeSupportsClientRequestId because that header is mandatory for all Azure services and will get auto-populated by the SDK."
* fix tsp compile warnings
* generate csharp for test purposes
* remove csharp client tweaks
* fix client hierarchy
* add auth decoration
* avoid response and request in model names
* avoid single noun names
* revert string literal to enum to control naming in SDK
* change button to buttons
* make enums public and rename client methods
* change operation name from sendMessage to send
* remove outdated generated examples
* JS and Java SDK related typespec changes (#27416)
* updated js emitter output
* JS discriminator model issue fix
* JS generation fix
* reverting the discriminator changes
* java emitter changes
* added key credential auth
* address some PR comments (#27435)
* renaming
* make latitude and longitude requried
* rename MessageTemplateType to MessageTemplateBindingsType
* add suppression for unknown type
* extract an enum CommunicationMessagesChannel for MessageTemplateItem
* fix examples
* fix examples and generate swagger
---------
Co-authored-by: glorialimicrosoft <67171398+glorialimicrosoft@users.noreply.github.com>
* renaming
* use @projectedName("csharp", "uri") to rename url to uri for csharp and make downloadMedia internal for csharp
* fix example, fix typo
* fix XmsEnumValidation error on build pipeline
* regenerate swagger with TypeSpec
* fix example
* fix nextLink in example
* fix nextLink model validation
TypeSpec automatically generates nextLink as an Uri type, and in our service we use relative path for nextLink, so validation is failing, setting it to null to bypass this validation
* run npx tsv specification/communication/Communication.Messages
* run tsp compile
* try something
* merge main into feature branch then rerun npx tsv specification/communication/Communication.Messages
* make communicationservicesmessages all lower case
* run npx tsv specification/communication/Communication.Messages again
* Update tspconfig.yaml
* fix Swagger Avocado
* fix Swagger Avocado
* add suppressions for LroExtension
* remove customization-class setting in tspconfig.yaml that is causing the customization task to fail.
* Address comment: rename getTemplates in routes.tsp to listTemplates
* remove `?` from subType as it is required for WhatsAppMessageTemplateBindingsButton
* add more examples
* format namespace as Azure.Communication.MessagesService
* remove unnecessary @access(Access.public)
* rename Type to Kind
* add description for language in template
* Update communicationservicesmessages.json
* fix CI failure, rename download to get
* remove multiple-line docs from TypeSpec
* add maxpagesize for list template operation
* move @access out of models.tsp into client.tsp
* remove the unneeded maxpagesize in models, ListTemplatesQueryParams already takes care of it
* Fix some doc description
* rerun npx tsv specification/communication/Communication.Messages
* change channel id for ListTemplates to uuid
* Java Customization for Communication Message Typespec (#27919)
* Java Customization
---------
Co-authored-by: Dominik Messinger <domessin@microsoft.com>
Co-authored-by: Arif Ibrahim Mohamed <arifibrahim4@gmail.com>
Update workflow-bot comment.yml: update guidance for publishing to public repo; add support for new breaking changes labels
Update comment.yml: fix workflow-bot logic (#28006)
Todd king msft monitor microsoft.insights dp 2024 02 01 (#27560)
* Adds base for updating Microsoft.Insights from version stable/2023-10-01 to version 2024-02-01
* Updates readme
* Updates API version in new specs and examples
Update cSpell.json - add nwrfc stands for NetWeaver RFC of SAP (#27874)
* Update cSpell.json - add nwrfc stands for NetWeaver RFC of SAP
* Update cSpell.json with SAP terms
Updating docs related to Hermes IOPS/MBPS (#27971)
* updating docs
* spell check police
[Hub Generated] Review request for Microsoft.AzureStackHCI to add version stable/2024-01-01 (#26905)
* Adds base for updating Microsoft.AzureStackHCI from version stable/2023-08-01 to version 2024-01-01
* Updates readme
* Updates API version in new specs and examples
* pick up changes from https://github.com/Azure/azure-rest-api-specs-pr/pull/16097
* merge w 2023-11-01-preview
* fixed api version
* adding changes for cluster resources
* add examples
* add missing files in readme
* updated edgedevice to make deviceconfiguration as optional
* updating ProxyResource to v5
* Revert "updating ProxyResource to v5"
This reverts commit 7b849bd01bbb3da1d2d3dfb12be7db993e504d60.
* update common-types for security settings to v3
---------
Co-authored-by: Patricia Huang <pathuang@pathuang-dev>
Co-authored-by: Priyanshi Jain <priyjain@microsoft.com>
Co-authored-by: Bhuvnesh kumar <bhukumar@microsoft.com>
Co-authored-by: Priyanshi Jain <87351063+priyjain358@users.noreply.github.com>
Co-authored-by: Bhuvnesh Kumar <bhuvnesh.agrawal@gmail.com>
Dev sentinel securityinsights microsoft.security insights 2024 01 01 preview (#27728)
* Adds base for updating Microsoft.SecurityInsights from version preview/2023-12-01-preview to version 2024-01-01-preview
* Updates readme
* Updates API version in new specs and examples
* Enrichment API (#27706)
* Update DataConnectorDefinitions API. Removed unused properties (#27737)
* removed unused properties from definition api
* remove sampleQuery object
* Add new kind (RestApiPoller) to DataConnectors API (#27736)
* add new dataConnector kind
* fix Errors
* Added Recommendations API 2024-01-01-preview version (#27682)
* Added Microsoft.SecurityInsights Recommendations API 2024-01-01-preview
* prettier
* prettier
* cr
* Added back Azure-AsyncOperation header
* cr
* cr
* cr
* cr
---------
Co-authored-by: Itiel Maimon <itielmaimon@microsoft.com>
* Morazmiz/query 2024 01 01 preview add query (#27723)
* Add blockchain to latest profile
* Add additional types
* Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview
* Updates readme
* Updates API version in new specs and examples
* add Query API
* delete redundant file
* validations
* validations
* .
* .
* .
* .
* count
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* .
* suppress warnings
* fix model validation error
* make main a parameter
* .
* object
* .
* .
* .
* revert
* .
---------
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>
* remove suppress that does not work (#27974)
* Ms security insights recommendations api 2024 01 01 preview - arm review fixes (#27972)
* Added Microsoft.SecurityInsights Recommendations API 2024-01-01-preview
* prettier
* prettier
* cr
* Added back Azure-AsyncOperation header
* cr
* cr
* cr
* cr
* Updated Recommendation per ARM review
* RecommendationPatch
* fixes
* cr
* check
* try
* try3
* h
* typo
* try
* r
* rs
* s
* d
* try fix
* 6
* try
* ddd
* i
---------
Co-authored-by: Itiel Maimon <itielmaimon@microsoft.com>
---------
Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
Co-authored-by: Itiel Maimon <itiel.maimon@gmail.com>
Co-authored-by: Itiel Maimon <itielmaimon@microsoft.com>
Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
[Purview Datamap] Fix anonymous model (#28010)
* fix anon model
* swagger
* update mode naming
---------
Co-authored-by: Yifan Zhou <yifanzhou@microsoft.com>
Fixing prettier check
Fixed Model Validation
Resolved comments
Fixing case in examples
Resolved comments
fixing param
Fixing examples
Moving Orbital from 2024-03-01 preview to stable (#27924)
* Moving from 2024-03-01-preview to stable
* Updated version in swagger json
* Modified examples folder
* Updated readme files
* updated readme path
* no sdk gen in readme
* updated readme
* Old files
* referencing old preview
* Removed old preview folder
* Adding preview folder back, remove later in a separate PR
Added EventGridEvent schemas for a Microsoft.ApiCenter. (#27902)
* Added EventGridEvent schemas for a Microsoft.ApiCenter.
* Added reference in readme.md.
* Addressing comments.
* Addressing comments.
* Update specification/eventgrid/data-plane/Microsoft.ApiCenter/stable/2018-01-01/ApiCenter.json
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
* Addressing comments.
* Fixes.
* Added prefix to events.
* Added prefix.
* Fixes.
* Fixed styling.
---------
Co-authored-by: Alexander Zaslonov <alzaslon@microsoft.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
2024-02-29-preview (#28004)
[OpenAI.Inference] Implementing changes for the 2024-02-15-preview version. (#27558)
* Implementing changes for the 2024-02-15-preview version.
* Fixing examples api versions.
* Missing examples
* updating OYD samples
* fixes
* format
* fixe
* typo
* fixes
* reflect new structure of OYD response 'context' object
* reflect new structure of OYD response 'context' object (compile)
* reflect new chat completions logprobs
* Remove 'removed' for deprecated but continuing models/routes
* Update specification/cognitiveservices/OpenAI.Inference/client.tsp
Co-authored-by: Minh-Anh Phan <111523473+minhanh-phan@users.noreply.github.com>
* TTS docs pass, compile/format clean
* pending clarification, minimally update embedding input_type to at least be optional and clear
* test
* TTS naming change
* fixing enum casing.
* samples + missing field
* compile after merge
* fixing samples
* updating to match latest service provided swagger
* updating examples
* fix
* Adding projectedName back to fix emitted libraries.
* renaming deployment-id to deploymentId to match samples.
* fixing more tests.
* fixing handwritten swagger
* rollling back changes to handwritten spec + examples
* generated examples
* more roll backs
* more rollbacks
* test
* compiled
* fixing examples
* recompiled with updated compiler
* recompiled after merge
* updating example + fix name
* removed projectedName json
---------
Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>
Co-authored-by: Travis Wilson <travisw@microsoft.com>
Co-authored-by: Minh-Anh Phan <111523473+minhanh-phan@users.noreply.github.com>
Co-authored-by: Billy Hu <ninhu@microsoft.com>
Update privateEndpointConnection.json (#27980)
Update readme.md (#27993)
modifying readme tag
[Text Translation] Update tsp config file (#28002)
Co-authored-by: Michal Materna <mimat@microsoft.com>
Removed sentence from countryRegion property description. (#28000)
remove usage.input (#28057)
Introducing VoiceServices.Provisioning 2024-02-29-preview (#27968)
OpenAI assistants: The file ID is just a string, not an object. (#27743)
* Remove some unneeded changes.
* Incorrect route
* Fixing typespec validation errors.
---------
Co-authored-by: Richard Park <ripark@microsoft.com>
[TypeSpecRequirement] Add suppression mechanism (#28043)
- Fixes #27348
Update README.md (#27497)
* fix package-composite-v3 (sort and remove dup)
* remove duplicate package tag
Updated the Creator Conversion description property to reference data registry. (#28058)
* Updatd to use data registry.
* Updatd to use data registry.
Updated the Creator Dataset and Conversion services `description` property (to reference Data Registry) (#28060)
* Updatd to use data registry.
* Updatd to use data registry.
[DocumentIntelligence] Rename base64Source to bytesSource in Python (#28094)
Storage STG 93 (#27488)
* added 2024-05-04 swagger (#26851)
* changed readme version (#26867)
* Added NFS Snapshot Support (#26870)
* added nfs support to spec
* added nfs support to spec
* Revert "Added NFS Snapshot Support (#26870)" (#26876)
This reverts commit 46b2c9610415e6ae1f16bfd672210c4684abb078.
* added blob swagger (#26995)
* updated version in readme and swagger (#26996)
* [STG93] Add Rename Support to List Ranges (#26875)
* [STG93] Add NFS Snapshot Support (#26877)
* Fixed typo (#27410)
* Revert "Fixed typo (#27410)"
This reverts commit 61ded74b71c6f0f3886960d9bf5def71a6f2fe30.
* Revert "[STG93] Add NFS Snapshot Support (#26877)"
This reverts commit ba14955ad35a61dce84652190e662928746bd990.
* removed blob version (#28063)
---------
Co-authored-by: Tamer Sherif <69483382+tasherif-msft@users.noreply.github.com>
Create new api version 2023-04-01 for storage resource provider and added new Network Securiy Perimeter related APIs (#27804)
* Adds base for updating Microsoft.Storage from version stable/2023-01-01 to version 2023-04-01
* Updates readme
* Updates API version in new specs and examples
* Add Network Security Perimeter feature related APIs.
* Remove 200 response code for NSP reconcile api
* Fix errors detected by Swagger LintDiff
* Fix warnings in Network Security Perimeter swagger.
* Remove 200 response code from example of reconcile Network Security Perimeter Configuration API.
* Replace subscription token with a fake subscription id to pass Swagger ModelValidation
* Fix prettierCheck issues.
* Remove not allowed $ref siblings properties.
* Fix SDK azure-sdk-for-go failure by updating the title to AzureStorageManagement for all swagger json
* Update title to StorageManagementClient since it break JS SDK
* Add provisioningIssues property in example.
Rheajain paloaltonetworks palo alto networks.cloudngfw 2024 02 07 preview (#27913)
* Add base for updating PaloAltoNetworks.Cloudngfw from version preview/2024-01-19-review to version 2024-02-07-preview
* Updates readme
* Updates API version in new specs and examples
* Add SCM APIs in swagger
* Update examples
* Fix api version in example
* Changed model name ProductSerialNumberRequestStatus
* Make array dictionary
* Add status code 404 for examples
Add aoai 2024-03-01-preview api version; (#27954)
Co-authored-by: Yunsong Bai <yunba@microsoft.com>
Update the ARM PR review workflow diagram: `VersioningReviewRequired` label + better contrast (#28084)
* new diagram
* update asset link
Moved latest Storage swagger to stable (#28097)
* Moved latest Storage swagger to stable
* Fixing CI
Remove pricing tier link and update summary/desc fields got Creator v2. (#28089)
* Remove pricing tier link and update summary/desc fields.
* Update summary/desc fields.
* Update summary/desc fields.
* Ran Swagger PrettierCheck
* fixed spelling.
disable flatten for new services (#28039)
* disable-flatten
* Update quantum title
[resource] fix python config (#28119)
* python config
* update
1. Update Linux Ahub modelling in 2023-04-01-preview version (#27831)
* 1. Update Linux Ahub modelling in 2023-04-01-preview version
* 1. Updated swagger
* 1. Fixed model validation error
* 1. Renamed Tomcat to Java
---------
Co-authored-by: Kushal Mehrotra <kumehrot@microsoft.com>
20230401preview (#28021)
Update number lookup feature from GA to preview (#27799)
* move March release to preview instead of GA
* prettier fix
Updates to description field, impacting user docs. (#28134)
* Updates to description field, impacting user docs.
* Updates to description field, impacting user docs.
* Updates to description field, impacting user docs.
* npx prettier
Updating Templates value property projected name for CPM Python SDK (#28120)
* Updating Templates value property projected name for CPM Python SDK
* ci fix
[TypeSpec] Upgrade to 0.54.0 (#28127)
[TypeSpecRequirement] Remove fallback to suppressions.yml (#28131)
Grchris microsoft monitor microsoft.insights 2020 10 01 (#27439)
* Update location property description
Deprecating sapmonitor methods in HanaOnAzure api (#27837)
* Deprecating sapmonitor methods
* Adding location to long running operations
Update control_plane_template.md: simplify guidance around breaking changes (#28155)
* Update control_plane_template.md: simplify guidance around breaking changes
* Update control_plane_template.md
[Hub Generated] Review request for Microsoft.Insights to add version stable/2024-02-01 (#27559)
* Adds version 2024-02-01
* Add metricnamespaces to latest API vesion
Deprecating Create Sap HANA instance method (#27862)
* Deprecating put method
* Fixed example
* Fixing response
* Updating descriptions
Convert scripts to use "npm exec" instead of "npx" (#28163)
- Devs should use "npx" for brevity
- Scripts should use "npm exec --no --" for predictability and consistency
- Not expected to cause any behavioral changes, just fixing proactively
New resource provider Microsoft.EdgeZones first api-version 2024-04-01-preview for public preview. (#28138)
* Adding Microsoft.Edgezones public preview 2024-04-01-preview
New API version for Azure DataProtection 2024-02-01-preview (#27963)
* Adding Microsoft.DataProtection version 2024-02-01-preview
* added examples
* adding suppressions
[TypeSpec Scripts] Add base and target commit params (#28167)
- Plumb parameters from Get-ChangedFiles
- Enables validating between arbitrary commits
- Used by branch typespec-next
[TypeSpecValidation] Rename script to TypeSpec-Validation.ps1 (#28165)
- Aligns with other scripts in folder
[TypeSpecValidation] Remove displayName from "all" job (#28174)
- Improves GitHub check UI by shortening name
Add flavor to tspconfig.yaml (#28077)
* use flavor
* [TypeSpecValidation] Add rule FlavorAzure
* Move flavor into nested scope
* Rename "sdk emitters" to "client emitters"
* Add extra newline to separate failures
* [TypeSpecValidation] Improve scripts in package.json
* Sort dev deps
* Add unit tests for FlavorAzureRule
* Change regex from ".*" to ".+"
- Slightly more accurate since package should never be named "http-client-"
---------
Co-authored-by: Mike Harder <mharder@microsoft.com>
[edgezones] Migrate to versions enum (#28177)
- React to breaking changes in TypeSpec v0.54.0
[TypeSpecRequirement] Create separate jobs for data-plane and resource-manager (#28172)
- Creates separate GitHub checks, which can be made required or non-required independently
[TypeSpecValidation] Format tspconfig.yaml (#28164)
- Fixes #28082
- Also remove workaround to fail on stderr from "tsp format"
- Fixed in microsoft/typespec#2323
Convert HealthInsights enum to union (#27725)
* Convert HealthInsights enum to union
* Fix some spaces
* Was missing one enum
Init Data Plane AzureML/Azure-AI - Index Asset (#27265)
* init data plane assets Azure-AI
* small clean-ups
* ARM -> dataplane
* clean-ups, namespacing docs etc
* versioning and naming clean-up
* wip resource nesting
* update to include proper workspace nesting, doing both is WIP
* small clean-ups will get back to endpoint later...
* rewrite assets for generic asset integration
* update service routing
* write routes by hand sadly don't have support for registry + workspace controllers otherwise
* give up on ref
* remove the index config
* updated examples
* prettier
* update container
* label to orderBy
* update contracts post DevPlatV2 review
* updates post review
* simplified asset representation
* fix examples and latest changes except for async
* auto-gen for tsp compile is messed up, updating examples again
* bump
* system data update
* Dto for IndexVersion is Index
* update to only sync workspace
* update to sync workspace only
* clean-up workspaces ref alignment
* clean-up operation naming
* auto-gen
* fix inline error
* fix x-ms-identifier error
* update from IsArchived to Stage
* update examples
* add next Index Version
* can remove workspace and top-level index definition since I am no longer doing nesting hierarchy in routing with this approach
* update routing
* missing piece for auto-gen thanks Hanchi
* spell check
* update for auto generated code
* updated examples/json for Hanchi's changes
* differentiate name from control plane
* remove name/version -> Id
* remove extra header requirement
* align version with control plane
* update pattern to match MFE
* add tag filtering on version
---------
Co-authored-by: Kayla Ames <kaseager@microsoft.com>
Co-authored-by: Hanchi Wang <hancwang@microsoft.com>
Updates to description field, impacting user docs. (#28139)
[machinelearningservices] Add flavor:azure, format tspconfig.yaml (#28181)
Fixed readme.java.md for cosmosdb release exception (#28188)
Review request for microsoft.healthcare apis stable version 2024 03 31 (#27981)
* Adds base for updating Microsoft.HealthcareApis from version stable/2024-03-01 to version 2024-03-31
* Updates readme
* Updates API version in new specs and examples
* Update spec to include data partitions variable
* Fix duplicate tag
* Add default tag
* Fix prettier check
* Ran prettier
* Fix prettier
schemaregistry tsp (#25168)
* initial tsp
* generate openapi
* update register schema op
* update standard ops to foundations.operation
* add examples + re-gen
* update tsp
* update tspconfig package version
* remove generated swagger
* remove extra files/package.json
* remove \n from doc
* remove / from doc
* update credential scopes
* cats comments + update header names to apital
* update for 2023-07-01 version
* format tsp
* fix examples errors
* make models private w/ augment decorator
* add import for access decorator
* change private to internal
* try exclude for model, not internal
* internal -> Access.internal
* remove unnecessary openapi import
* remove configs
* add generate-package-files to tspconfig
* add models for Maddy/as per Cat
* add usage decorator
* change all public client model access to internal
* temp remove projectedName for ContentType
* add content type enum for .net
* update content type enum name + doc
* update projectedName for csharp content type
* make ops internal
* emit swagger from tsp
* fix errors
* fix examples
* rename/fix examples
* update old examples
* re-run pipelines
* remove extra examples
* Add typespec-java
* update content type for c# and address comments
* update tspconfig.yaml for ts
Co-authored-by: Minh-Anh Phan <111523473+minhanh-phan@users.noreply.github.com>
* add client decorator to avoid sub interface/client
* address cats comments
* address comments
* change namespace
* last few comments
* re-emit openapispec
* move client only models to client.tsp
* only update 2023-07-01 examples
* fix examples
* update list ops
* add 2021-10 samples
* fix validation errors
* address comments
* update tspconfig emitted dir
* remove emitted preview swagger
* fix tspconfig/enum
* remove all added decorators + don't generate old versions of swagger
* keep necessary examples
* fix examples
* remove content type enum + interface from client.tsp
* remove octet-stream content type from main
* re-emit swagger
* add older versions back + rename api version enum
* add older version examples
* add opID to older examples
* fix breaking changes
* emit older version swaggers
* fix examples
* add reason for c# ci check failure
* remove old swaggers
* re-emit swagger w/ updated compiler
* remove okresponse from schema model
* add https:// to endpoint
* remove net ci check fail comment in tsp config
* update js tspconfig
* update swaggers
* revert ts package name in tspconfig since not rlc
* update docs
* use spread operator for schema content
* test spell check case sensitive
* cr changes
* format
* rename content to schemaContent
* add TODO blocked comment
* add pattern to sr schemaName
* fix constraint changed breaking check
* rename sr directory back to eh and re-rename in other pr
* tspconfig
---------
Co-authored-by: Connie Yau <conniey@microsoft.com>
Co-authored-by: Minh-Anh Phan <111523473+minhanh-phan@users.noreply.github.com>
[schemaregistry] rename swagger folder (#28200)
* rename swagger folder
* add flavor to tspconfig
* newline
[schemaregistry] Add flavor:azure (#28202)
* [schemaregistry] Add flavor:azure
* Format tspconfig.yaml
Update summary & desc fields for the Azure Maps Creator preview docs. (#28135)
* Summary field
* Updates to description field, impacting user docs.
* Updates to description field, impacting user docs.
* Updates to description field, impacting user docs.
* Updates to description field, impacting user docs.
* Updates to description field, impacting user docs.
* Updates to description field, impacting user docs.
* Updates to description field, impacting user docs.
* Updates to description field, impacting user docs.
* updates
remove duplicate flavor (#28206)
Add AOAI 2024-02-01 GA API version; (#28196)
Co-authored-by: Yunsong Bai <yunba@microsoft.com>
Update readme.python.md (#28125)
* Update readme.python.md
* fix
* Update readme.python.md
---------
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
[Hub Generated] Review request for Microsoft.Security to add version preview/2023-12-01-preview (#26773)
* Update readme.md
Reverting global tag to stable GA version for SDK release
* Adds base for updating Microsoft.Security from version preview/2020-01-01-preview to version 2023-12-01-preview
* Updates readme
* Updates API version in new specs and examples
* Add 2023-12-01 version
* Remove files
* change in readme file
* fix version
* Check error
* back to boolean
* Fix examples
* some more fixes
* Fix version in automation examples
* .
* fix
* fix
* fixes
* .
* fixes
* more fixes
* more fixes
* .
* .
* .
* Resolve comments
* Add automation patch request + add empty patren name
* some fixes
* fix path example
* roll back tags changes
* try
* fix readme
* Add AutomationUpdateModel
* missing }
* fix
* fix
* fix
* fix
* indention fix
* Update readme after merge
---------
Co-authored-by: Jooneil Ahn <ahnjooneil12@gmail.com>
Co-authored-by: Nessya Hutzler <v-nhutzler@microsoft.com>
The version of API for Distributed Availability Groups in package-composite-v5 is updated to the newest one. This is needed in order to update CLI commands. (#28166)
Co-authored-by: jovancevic123 <jojovancevic@microsoft.com>
[translation] Remove empty section from readme.md to fix LintDiff (#28211)
Task 27145232 (#28233)
* TASK-27145232
* TASK-27145232
* TASK-27145232
Compose rest api specs for Azure Monitor LiveMetrics (#27430)
* Use typespec to define ApplicationInsights LiveMetrics Rest APIs
* Update cSpell.json
* Format typespec
* Correct transmissionTime type
* Fix x-ms-parameterized-host issue
* Fix example jsons
* Sync example jsons changes to openapi
* Remove client.tsp not in use
* Fix swagger model validation
* Fix swagger model validation
* Resolve comments
* Update namespace
* Minor updates
* Remove legacy error cases in example jsons
* Add missing readme.md
* Resolve new round of comments
* Fix up global endpoint
* Tweak some words
* Tweak some words
* Add omit-unreachable-types
* Add flavor to tspconfig.yaml
* Fix GitDiff
* Resolve another round of comments
---------
Co-authored-by: Benke Qu <bequ@microsoft.com>
Update TSP enum to union (#27687)
* Update TSP enum to union
* Fix last 3 knownValues
* Revert changes to ProvisioningState enums
* Double quote what is needed
* Another set of fixes
* More fixes again
* Move back discriminator to union
* Fixes about validation
* Revert a lroStatus union
* Final fixes
* Remove useless space
* Extra space
* Format
* Remove knownValues
* Regenerate OpenAPIv3 of OpenAI
* Format those files
* Migrate provisioningState as well
* Reformat
* Typo
* Remove extra space
* Reintroduce trailing whitespaces in LoadTestService
* Reintroduce trailing whitespaces in Purview
* Reintroduce trailing whitespaces in CodeSigning
* Reintroduce trailing whitespaces in TextTranslation
* More Purview spaces
* More Purview spaces again
* Restore OpenAPI files as main
secret regex validation and TargetCollectionStatus field bug fix (#27976)
Co-authored-by: Abigail Zahne <abigailzahne@microsoft.com>
Alec baird desktopvirtualization microsoft.desktop virtualization 2024 03 06 preview (#28157)
* Adds base for updating Microsoft.DesktopVirtualization from version preview/2024-01-16-preview to version 2024-03-06-preview
* Updates readme
* Updates API version in new specs and examples
* Added appAttach Swagger changes to public preview
* Added MultiPD swagger changes
* Added examples and camelcased AppAttach Properties
* Added pattern name restriction exception as defined until next stable
* captialized APPV to pass spell check
* Another APP-V spelling to try and pass spellcheck
update typescript.md for notificationhubs (#28215)
switch @projectedName to @clientName (#27797)
Origin/neeleshk cdn profilelogscrubbing (#26604)
* AFDx Profile Log scrubbing 2024-02-01 Version
* readme add version
* updated the version in readme.json
* update the version and correct the id in example
* updated the version
* Commit the base version to take care the CI-MissingBaseCommit label
* PR for adding a new version on top of base version
* incorparet the comments
* Updated some descriptions
waf features 2024-02-01 (#26633)
* waf features 2024-02-01
* added the groupby feature
* added the new policy setting javascriptChallengeExpirationInMinutes
* updated the description.
* updated the min max and default value for javascriptChallengeExpirationInMinutes property.
* Fixing Lintdiff issues
* Commit the base version to take care the CI-MissingBaseCommit label
* PR for adding a new version on top of base version
* updated teh description.
* Change a variable name from groupByDimension to variable.
* Change the property name from variable to variableName
AppConfiguration 2023-09-01-preview API version (#27859)
* Adds base for updating Microsoft.AppConfiguration from version preview/2023-08-01-preview to version 2023-09-01-preview
* Updates readme
* Updates API version in new specs and examples
* 2023-09-01-preview API changes
* update API version in example
[ACS JobRouter] Add max concurrent offers to workers (#27288)
* fix semantic validations
* add new api-version for maxConcurrentOffers added to RouterWorker
* fix lint errors
* update tspconfig for beta version for python sdk
* update minor docstring
* run validation rules
* minor update in client.tsp
updating readme default version (#28178)
Added 'Time is in UTC.' to departure and arrival times. (#28251)
BUG 7527990 (#28229)
* BUG 7527990
* BUG 7527990
* BUG-7527990
* BUG-7527990
* Added new properties.
* added neighbourhood property to the address object and changed 'countrySubdivision' to because that is what the code returns.
* Added 'Neighbourhood' property to the Address object. This appears to have been added recently in TomTom (https://developer.tomtom.com/reverse-geocoding-api/documentation/product-information/release-notes).
* countrySubdivision vs countrySubdivisionCode.
* countrySubdivision and countrySubdivisionCode
Codesigning RP: adding first 2024-02-05 public preview version (#27888)
* Added files for public preview
* Updated readme java file
* Updating the python readme as per comments
* Fixed TypeSpec validation
* updated as per the TS validation with readonly for nextLink
---------
Co-authored-by: Amrita Shanbhag <amritas>
Add new stable version 2023-12-30 based on 2023-12-01-preview for MICROSOFT.DBFORMYSQL (#28187)
* base commit copy base folder
* update api version
* update readme
Update error response version for aca (#28244)
* fix
* fix
Update data_plane_template.md (#28231)
Update ci-fix.md (#28230)
[confidentialledger] Add default tag to readme.md (#28263)
NotificationHubs 2023-10-01-preview Bugfix (#28030)
* Bugfix - x-ms-client-flatten
* nit: edit lowercase
* Revert "nit: edit lowercase"
This reverts commit 1bce04c4c0fa50b5993ab4e8d095476cfc904db5.
BUG-27177220 (#28269)
* BUG-27177220
* updated indenting
[AKS][Fleet] 2024-02-02-preview API (#27886)
* fleet api 2024-02-02-preview
* md files
* examples
* use union instead of enum (#27900)
* update with latest compiler (#28267)
---------
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Review request for Microsoft.DBforPostgreSQL to add version preview/2023-12-01-preview (#27947)
* Adds base for updating Microsoft.DBforPostgreSQL from version preview/2023-06-01-preview to version 2023-12-01-preview
* Updates readme
* Updates API version in new specs and examples
* Update readme file to point to the latest tag for flexible servers
* remove delete migraiton and update source type
* include migrationInstanceResourceId in examples
* add support for migration roles
* fix migratin instance resource id property
* add missing example reference
* include suppressions
* remove "migrationInstanceResourceId" from example request
* add delete back to migrations
* correct migrationInstanceResourceId in response
* PR review fixes
* add example reference for Migrations_Create_With_PrivateEndpoint_Servers
---------
Co-authored-by: ambrahma <61298407+ambrahma@users.noreply.github.com>
Adding new stable version "2024-03-01" (#28106)
* Base API commit
* Changing version to new 2024-03-01 version
* Update monitor patch call responses, billingCycle type and the related examples
* Update readme.md
* Fix minor errors
* Fix operationId typo for monitoredSubscriptions put method
Spot Placement Recommender API swagger docs (#27899)
* Adding 2024-02-01-preview files, initial commit
* Fix response bodies for RunDiskInspection and SpotPlacementRecommender
* Removing commented summary property
* Update API version to 2024-03-01-preview
* Addressing comments from PR review
* Add new diagnostics.json file to README.md
* Adding definitions and descriptions
* Adding description
* Adding ComputeDiagnosticsOperationResult and changing references
* Change qualified name to qualified ID
* Adding description for storageaccountId
* Clean up description message
* Update references to CDRP specific definitions
* Addressing more Lint failures
* Addressing 202 location lint comment, api-version parameter comment
* Fix ResourceSize ref
* Add Microsoft.Compute/DiagnosticRP/preview/2024-03-01-preview/diagnostic.json to readme.md
* Fix readme.md remove unnecessary Microsoft.Compute/DiagnosticRP/preview/2024-03-01-preview/diagnostic.json
* Addressing LintDiff validation checks
* Fixing some example jsons
* Adding SpotPlacementRecommender Json example
* Fixing example responses
* Lint fixes
* Change {subscription-id} to 00000000-00000-0000-0000-000000000000
* Change subscription id to 00000000-0000-0000-0000-000000000000
* Address ModelValidation checks
* Change resultStatus type from string to integer
* Adding 202 schema for DiskInspection_Create
* Lower casing for RunDiskInspection 202 example response properties
* Change message type from integer to string
* Change resultStatus type from string to integer
* Set ModelAsString to false for enum and add integer format
* Remove 202 schema and body from example RunDiskInspection
* Remove x-ms-pageable property from Get DiskInspection Operation
* Change resultStatus type to string, modelAsString: false
* Change resultStatus example to Success
* Adding GetSpotPlacementRecommender operation and SpotPlacementRecommender metadata in GetDiagnostics operation example
* Prettier checks
* Change Metadata to List, change GetDiagnostics to ListDiagnostics
* Add examples for storageAccountId example, update sku description to CRP VM SKU size
* Add examples for storageAccountId example, update sku description to CRP VM SKU size
* Remove responseFields: null; nextLink: null from examples
* Reference ProxyResource using allOf property in ComputeDiagnosticBase
* Revert previous change to reference ProxyResource
* Updating example for ComputeDiagnosticBase - changing ID and Name properties to match ARM requirements
* Update ComputeDiagnosticBase to use ProxyResource
* Add package-2024-03-01-preview tag and update readme.md tag to package-2024-03-01-preview
* Revert readme.md tag to package-2023-07-03
* Adding OperationsAPIImplementation suppression to diagnostic.json
* Update Lint suppression checks for diagnostic.json
* Update Lint suppression checks for diagnostic.json change where to from
* Add suppressions to global yaml list
* Update suppression reason for OperationsAPIImplementation
Azure VMware Solution 2023-09-01 in TypeSpec (#28023)
* copy 2023-03-01
* update readme
* add TypeSpec
* TypeSpec examples
* tsp compile
* these examples were renamed
* set default tag to new API version
* Properties of a PATCH request body must not have default value, property:internet.
* remove Maintenances (#28028)
* new audience parameter must be optional
* remove custom rename from 2023-09-01 API (#28105)
* remove ProvisionedNetwork ProxyResource (#28108)
* remove AvailabilityZones from 2023-09-01 API (#28111)
* "quota", not "quote"
* "quota" fix in swagger
* remove "workloadNetworkName": "default" from example
* TypeSpec compiler v0.54.0
* suppress namedOutputs again
* suppress 200s in deletes
* suppress missing-x-ms-identifiers
* format tspconfig.yaml
* suppress false positives (#28220)
* use common LocationParameter (#28221)
* remove LintDiff suppressions in readme (#28222)
* add minimal suppressions back (#28234)
* do not specify x-ms-long-running-operation-options for VirtualMachines_RestrictMovement
* specify paths for suppressions (#28281)
Exposing undocumented "IsTemporaryTicket" property for addressing S360 issues (#28240)
* Changes for exposing undocumented "IsTemporary" property
* Changes to update isTemporaryTicket property as enum as suggested by ARM team
---------
Co-authored-by: Vijaya Munukutla <vimunuku@microsoft.com>
Exposing undocumented "IsTemporaryTicket" property for addressing S360 issues (#28237)
* Changes for exposing undocumented "IsTemporary" property
* Changes to update isTemporaryTicket property as enum as suggested by ARM team
---------
Co-authored-by: Vijaya Munukutla <vimunuku@microsoft.com>
Review request for Microsoft.RecoveryServices to add version stable/2024-01-01 (#27261)
* Adds base for updating Microsoft.RecoveryServices from version stable/2023-06-01 to version 2024-01-01
* Updates readme
* Updates API version in new specs and examples
* Swagger changes for PMS
* Swagger changes for Linux AHB
* Swagger changes for V2A RCM stack parity
* Swagger changes for supporting CVM for H2A and V2A-RCM
* Swagger changes for user selected OS Name
* Swagger changes for PV2/ZRS/Ultra disk type for CBT/H2A/V2A-RCM
* Swagger changes for AddDisk
* Added missed changes
* Spell check and some Lintdiff fix
* Fixed sectorSizeInBytes
* Adding InMageRcmUnProtectedDiskDetails property and removed GRS disk type
* Update service.json: Modified customScriptInputs to postMigrationSteps and scriptParameter to scriptParameters
* Defining diskaccounttype in common place and referring it at other places
* Added changes added in 2023-08-01 API version here
* Fixed swagger model vliadation error in 1 file in examples folder
* Adding x ms identifier to InMageRcmUnprotectedDiskDetails
* Added x-ms-identifier tag to property and removed from object
* Removed Standard_ZRS from diskaccountype as it's not applicable
* Added fix for missed property which was causing breaking change test to fail
* Fixed comments given by ARM-reviewer for linux AHB, CVM and DiskType
* Fixing x-ms-identifier comment
* To avoid conflict on additionalproperties attribute, remodeled resource tags to list of objects
* Added max length for tags
---------
Co-authored-by: Prachetos Sadhukhan <Prachetos.Sadhukhan@microsoft.com>
Co-authored-by: Prachetos Sadhukhan <prsadhu@microsoft.com>
Add new stable version for serviceOperations for Microsoft.DBForMySQL (#28273)
* base commit copy base folder
* update api version
Update readme.python.md (#28275)
update nginx examples (#27220)
* update nginx examples
* update
---------
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
hdinsight: onboard new apiversion 2024-05-01 (#28161)
* Adds base for updating Microsoft.HDInsight/HDInsightOnAks from version preview/2023-11-01-preview to version 2024-05-01
* Updates readme
* Updates API version in new specs and examples
* add new features
* add new features
---------
Co-authored-by: Wei Dong <weidong@microsoft.com>
Update Examples with non valid Credentials (#28270)
* invalid app credentials
* invalidate client secret
Dev sentinel securityinsights microsoft.security insights 2024 03 01 (#28029)
* Adds base for updating Microsoft.SecurityInsights from version stable/2023-11-01 to version 2024-03-01
* Updates readme
* Updates API version in new specs and examples
* Update Incidents.json and AutomationRules.json (#28037)
* Update automationRules swagger
* update automation examples
* update incidents swagger
* update incident examples
* fix incidents.json
* prettier
* update examples for oav
* fix lint error
* fix reviewer comments
* Fix review comments
---------
Co-authored-by: ityankel <47292630+ityankel@users.noreply.github.com>
[Microsoft.DeviceRegistry] Moved to single TypeSpec project (#28198)
* Moved to single TypeSpec project
* Regenerated spec with latest TypeSpec compiler version
* Added doc
Swagger changes for adding SPN, UAMI and SAMI credentials (#28122)
Co-authored-by: Saurabh Chugh <saurabhchugh@microsoft.com>
Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>
ResourceTypeName rename from AzureExtendedZones to ExtendedZones (#28290)
* ResourceTypeName correction. Changeing AzureExtendedeZones to ExtendedZones. A resourceTypeName with the word "Azure" is causing problems with SDK generation and Powershell module generation. Resource naming guidelines says not to use branded names.
* Updating typespec and swagger with more detailed doc descriptions.
* Updating main.tsp
* Updating main.tsp and edgezones.json
Add directive to fix the store folder of Ambr/PlmnId/Snssai (#28309)
* Add directive to fix the store folder of Ambr/PlmnId/Snssai/PlmnId
* Fixed comment for PR#28309
fix headers schema issue (#28210)
[Microsoft.DevCenter] Dataplane moving to TypeSpec (#26359)
* initial tsp conversion
* move main and tspconfig
* add client.tsp
* fix shared models
* prep for versioning
* define clients in client.tsp
* add auth
* fix conflicts
* add files for autorest emitter
* add resources and standard ops
* add versioning
* add versioned swaggers
* update generated swaggers
* reorganize code
* add ts to tspconfig.yaml
* update config
* update routes for accuracy
* more route fixes
* remove preview refs
* remove preview version
* remove extra op
* make models more accurate
* fix client.tsp
* add python to tspconfig.yaml
* fix lros
* create dev box fix
* add final operation for createdevbox
* update tspconfig.yaml
* Update EnvironmentsClient to DeploymentEnvironmentsClient
* Update client order
* Update userId doc
* Update from GetEnvironmentByUser to GetEnvironment
* Change CreateOrReplaceEnvironment to CreateOrUpdateEnvironment
* Update ListEnvironments
* Remove ByProject
* Add Operation Status
* Rename Dev Boxes Client methods
* Add @pollingOperation for LRO
* change order
* optinal properties for filter and maxCount
* Update GetSchedules parameter order and make then nullable
* Make hibernate nullable
* Add and update list devboxes operations
* fix conflict. move get all devboxes from devcenter to devbox client
* make list all dev boxes filter and top nullable
* DevCenter client nullablle filter
* rename namespace
* add client.python.tsp
* update tspconfig.yaml
* Rename python client tsp
* Add client parameter description
* update put lros
* switch to foundations error response
* remove custom error defs
* remove default value from description
* Add java option
* update endpoint to devCenterEndpoint
* more ranaming based on meeting review
* Make top optional for environments and switching parameter order
* update client prop to delayuntil and request to until to match api request
* try @query("until")
* Revert "update endpoint to devCenterEndpoint"
This reverts commit b8e3abf9f2365c5d2127c39f536f7b476e2d2742.
* Move all operation to one client
* Update js t…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the 2023-09-01 API version and moves our spec to TypeSpec. It was ARM approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/11977 and then ARM approved and breaking change approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/15631. Future API versions will be easier to author and review. The changes in this API version include:
IscsiPathProxyResourcewithlist,get,createOrUpdate, anddeleteoperationselasticSanVolume?onDatastorePropertiesnsxtManagerIp?,vcenterIp?, andhcxCloudMangerIp?onEndpointsaudience?onScriptCmdletPropertiesARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.