Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues Resource added to version 2018-01-01 #2806

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Issues Resource added to version 2018-01-01 #2806

merged 2 commits into from
Apr 12, 2018

Conversation

promoisha
Copy link
Contributor

@promoisha promoisha commented Apr 3, 2018 •
edited by azuresdkci
Loading

Same as #2576, but for the 2018-01-01 version.
Please, review but do not merge for now. Thanks!

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Apr 3, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@azuresdkci azuresdkci requested a review from jianghaolu April 3, 2018 23:03
@AutorestCI AutorestCI mentioned this pull request Apr 3, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 3, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2135

@AutorestCI AutorestCI mentioned this pull request Apr 3, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 3, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1577

@AutorestCI AutorestCI mentioned this pull request Apr 3, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 3, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2651

@jianghaolu jianghaolu added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 6, 2018
@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 9, 2018
jianghaolu
jianghaolu suggested changes Apr 10, 2018
View reviewed changes
...tion/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2018-01-01/apimapis.json
"in": "query",
"required": false,
"type": "string",
"description": "| Field | Supported operators | Supported functions |\n|-------------|------------------------|-----------------------------------|\n| id | ge, le, eq, ne, gt, lt | substringof, startswith, endswith |\n| state | eq | |\n| userId | ge, le, eq, ne, gt, lt | substringof, startswith, endswith |"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the description to be more like the docs in the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be shown as a table on the HTML doc page. Like here: https://docs.microsoft.com/en-us/rest/api/apimanagement/apidiagnostic/listbyservice#uri-parameters ($filter parameter). Or did I miss the point?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried this will look bad in generated SDKs. But I just confirmed with AutoRest owners this will be handled correctly. So I'm signing off.

...tion/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2018-01-01/apimapis.json
"in": "query",
"required": false,
"type": "string",
"description": "| Field | Supported operators | Supported functions |\n|-------------|------------------------|-----------------------------------|\n| id | ge, le, eq, ne, gt, lt | substringof, startswith, endswith |\n| userId | ge, le, eq, ne, gt, lt | substringof, startswith, endswith |"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@promoisha
Copy link
Contributor Author

@jianghaolu I just pushed an update to this PR (not regarding requested fixes). May I ask you to review these changes as well? Thanks!

@jianghaolu jianghaolu merged commit 948a591 into Azure:master Apr 12, 2018
@AutorestCI AutorestCI mentioned this pull request Apr 12, 2018
Merged
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@solankisamir solankisamir mentioned this pull request Apr 19, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu jianghaolu approved these changes

Assignees

@jianghaolu jianghaolu

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@promoisha @AutorestCI @ravbhatnagar @azuresdkciprbot @jianghaolu