Add Enclave Type and Customization Data Params #28195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Mar 11, 2024
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
sidmore
changed the title
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
….com/sidmore/azure-rest-api-specs into add_enclave_type_confidential_ledger
AzureRestAPISpecReview
added
the
ReadyForApiTest
….com/sidmore/azure-rest-api-specs into add_enclave_type_confidential_ledger
andpiccione
reviewed
Mar 19, 2024
...ger/resource-manager/Microsoft.ConfidentialLedger/preview/2024-03-11-preview/managedccf.json
Outdated
Show resolved
Hide resolved
...ger/resource-manager/Microsoft.ConfidentialLedger/preview/2024-03-11-preview/managedccf.json
Show resolved
Hide resolved
|
The required check Breaking Change(Cross-Version) is failing due to changes that are not related to this new API version (see details). This new preview API version has been based off the latest preview version (2023-06-28-preview; see corresponding #24632) and modifies the REST API specs for Managed CCF (managedccf.json) and Confidential Ledger (confidentialledger.json). Given that the #24632 also had the same detected breaking changes and was eventually approved, I've added the BreakingChange-Approved-Previously label. |
sidmore
added
the
BreakingChange-Approved-Previously
|
The SDK azure-sdk-for-net-track2 check is failing with a bunch of errors like XXX does not exist in the implementation but it does exist in the contract. However, the failure is not related to these updates. I assume this can also be ignored and relates to the #28195 (comment). |
microsoft-github-policy-service
bot
added
no-recent-activity
microsoft-github-policy-service
bot
added
no-recent-activity
microsoft-github-policy-service
bot
added
no-recent-activity
|
Hi, @sidmore. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
microsoft-github-policy-service
bot
added
the
no-recent-activity
sidmore
removed
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.