Azure SignalR - Adding new api-version 2024-01-01-preview #28259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=419262&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-js - @azure/arm-signalr - 6.0.0-beta.3+ Interface CustomCertificate no longer has parameter systemData + Interface CustomDomain no longer has parameter systemData + Interface PrivateEndpointConnection no longer has parameter systemData + Interface SharedPrivateLinkResource no longer has parameter systemData + Interface SignalRResource no longer has parameter systemData + Parameter location of interface TrackedResource is now required
❌azure-sdk-for-js - @azure/arm-webpubsub - 2.0.0-beta.3+ Interface CustomCertificate no longer has parameter systemData + Interface CustomDomain no longer has parameter systemData + Interface PrivateEndpointConnection no longer has parameter systemData + Interface SharedPrivateLinkResource no longer has parameter systemData + Interface WebPubSubHub no longer has parameter systemData + Interface WebPubSubResource no longer has parameter systemData + Parameter location of interface TrackedResource is now required
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from c3985feb70215da9f7fcac44b2a2b6bb5b8d0171. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.SignalR [View full logs] [Preview SDK Changes]info [Changelog]
️✔️Azure.ResourceManager.WebPubSub [View full logs] [Preview SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from c3985feb70215da9f7fcac44b2a2b6bb5b8d0171. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@10.5.0` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-signalr [View full logs] [Preview SDK Changes]️✔️track2_azure-mgmt-webpubsub [View full logs] [Preview SDK Changes]
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from c3985feb70215da9f7fcac44b2a2b6bb5b8d0171. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] ent cmderr [init.sh] Dload Upload Total Spent Left Speed cmderr [init.sh] 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0- 1110k cmderr [init.sh] npm notice cmderr [init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0 cmderr [init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0> cmderr [init.sh] npm notice Run `npm install -g npm@10.5.0` to update! cmderr [init.sh] npm notice cmderr [init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz... cmderr [init.sh] Computing checksum with sha256sum cmderr [init.sh] Checksums matched! command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-signalr [View full logs] [Preview SDK Changes]️✔️azure-resourcemanager-webpubsub [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from c3985feb70215da9f7fcac44b2a2b6bb5b8d0171. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-signalr [View full logs] [Preview SDK Changes]️✔️@azure/arm-webpubsub [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from c3985feb70215da9f7fcac44b2a2b6bb5b8d0171. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/signalr/armsignalr [View full logs] [Preview SDK Changes]️✔️sdk/resourcemanager/webpubsub/armwebpubsub [View full logs] [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from c3985feb70215da9f7fcac44b2a2b6bb5b8d0171. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0> cmderr [initScript.sh] npm notice Run `npm install -g npm@10.5.0` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️signalr [View full logs] [Preview Schema Changes]️✔️webpubsub [View full logs] [Preview Schema Changes]
️⚠️ azure-powershell warning [Detail]
⚠️Warning [Logs] Generate from c3985feb70215da9f7fcac44b2a2b6bb5b8d0171. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
⚠️Az.signalr.DefaultTag [View full logs] [Preview SDK Changes]⚠️Az.webpubsub.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
|
This was referenced Mar 14, 2024
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
This was referenced Mar 14, 2024
AzureRestAPISpecReview
added
the
ReadyForApiTest
|
The breaking change compares to the previous stable version has been approved in this PR. It is actually a false alarm when we switched to |
|
Breaking changes previously reviewed and approved in #22948 |
mikekistler
added
the
BreakingChange-Approved-Previously
bjqian
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Looks not reviewed by ARM API reviewer. Thus remove the |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
ms-zhenhua
reviewed
Mar 20, 2024
...on/signalr/resource-manager/Microsoft.SignalRService/preview/2024-01-01-preview/signalr.json
Show resolved
Hide resolved
...ebpubsub/resource-manager/Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json
Show resolved
Hide resolved
ms-zhenhua
added
ARMChangesRequested
bjqian
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
ms-zhenhua
reviewed
Mar 21, 2024
...ebpubsub/resource-manager/Microsoft.SignalRService/preview/2024-01-01-preview/webpubsub.json
Show resolved
Hide resolved
ms-zhenhua
added
ARMChangesRequested
bjqian
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
ms-zhenhua
added
ARMSignedOff
|
/pr RequestMerge |
ms-henglu
approved these changes
Mar 25, 2024
vxfield
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Copy api version 2024-01-01-preview from 2023-08-01-preview for azure signarl and webpubsub * Update to 2024-01-01-preview * Make provisioning state readonly * Trivial change : adjust readonly position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.