Add version 2018-02-01 Microsoft.ServiceFabric specification

[juhacket]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#1960

[AutorestCI]

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2713

[AutorestCI]

Automation for azure-libraries-for-java

A PR has been created for you:
AutorestCI/azure-libraries-for-java#66

[AutorestCI]

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1609

[marstr]

Howdy @juhacket,

To get started, could you confirm that this new API Version (2018-02) will be based on the 2017-07 API Version? That will help me and @ravbhatnagar scope our review to just things that have changed since the previous version.

Also, I see that you're adding a number of suppressions. If you've already gotten approval from the ARM team, then we don't need to go any further. If you do not yet have approval for them, we can get that ball rolling too.

[juhacket]

@marstr - Yes, the new API version is based on 2017-07-01-preview. We have split up the specification as only the cluster resource has changed in this new version.

We have discussed the suppressions with @ravbhatnagar and he has approved them. The main issue is how the validation tooling handles proxy resources.

[juhacket]

@marstr - Hold this PR, we have one more small change to make.

[juhacket]

@marstr - All changes have been made and are ready for review. Please notify before merge as we have to coordinate on our end.

[marstr]

@AutorestCI rebuild go

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/servicefabric/resource-manager/readme.md
Before the PR: Warning(s): 100 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/servicefabric/resource-manager/readme.md
Before the PR: Warning(s): 100 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[marstr]

Sorry for the delay on the review, it's taking me a little extra time because of the refactor. I should have a review in by EOD tomorrow.

[juhacket]

@marstr No problem. The plan is to finalize the review and be ready to merge on Friday.

[marstr]

In general this PR looks pretty much textbook, and that is much appreciated!

I did want to point out for the sake of awareness, that referencing these common definitions will result in the clients calling the service with both API Versions, as seen here in the Go SDK:
https://github.com/Azure/azure-sdk-for-go/pull/1609/files#diff-97eaea7067d7811544da444ef9a815e8R351

If you're okay with that, feel free to acknowledge and I will approve this PR.

[juhacket]

@marstr The intent is for users to call the application resources with the 2017 version and the cluster resource with the 2018 version. Is this what you mean?

[marstr]

Yep, that's what I mean. Thanks for confirming!

[ravbhatnagar]

This has been reviewed in person. Signing off!

[marstr]

I'll plan on merging this Friday, is that correct @juhacket?

[juhacket]

@marstr Please delay the merge. We have some dependencies that are not in place yet.

[marstr]

Given the title change, I assume your dependencies are still not in place. I will wait for you, @juhacket, to ping this thread or send me an email before I merge.

[juhacket]

@marstr The service has been updated and we are ready for the merge.