-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NSP API to multiple services under Microsoft.Insights RP #28680
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
c47b0a8
Add API and examples for NSP in ScheduledQueryRules
ff4639a
Add API and examples for NSP in DataCollectionEndpoints
df55908
Minor fixes for the api specs for ScheduledQueryRules and DCE
fd5ed18
Add NSP API for Action Groups
6cb1e10
Add new API to README.md
7bdb5ea
Merge branch 'main' into akshitgoyal/add-nsp-api
akshitgoyal 4fbe858
Fix examples to include right param names
bb7a44d
Merge branch 'akshitgoyal/add-nsp-api' of https://github.com/Azure/az…
539a7da
Fix styling errors
c429f4c
Include old version in default package tag
7b5ee1a
Fix Swagger LintDiff validation issues
7c6ef92
Resolve resource name pattern restriction for configName in NSP
8504ff2
Fix typo in param name
efc9dc6
Fix LintDiff warnings and errors
c817946
Update spec title
93172d2
Update README with the correct package ver
44f9cc8
Rever back to original NSP swagger model
67ead15
Update README
d229b69
Replace 200 with 202 for reconcile
f2254cd
Update reconcile examples with 202 response
469f8d6
Fix 202 response headers for reconcile
4e23f9d
Update error object ref for LintDiff validation
af4df59
Fix LintDiff Warnings: Update swagger to use v5 types
308c9a9
Fix LintDiff warnings
276d74b
Fix LintDiff warnings
830def1
Fix Prettier check
c88e025
Resolve comments and update Data models
e5f35a9
Resolve merge conflicts for README
d80972c
Fix README
4044433
Merge branch 'main' into akshitgoyal/add-nsp-api
akshitgoyal faafd85
Create sdk-suppressions.yaml
kazrael2119 fa3bc13
Refactor NSP definitions into a common file
10e66b0
Merge branch 'akshitgoyal/add-nsp-api' of https://github.com/Azure/az…
2226536
Resolve merge conflicts, merge main into feature branch
8e751a3
Resolve merge conflicts
40bbcfe
Refactor code to use NSP Common types
abde781
Merge branch 'main' into akshitgoyal/add-nsp-api
akshitgoyal 254e5c2
update API paths with nsp param name
6bea9e7
Merge branch 'akshitgoyal/add-nsp-api' of https://github.com/Azure/az…
e7d7ae6
Fix param declaration in paths and add parameter definition
607d0bb
Change str to int accross all API examples for accessRule ver property
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
205 changes: 205 additions & 0 deletions
205
...nager/Microsoft.Insights/stable/2021-10-01/actionGroups_NetworkSecurityPerimeter_API.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,205 @@ | ||
{ | ||
"swagger": "2.0", | ||
"info": { | ||
"title": "Azure Action Groups Network Security Perimeter APIs", | ||
"x-ms-code-generation-settings": { | ||
"name": "MonitorManagementClient" | ||
}, | ||
"version": "2021-10-01" | ||
}, | ||
"host": "management.azure.com", | ||
"schemes": [ | ||
"https" | ||
], | ||
"consumes": [ | ||
"application/json" | ||
], | ||
"produces": [ | ||
"application/json" | ||
], | ||
"security": [ | ||
{ | ||
"azure_auth": [ | ||
"user_impersonation" | ||
] | ||
} | ||
], | ||
"securityDefinitions": { | ||
"azure_auth": { | ||
"type": "oauth2", | ||
"authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", | ||
"flow": "implicit", | ||
"description": "Azure Active Directory OAuth2 Flow", | ||
"scopes": { | ||
"user_impersonation": "impersonate your user account" | ||
} | ||
} | ||
}, | ||
"paths": { | ||
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/actionGroups/{actionGroupName}/networkSecurityPerimeterConfigurations": { | ||
"get": { | ||
"tags": [ | ||
"NetworkSecurityPerimeterConfigurations" | ||
], | ||
"description": "Gets a list of NSP configurations for specified action group.", | ||
"operationId": "ActionGroups_ListNSP", | ||
"x-ms-examples": { | ||
"Get an action group": { | ||
"$ref": "./examples/NSPForActionGroups_List.json" | ||
} | ||
}, | ||
"x-ms-pageable": { | ||
"nextLinkName": "nextLink" | ||
}, | ||
"parameters": [ | ||
{ | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ResourceGroupNameParameter" | ||
}, | ||
{ | ||
"$ref": "#/parameters/ActionGroupNameParameter" | ||
}, | ||
{ | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/SubscriptionIdParameter" | ||
}, | ||
{ | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter" | ||
} | ||
], | ||
"responses": { | ||
"200": { | ||
"description": "Successfully retrieved the list of configs.", | ||
"schema": { | ||
"$ref": "../../../../../common-types/resource-management/v5/networksecurityperimeter.json#/definitions/NetworkSecurityPerimeterConfigurationListResult" | ||
} | ||
}, | ||
"default": { | ||
"description": "Error response describing why the operation failed.", | ||
"schema": { | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse" | ||
} | ||
} | ||
} | ||
} | ||
}, | ||
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/actionGroups/{actionGroupName}/networkSecurityPerimeterConfigurations/{networkSecurityPerimeterConfigurationName}": { | ||
"get": { | ||
"tags": [ | ||
"NetworkSecurityPerimeterConfigurations" | ||
], | ||
"description": "Gets a specified NSP configuration for specified action group.", | ||
"operationId": "ActionGroups_GetNSP", | ||
"x-ms-examples": { | ||
"Get NSP config by name for an action group": { | ||
"$ref": "./examples/NSPForActionGroups_Get.json" | ||
} | ||
}, | ||
"parameters": [ | ||
{ | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/SubscriptionIdParameter" | ||
}, | ||
{ | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ResourceGroupNameParameter" | ||
}, | ||
{ | ||
"$ref": "#/parameters/ActionGroupNameParameter" | ||
}, | ||
{ | ||
"$ref": "#/parameters/NetworkSecurityPerimeterConfigurationNameParameter" | ||
}, | ||
{ | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter" | ||
} | ||
], | ||
"responses": { | ||
"200": { | ||
"description": "Successfully retrieved the NSP config.", | ||
"schema": { | ||
"$ref": "../../../../../common-types/resource-management/v5/networksecurityperimeter.json#/definitions/NetworkSecurityPerimeterConfiguration" | ||
} | ||
}, | ||
"default": { | ||
"description": "Error response describing why the operation failed.", | ||
"schema": { | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse" | ||
} | ||
} | ||
} | ||
} | ||
}, | ||
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/actionGroups/{actionGroupName}/networkSecurityPerimeterConfigurations/{networkSecurityPerimeterConfigurationName}/reconcile": { | ||
"post": { | ||
"tags": [ | ||
"NetworkSecurityPerimeterConfigurations" | ||
], | ||
"description": "Reconciles a specified NSP configuration for specified action group.", | ||
"operationId": "ActionGroups_ReconcileNSP", | ||
"x-ms-examples": { | ||
"Reconcile NSP config by name for an action group": { | ||
"$ref": "./examples/NSPForActionGroups_Reconcile.json" | ||
} | ||
}, | ||
"parameters": [ | ||
{ | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/SubscriptionIdParameter" | ||
}, | ||
{ | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ResourceGroupNameParameter" | ||
}, | ||
{ | ||
"$ref": "#/parameters/ActionGroupNameParameter" | ||
}, | ||
{ | ||
"$ref": "#/parameters/NetworkSecurityPerimeterConfigurationNameParameter" | ||
}, | ||
{ | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter" | ||
} | ||
], | ||
"responses": { | ||
"202": { | ||
"description": "Request to reconcile the association accepted.", | ||
"headers": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. consider adding a retry-after? here and in other files having POST calls. |
||
"Location": { | ||
"type": "string" | ||
} | ||
} | ||
}, | ||
"default": { | ||
"description": "BadRequest", | ||
"schema": { | ||
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse" | ||
} | ||
} | ||
}, | ||
"x-ms-long-running-operation": true, | ||
"x-ms-long-running-operation-options": { | ||
"final-state-via": "location" | ||
} | ||
} | ||
} | ||
}, | ||
"definitions": {}, | ||
"parameters": { | ||
"ActionGroupNameParameter": { | ||
"name": "actionGroupName", | ||
"in": "path", | ||
"required": true, | ||
"type": "string", | ||
"description": "The name of the action group.", | ||
"x-ms-parameter-location": "method", | ||
"pattern": "^.*$", | ||
"maxLength": 43 | ||
}, | ||
"NetworkSecurityPerimeterConfigurationNameParameter": { | ||
"name": "networkSecurityPerimeterConfigurationName", | ||
"in": "path", | ||
"required": true, | ||
"type": "string", | ||
"pattern": "^.*$", | ||
"minLength": 1, | ||
"maxLength": 512, | ||
"x-ms-parameter-location": "method", | ||
"description": "The name for a network security perimeter configuration" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will there be a case of post responding with 200, meaning that the reconcile on the configurationName is completed or when the Location header responds with a successful terminal state ?
here and in other files having POST calls.