Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EG] System events reformat #28706

Merged
merged 42 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
81ba472
refactor
l0lawrence Apr 16, 2024
7583aef
updayrd
l0lawrence Apr 16, 2024
854fbae
format
l0lawrence Apr 16, 2024
c2375fb
add apicenter
l0lawrence Apr 16, 2024
0860e70
update new events
l0lawrence Apr 16, 2024
0843f61
tsp format
l0lawrence Apr 16, 2024
5fa2b0d
new events
l0lawrence Apr 24, 2024
c6c7981
modelAsString for Media Union as False
l0lawrence Apr 24, 2024
aa0d9d0
tsp format
l0lawrence Apr 24, 2024
92620f7
Revert "tsp format"
l0lawrence Apr 24, 2024
05cac1f
Revert "modelAsString for Media Union as False"
l0lawrence Apr 24, 2024
1b1067c
remove ReadOnly
l0lawrence Apr 25, 2024
57e91ad
rename resources
l0lawrence Apr 25, 2024
757b928
remove duplicate vault
l0lawrence Apr 25, 2024
ec4e60c
remove Optional from Nullable Types part 1
l0lawrence Apr 26, 2024
e64d7c4
add csharp to x-ms-client-names
l0lawrence Apr 26, 2024
d8a832c
typo
l0lawrence Apr 26, 2024
369893c
swagger typo
l0lawrence Apr 26, 2024
875c8b5
formatting
l0lawrence Apr 26, 2024
47cd724
Client Name Overrides JS EG System Events
sarangan12 May 13, 2024
4509605
Adding in renames for Go
May 15, 2024
b77521a
fix RecordingDurationMs casing
May 15, 2024
89d7577
Fixing something that Libba refused to for like months now.
May 15, 2024
b33c0a7
Removing SystemEvents from the constant names
May 15, 2024
83988f2
Should be a number == float64.
May 15, 2024
f3c9555
Field name is labelOperator, not operator.
May 15, 2024
c8a9055
Field is state, not selectorState:
May 15, 2024
b20293c
More renames to bring us to par with what we had before.
May 16, 2024
9bd2401
Adding in some docs that were missing for unions.
May 16, 2024
5673164
format
l0lawrence May 20, 2024
e805098
fix warnigns
l0lawrence May 20, 2024
2290767
moving around clientNames
l0lawrence May 20, 2024
610333c
spellcheck
l0lawrence May 21, 2024
ce26a00
Merge branch 'main' into system_events_format
l0lawrence May 21, 2024
0702f7d
Merge branch 'main' into system_events_format
l0lawrence May 24, 2024
e47777d
Merge branch 'main' into system_events_format
l0lawrence May 26, 2024
57f400f
try to update csharp clientNames
l0lawrence May 27, 2024
0400d0f
tsp format
l0lawrence May 27, 2024
652b9b5
missing labelValue x-ms-client-name
l0lawrence Jun 3, 2024
6d03d70
format
l0lawrence Jun 3, 2024
71fb083
nit typo
l0lawrence Jun 3, 2024
0676dd1
update csharp
l0lawrence Jun 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cSpell.json
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,12 @@
"clientsession"
]
},
{
"filename": "**/specification/eventgrid/data-plane/Microsoft.EventGrid/stable/2024-01-01/SystemEvents.json",
"words": [
"whatsapp"
]
},
{
"filename": "**/specification/eventgrid/data-plane/Microsoft.EventGrid/**/EventGrid.json",
"words": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,15 @@ model AvsClusterFailedEventData extends AvsClusterEventData {
failureMessage?: string;
}

/** Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ScriptExecutionStarted event. */
#suppress "@azure-tools/typespec-azure-core/composition-over-inheritance" "Maintain compatibility with existing models."
model AvsScriptExecutionStartedEventData extends AvsScriptExecutionEventData {}

/** Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ScriptExecutionFinished event. */
#suppress "@azure-tools/typespec-azure-core/composition-over-inheritance" "Maintain compatibility with existing models."
model AvsScriptExecutionFinishedEventData extends AvsScriptExecutionEventData {
/** Named outputs of completed execution, if any. */
namedOutputs?: Record<string>;
namedOutputs: Record<string>;
}

/** Schema of the Data property of an EventGridEvent for a Microsoft.AVS.ScriptExecutionCancelled event. */
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
import "@azure-tools/typespec-client-generator-core";

using Azure.ClientGenerator.Core;
//Models
@@usage(Microsoft.EventGrid.SystemEvents.AvsPrivateCloudUpdatingEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsPrivateCloudUpdatingEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsPrivateCloudUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsPrivateCloudUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsPrivateCloudFailedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsPrivateCloudFailedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsClusterCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsClusterCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsClusterDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsClusterDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsClusterUpdatingEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsClusterUpdatingEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsClusterUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsClusterUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsClusterFailedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsClusterFailedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionStartedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionStartedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionFinishedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionFinishedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionCancelledEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionCancelledEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionFailedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionFailedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsPrivateCloudEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsPrivateCloudEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AvsClusterEventData, Usage.output);
@@access(Microsoft.EventGrid.SystemEvents.AvsClusterEventData, Access.public);
@@usage(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AvsScriptExecutionEventData,
Access.public
);
//Enums
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
/** Describes the schema of the Azure API Center events published to Azure Event Grid. This corresponds to the Data property of an EventGridEvent. */
namespace Microsoft.EventGrid.SystemEvents;

/** Schema of the data property of an EventGridEvent for a Microsoft.ApiCenter.ApiDefinitionAdded event. */
model ApiCenterApiDefinitionAddedEventData {
/** API definition title. */
title?: string;

/** API definition description. */
description?: string;

/** API definition specification. */
specification: ApiCenterApiSpecification;
}

/** Schema of the data property of an EventGridEvent for a Microsoft.ApiCenter.ApiDefinitionUpdated event. */
model ApiCenterApiDefinitionUpdatedEventData {
/** API definition title. */
title?: string;

/** API definition description. */
description?: string;

/** API definition specification. */
specification: ApiCenterApiSpecification;
}

/** API specification details. */
model ApiCenterApiSpecification {
/** Specification name. */
name?: string;

/** Specification version. */
version?: string;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import "@azure-tools/typespec-client-generator-core";

using Azure.ClientGenerator.Core;
//Models
@@usage(Microsoft.EventGrid.SystemEvents.ApiCenterApiDefinitionAddedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiCenterApiDefinitionAddedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiCenterApiDefinitionUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiCenterApiDefinitionUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiCenterApiSpecification,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiCenterApiSpecification,
Access.public
);
//Enums
Original file line number Diff line number Diff line change
@@ -0,0 +1,161 @@
import "@azure-tools/typespec-client-generator-core";

using Azure.ClientGenerator.Core;
//Models
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementUserCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementUserCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementUserUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementUserUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementUserDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementUserDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementSubscriptionCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementSubscriptionCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementSubscriptionUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementSubscriptionUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementSubscriptionDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementSubscriptionDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementProductCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementProductCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementProductUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementProductUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementProductDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementProductDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementApiCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementApiCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementApiUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementApiUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementApiDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementApiDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementApiReleaseCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementApiReleaseCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementApiReleaseUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementApiReleaseUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementApiReleaseDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementApiReleaseDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayHostnameConfigurationCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayHostnameConfigurationCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayHostnameConfigurationUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayHostnameConfigurationUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayHostnameConfigurationDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayHostnameConfigurationDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayCertificateAuthorityCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayCertificateAuthorityCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayCertificateAuthorityUpdatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayCertificateAuthorityUpdatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayCertificateAuthorityDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayCertificateAuthorityDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayApiAddedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayApiAddedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayApiRemovedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.ApiManagementGatewayApiRemovedEventData,
Access.public
);
//Enums
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import "@azure-tools/typespec-client-generator-core";

using Azure.ClientGenerator.Core;
//Models
@@usage(Microsoft.EventGrid.SystemEvents.AppConfigurationKeyValueModifiedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AppConfigurationKeyValueModifiedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AppConfigurationKeyValueDeletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AppConfigurationKeyValueDeletedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AppConfigurationSnapshotEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AppConfigurationSnapshotEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AppConfigurationSnapshotCreatedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AppConfigurationSnapshotCreatedEventData,
Access.public
);
@@usage(Microsoft.EventGrid.SystemEvents.AppConfigurationSnapshotModifiedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AppConfigurationSnapshotModifiedEventData,
Access.public
);
//Enums
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
namespace Microsoft.EventGrid.SystemEvents {
alias RedisBaseEventData = {
/** The time at which the event occurred. */
timestamp?: utcDateTime;
timestamp: utcDateTime;

/** The name of this event. */
name?: string;
Expand Down
Loading