Update TypeSpec to latest 2024-06 release - 0.57 & 0.43 #29440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into typespec-next
…n 2024 06 27 (Azure#28981) * Adds base for updating Microsoft.AppComplianceAutomation from version preview/2022-11-16-preview to version 2024-06-27 * Updates readme * Updates API version in new specs and examples * add new stable version for Microsoft.AppComplianceAutomation * remove the useless example file * fix spell check * remove query in get evidence api * remove the singleton annotation * fix compile error * fix compile error of v56 * fix compile error * fix all compile error and make the swagger align with before * tsp prettier * change scoping name * upgrade the commontypes from v3 to v5 * change commonTypes version to v3 * add service-dir * format tspconfig.yaml * modify tspconfig.yaml * remove custom operations * modify re pattern of snapshot name * make the resource x-ms-client-name properties * format typespec * remove suffix of snapshot * use requestBody replace parameters * Revert "use requestBody replace parameters" This reverts commit e4dd975. * tsp format * remove dotnet from tspconfig.yaml and add azure-sdk-for-net-track2 in readme * add sdk-suppressions.yaml * Update tspconfig.yaml * Update tspconfig.yaml * rename operationid * rename getScopingQuestions and move model reportBaseProperties to alias --------- Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com>
* Init tsp for Microsoft.ScVmm * Some changes towards passing tsv * Updates to fix lint errors, remove unused types, regenerate examples, etc. * Created shareable 'force' param * Figured out the incantation to rename a file case-sensitively * Restored string bool enums. * Removed all examples * Regenerate examples * Updated ARM ID properties. Added script to sort output to compare with sorted old swagger * Additional changes. * Removed unused XXUpdate models, Added @secret for password, * Fixed Azure#8, Azure#6, Azure#5 * Fixed Azure#2 * Update swagger to be in sync with previous fixes. * Workaround for CloudCapacity readonly * Additional fixes. * fix ModelValidation * update void * VM Instance Update Properties changes * spell check and prettier validation fix * fix for identifier bug * workaround for Azure/typespec-azure#449 * format * spell and prettier check improvements * use encodedName replace projectdName * Add summary annotations * summary * update kind and void * lro azure-async-operation * fix * tsp compilation warning * TypeSpec Validation fix * Update tspconfig.yaml * config change * Removed Read Only Property from Examples to fix Swagger ModelValidation * Revert Boolean to Enum with type Union in TypeSpec * specs-pr repo PR review changes to specs repo * Remove sorted json file used for comparison * Fix TypeSpec PR pipeline failure * make extendedLocation for VM Instance read and create * typespec validation fix --------- Co-authored-by: Will Temple <will@wtemple.net> Co-authored-by: Allen Zhang <allenzhang@live.com> Co-authored-by: Alancere <804873052@qq.com> Co-authored-by: Harshit Surana <hsurana@microsoft.com>
* Copy files from stable/2023-07-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-02-01 Updated the API version from stable/2023-07-01 to stable/2024-02-01. * Added tag for 2024-02-01 in readme file * copying over 2024-02-01 changes from ADO * Revert "copying over 2024-02-01 changes from ADO" This reverts commit aa54d74. * adding changes from ado * adding autorun as custom word * adding autorun to custom-words.txt * fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error * fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error * changing type from string back to object * changing type from string back to object * Revert "changing type from string back to object" This reverts commit b0b5122. revert commit * Revert "fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error" This reverts commit 0e52ddf. * referencing examples file * writing suppression for lintdiff * removing userassignedidentity * fixing bad version mismatch * fixing suppression * prettier changes * fixing where syntax * fixing where suppress 2 * where suppress 3 * where supress 4 * where suppress 5 * suppressing entire file
* Update readme.python.md * Update readme.md --------- Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
…` to `ci-fix` doc; Clean up markdownlint rules and `ci-fix` doc. (Azure#29311)
…ure.Core`. (Azure#29318) * Update ci-fix.md * Update ci-fix.md * Update ci-fix.md
* first commit * fix * Add operationType * rename to pointType * fix * update * Update example * update * update description for default value * update description * Remove axleCount for RouteMatrix * Update vehicleSpec * update description * Update description * remove async result * Revert "remove async result" This reverts commit b7b2728. * Remove Summary * follow azure's convention * Remove Accept-Language for RouteMatrix * Update retention period to 24 hours * Add createdDateTime * Add suppressions * Update description --------- Co-authored-by: Will Huang <huangwill@microsoft.com> Co-authored-by: Joel Hendrix <jhendrix@microsoft.com>
…ation (Azure#29297) * fixed the error * npx tsp compile updates --------- Co-authored-by: Travis Wilson <travisw@microsoft.com> Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com>
… service release (Azure#29182) * Azure OpenAI: 2024-04-01-preview updates * add audio formats * post-merge fix incl. tool update for enum conversion to union * minor: spellcheck fix * refine duration encoding for word start/end * enable serialization into azure json and rename customization class name * Added new customBlockList filter and fields to OYD * Adding changes to authentication for Vector Search * Adjusted docs for OYD vector search auth models * Added missing field and retrieved documents * Examples added * corrected examples api-versions in json * Reformat * Recompile after reformat * PR comments: wrong plural and type precision * Revert added tab to service spec Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> * Added readme entry for generated openAPI doc * Trying to improve folder structure * Removed moved and renamed generated.json files * Reverted last 3 commits * Added entry for generated.json swagger in the readme * Changed enum to nonExpandable * Ran formatter --------- Co-authored-by: Travis Wilson <travisw@microsoft.com> Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com> Co-authored-by: Shawn Fang <shafang@microsoft.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com>
* Add v3.2 for Speech to text (3.2p2 as base) * Update swagger with new changes and updated version number * Update readme.md with new version * Added evaluation token errors * Revert ttl changes for transcriptions * Finalized api changes for GA * Try fix avocado error
This was referenced Jun 14, 2024
|
Approved JS breakings. I have a chance to deep dive the JS SDK breakings and these breakings are not introduced by this pr. |
…into typespec0_57
MaryGao
reviewed
Jun 14, 2024
| @@ -465,9 +465,9 @@ | |||
| } | |||
| }, | |||
| "definitions": { | |||
| "Azure.ResourceManager.Foundations.ManagedServiceIdentityType": { | |||
| "Azure.ResourceManager.Legacy.ManagedServiceIdentityType": { | |||
There was a problem hiding this comment.
Can we use the Foundations one? The legacy may cause generation failure https://github.com/Azure/sdk-release-request/issues/5256#issuecomment-2167100740.
There was a problem hiding this comment.
With the ARM reorg in 0.57. ARM common type is directly controlled by CommonType.Versions via @armCommonTypes decorator. If none specified, it is default to v3. So you don't have the ability to mix and match. In the case of managed identity, since there were few (5?) that is in mixed v3, v4 case, I decided to add a Legacy v4 directly to get these spec migrated. This is only temporary. Once spec is fully moved to v4 or v5, then the legacy version is no longer needed. You can see the dev comment on Legacy.ManagedServiceIdentityType
qiaozha
reviewed
Jun 17, 2024
| @@ -46,7 +46,7 @@ model FleetUpdate { | |||
| } | |||
|
|
|||
| model ManagedServiceIdentityUpdate | |||
| is OptionalProperties<UpdateableProperties<Azure.ResourceManager.Foundations.ManagedServiceIdentity>>; | |||
| is OptionalProperties<UpdateableProperties<Azure.ResourceManager.Legacy.ManagedServiceIdentityV4>>; | |||
There was a problem hiding this comment.
@allenjzhang I don't think we should change the Foundations to Legacy in this case, they have specified @armCommonTypesVersion(Azure.ResourceManager.CommonTypes.Versions.v5 before and it's a misrepresent issue between typespec and ARM definition. Customer thought they have specified v5 but we didn't generate the swagger as they thought, it seems logical to change the definition align with what they have defined before, not with the wrongful representation?
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.