-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add finetuning job with maap contracts. #29638
Merged
madhura-np
merged 8 commits into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview
from
sagarsumant:sasum/finetuning-job-maap
Jul 10, 2024
Merged
Add finetuning job with maap contracts. #29638
madhura-np
merged 8 commits into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview
from
sagarsumant:sasum/finetuning-job-maap
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR validation pipeline restarted successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Swagger Validation Report
|
Compared specs (v0.10.12) | new version | base version |
---|---|---|
mfe.json | 2024-07-01-preview(2d67af1) | 2024-04-01(main) |
mfe.json | 2024-07-01-preview(2d67af1) | 2024-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L12:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L57:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups/{groupId}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L105:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/models/{modelName}/versions/{version}/package' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L3853:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9344:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9430:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}/getStatus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9727:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}/skus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9779:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/endpoints' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9844:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/endpoints/{endpointName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9938:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L10268:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L10362:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}/getStatus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L10690:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}/skus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L10749:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11298:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11356:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/exportLabels' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11542:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/pause' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11626:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/resume' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11678:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/models/{name}/versions/{version}/package' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L12339:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/schedules/{name}/trigger' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L13944:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}/getStatus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14356:5 |
|
The new version is missing a definition that was found in the old version. Was 'AuthMode' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3 Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3 |
|
The new version is missing a definition that was found in the old version. Was 'AutoDeleteCondition' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3 Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3 |
|
The new version is missing a definition that was found in the old version. Was 'AutoDeleteSetting' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3 Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3 |
|
The new version is missing a definition that was found in the old version. Was 'AutologgerSettings' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3 Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3 |
|
The new version is missing a definition that was found in the old version. Was 'AzureMLBatchInferencingServer' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3 Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3 |
|
The new version is missing a definition that was found in the old version. Was 'AzureMLOnlineInferencingServer' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3 Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3 |
|
The new version is missing a definition that was found in the old version. Was 'BaseEnvironmentId' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3 Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3 |
|
The new version is missing a definition that was found in the old version. Was 'BaseEnvironmentSource' removed or renamed? New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3 Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3 |
️🔄
LintDiff inProgress [Detail]
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Jun 29, 2024
This was referenced Jun 29, 2024
madhura-np
reviewed
Jul 9, 2024
...soft.MachineLearningServices/preview/2024-07-01-preview/examples/Job/FineTuningJob/list.json
Outdated
Show resolved
Hide resolved
madhura-np
added
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Jul 9, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jul 9, 2024
ragovada
removed
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Jul 10, 2024
openapi-pipeline-app
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jul 10, 2024
madhura-np
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
Jul 10, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jul 10, 2024
/azp run |
Commenter does not have sufficient privileges for PR 29638 in repo Azure/azure-rest-api-specs |
/pr RequestMerge |
madhura-np
approved these changes
Jul 10, 2024
madhura-np
merged commit Jul 10, 2024
00edbc9
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview
25 of 29 checks passed
razvanbadea-msft
pushed a commit
that referenced
this pull request
Jul 26, 2024
…024 07 01 preview (#29503) * Copy files from stable/2024-04-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-07-01-preview Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview. * Added tag for 2024-07-01-preview in readme file * Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519) * add expirable secrets * examples + spelling * prettier + spell check --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Fix Prettier errors (#29523) * Fix Prettier errors * Add pre-approved supressions * fix formatting * Add finetuning job with maap contracts. (#29638) * Add finetuning job with maap contracts. * prettier * adding exceptions. * add reference to examples. * prettier * Fix gate. * Fixed the comment, added "FineTuning" in JobType. * Fixed comment. --------- Co-authored-by: Sagar Sumant <sasum@microsoft.com> * WRP 2024-07-01-preview swagger change (#29729) * sync with previous preview * Update exmaples * Update more example and readme * Update suppression from previous preview * Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657) * tc: adding managedResrouceGroupSettings to 2024-07-01-preview * tc: adding missing definitions * tc: adding more definitions * tc: applying changes based on comments * tc: adding SDK suppression for UUID formatting * tc: removing the suppression - because I don't think this is right * tc: adding guid suppression - not sure if it's the correct format * tc: adding suppressions.yaml * tc: put suppression in readme file --------- Co-authored-by: Theodore Chen <theodorechen@microsoft.com> * [WRP] 2024-07-01-preview change (#29861) * Add changes for 07-01-preview * add missing properties * rename example * rename example * Update Schema * Update type dicriminator * Fix errors * Error fix * Update example and readme * run prettier * Rename to fix some schema name conflict * Update suppressions * Update comment feedbacks * run prettier --------- Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com> Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: sagarsumant <sagar.sumant@gmail.com> Co-authored-by: Sagar Sumant <sasum@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: Theodore Chen <theodoreschen@gmail.com> Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
hmmorales
pushed a commit
that referenced
this pull request
Jul 31, 2024
…024 07 01 preview (#29503) * Copy files from stable/2024-04-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-07-01-preview Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview. * Added tag for 2024-07-01-preview in readme file * Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519) * add expirable secrets * examples + spelling * prettier + spell check --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * Fix Prettier errors (#29523) * Fix Prettier errors * Add pre-approved supressions * fix formatting * Add finetuning job with maap contracts. (#29638) * Add finetuning job with maap contracts. * prettier * adding exceptions. * add reference to examples. * prettier * Fix gate. * Fixed the comment, added "FineTuning" in JobType. * Fixed comment. --------- Co-authored-by: Sagar Sumant <sasum@microsoft.com> * WRP 2024-07-01-preview swagger change (#29729) * sync with previous preview * Update exmaples * Update more example and readme * Update suppression from previous preview * Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657) * tc: adding managedResrouceGroupSettings to 2024-07-01-preview * tc: adding missing definitions * tc: adding more definitions * tc: applying changes based on comments * tc: adding SDK suppression for UUID formatting * tc: removing the suppression - because I don't think this is right * tc: adding guid suppression - not sure if it's the correct format * tc: adding suppressions.yaml * tc: put suppression in readme file --------- Co-authored-by: Theodore Chen <theodorechen@microsoft.com> * [WRP] 2024-07-01-preview change (#29861) * Add changes for 07-01-preview * add missing properties * rename example * rename example * Update Schema * Update type dicriminator * Fix errors * Error fix * Update example and readme * run prettier * Rename to fix some schema name conflict * Update suppressions * Update comment feedbacks * run prettier --------- Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com> Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: sagarsumant <sagar.sumant@gmail.com> Co-authored-by: Sagar Sumant <sasum@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com> Co-authored-by: Theodore Chen <theodoreschen@gmail.com> Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.