Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finetuning job with maap contracts. #29638

Conversation

sagarsumant
Copy link
Contributor

@sagarsumant sagarsumant commented Jun 29, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify: Add FineTuningJob contracts in MachineLearningServices API 2024-07-01-Preview contracts/

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Copy link

openapi-pipeline-app bot commented Jun 29, 2024

PR validation pipeline restarted successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

Copy link

openapi-pipeline-app bot commented Jun 29, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 333 Warnings warning [Detail]
Compared specs (v0.10.12) new version base version
mfe.json 2024-07-01-preview(2d67af1) 2024-04-01(main)
mfe.json 2024-07-01-preview(2d67af1) 2024-04-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L12:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L57:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/capacityReserverationGroups/{groupId}' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L105:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/models/{modelName}/versions/{version}/package' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L3853:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9344:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9430:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}/getStatus' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9727:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{inferencePoolName}/skus' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9779:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/endpoints' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9844:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/endpoints/{endpointName}' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L9938:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L10268:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L10362:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}/getStatus' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L10690:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/inferencePools/{poolName}/groups/{groupName}/skus' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L10749:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11298:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11356:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/exportLabels' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11542:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/pause' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11626:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/resume' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L11678:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/models/{name}/versions/{version}/package' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L12339:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/schedules/{name}/trigger' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L13944:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/serverlessEndpoints/{name}/getStatus' removed or restructured?
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14356:5
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AuthMode' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutoDeleteCondition' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutoDeleteSetting' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutologgerSettings' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AzureMLBatchInferencingServer' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AzureMLOnlineInferencingServer' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BaseEnvironmentId' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BaseEnvironmentSource' removed or renamed?
New: Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json#L11908:3
Old: Microsoft.MachineLearningServices/preview/2024-04-01-preview/mfe.json#L14548:3
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jun 29, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
    For more instructions, please refer to the FAQ .
  • Failed in generating from f562e6464c2b71c40480323b04d02c4fe0fbec63. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
  • Azure.ResourceManager.MachineLearning [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from f562e6464c2b71c40480323b04d02c4fe0fbec63. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/machinelearning/armmachinelearning [Preview SDK Changes]
️🔄 azure-sdk-for-python inProgress [Detail]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from f562e6464c2b71c40480323b04d02c4fe0fbec63. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-machinelearning [Preview SDK Changes] Breaking Change Detected
    Only showing 120 items here. Refer to log for details.
    info	[Changelog] #### `models.KubernetesOnlineDeployment` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `withDataCollector(models.DataCollector)` was added
    info	[Changelog] * `endpointComputeType()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `provisioningState()` was added
    info	[Changelog]
    info	[Changelog] #### `models.AccountKeyDatastoreSecrets` was modified
    info	[Changelog]
    info	[Changelog] * `secretsType()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ServicePrincipalDatastoreSecrets` was modified
    info	[Changelog]
    info	[Changelog] * `secretsType()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.OnlineEndpointProperties` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `swaggerUri()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `withMirrorTraffic(java.util.Map)` was added
    info	[Changelog] * `mirrorTraffic()` was added
    info	[Changelog] * `scoringUri()` was added
    info	[Changelog]
    info	[Changelog] #### `models.CustomSeasonality` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `mode()` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ResourceId` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.RecurrenceTrigger` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `triggerType()` was added
    info	[Changelog]
    info	[Changelog] #### `models.FqdnEndpointDetail` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ComputeInstanceLastOperation` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ForecastingSettings` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.EnvironmentContainerResourceArmPaginatedResult` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.JobBaseProperties` was modified
    info	[Changelog]
    info	[Changelog] * `withNotificationSetting(models.NotificationSetting)` was added
    info	[Changelog] * `jobType()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `notificationSetting()` was added
    info	[Changelog]
    info	[Changelog] #### `models.PyTorch` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `distributionType()` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.UserAssignedIdentity` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.DataLakeAnalyticsSchemaProperties` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ComponentVersionProperties` was modified
    info	[Changelog]
    info	[Changelog] * `provisioningState()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.SamplingAlgorithm` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `samplingAlgorithmType()` was added
    info	[Changelog]
    info	[Changelog] #### `models.PatAuthTypeWorkspaceConnectionProperties` was modified
    info	[Changelog]
    info	[Changelog] * `withExpiryTime(java.time.OffsetDateTime)` was added
    info	[Changelog] * `withSharedUserList(java.util.List)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `withIsSharedToAll(java.lang.Boolean)` was added
    info	[Changelog] * `withMetadata(java.util.Map)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `authType()` was added
    info	[Changelog] * `createdByWorkspaceArmId()` was added
    info	[Changelog] * `group()` was added
    info	[Changelog]
    info	[Changelog] #### `models.ComputeSchedules` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog]
    Please refer to the guidance for suppressing SDK breaking changes.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from f562e6464c2b71c40480323b04d02c4fe0fbec63. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-machinelearning [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from f562e6464c2b71c40480323b04d02c4fe0fbec63. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.2
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️⚠️ azure-powershell warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from f562e6464c2b71c40480323b04d02c4fe0fbec63. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.machinelearningservices.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jun 29, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/machinelearning/armmachinelearning https://apiview.dev/Assemblies/Review/c19328b4fc084461adfa498aa764be2f?revisionId=ae5bffce0b2f42c78363553302bd8328
Java azure-resourcemanager-machinelearning https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=ca0a0b3aaf7c4b8eaca47d30d2b1ebcb
JavaScript @azure/arm-machinelearning https://apiview.dev/Assemblies/Review/4b0822cc790d43b3b46bc9b075044246?revisionId=857684c25b504dfc84296f096e03826c
.Net Azure.ResourceManager.MachineLearning There is no API change compared with the previous version
Swagger Microsoft.MachineLearningServices https://apiview.dev/Assemblies/Review/af9cc69e6ae94f27ab2ca41fddf6ba46?revisionId=ed5da925994f4ba38d86b0c9cbaea669

@madhura-np
Copy link
Member

        "value": "Spark"

finetuning value is missing.


Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json:18767 in 4a79c05. [](commit_id = 4a79c05, deletion_comment = False)

@madhura-np madhura-np added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 9, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2024
@sagarsumant
Copy link
Contributor Author

        "value": "Spark"

finetuning value is missing.

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2024-07-01-preview/mfe.json:18767 in 4a79c05. [](commit_id = 4a79c05, deletion_comment = False)

Fixed this comment.

@sagarsumant sagarsumant reopened this Jul 10, 2024
@ragovada ragovada removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 10, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 10, 2024
@madhura-np madhura-np added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 10, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 10, 2024
@sagarsumant
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 29638 in repo Azure/azure-rest-api-specs

@sagarsumant
Copy link
Contributor Author

/pr RequestMerge

@madhura-np madhura-np merged commit 00edbc9 into Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2024-07-01-preview Jul 10, 2024
25 of 29 checks passed
razvanbadea-msft pushed a commit that referenced this pull request Jul 26, 2024
…024 07 01 preview (#29503)

* Copy files from stable/2024-04-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-07-01-preview

Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview.

* Added tag for 2024-07-01-preview in readme file

* Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519)

* add expirable secrets

* examples + spelling

* prettier + spell check

---------

Co-authored-by: Kayla Ames <kaseager@microsoft.com>

* Fix Prettier errors (#29523)

* Fix Prettier errors

* Add pre-approved supressions

* fix formatting

* Add finetuning job with maap contracts. (#29638)

* Add finetuning job with maap contracts.

* prettier

* adding exceptions.

* add reference to examples.

* prettier

* Fix gate.

* Fixed the comment, added "FineTuning" in JobType.

* Fixed comment.

---------

Co-authored-by: Sagar Sumant <sasum@microsoft.com>

* WRP 2024-07-01-preview swagger change (#29729)

* sync with previous preview

* Update exmaples

* Update more example and readme

* Update suppression from previous preview

* Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657)

* tc: adding managedResrouceGroupSettings to 2024-07-01-preview

* tc: adding missing definitions

* tc: adding more definitions

* tc: applying changes based on comments

* tc: adding SDK suppression for UUID formatting

* tc: removing the suppression - because I don't think this is right

* tc: adding guid suppression - not sure if it's the correct format

* tc: adding suppressions.yaml

* tc: put suppression in readme file

---------

Co-authored-by: Theodore Chen <theodorechen@microsoft.com>

* [WRP] 2024-07-01-preview change (#29861)

* Add changes for 07-01-preview

* add missing properties

* rename example

* rename example

* Update Schema

* Update type dicriminator

* Fix errors

* Error fix

* Update example and readme

* run prettier

* Rename to fix some schema name conflict

* Update suppressions

* Update comment feedbacks

* run prettier

---------

Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com>
Co-authored-by: Kayla Ames <kaseager@microsoft.com>
Co-authored-by: sagarsumant <sagar.sumant@gmail.com>
Co-authored-by: Sagar Sumant <sasum@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: Theodore Chen <theodoreschen@gmail.com>
Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
hmmorales pushed a commit that referenced this pull request Jul 31, 2024
…024 07 01 preview (#29503)

* Copy files from stable/2024-04-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-07-01-preview

Updated the API version from stable/2024-04-01 to preview/2024-07-01-preview.

* Added tag for 2024-07-01-preview in readme file

* Changing MFE ARM Spec to add support for expirable secrets to the listsecrets API (#29519)

* add expirable secrets

* examples + spelling

* prettier + spell check

---------

Co-authored-by: Kayla Ames <kaseager@microsoft.com>

* Fix Prettier errors (#29523)

* Fix Prettier errors

* Add pre-approved supressions

* fix formatting

* Add finetuning job with maap contracts. (#29638)

* Add finetuning job with maap contracts.

* prettier

* adding exceptions.

* add reference to examples.

* prettier

* Fix gate.

* Fixed the comment, added "FineTuning" in JobType.

* Fixed comment.

---------

Co-authored-by: Sagar Sumant <sasum@microsoft.com>

* WRP 2024-07-01-preview swagger change (#29729)

* sync with previous preview

* Update exmaples

* Update more example and readme

* Update suppression from previous preview

* Adding ManagedResourceGroupSettings to RegistryRP in 2024-07-01-Preview (#29657)

* tc: adding managedResrouceGroupSettings to 2024-07-01-preview

* tc: adding missing definitions

* tc: adding more definitions

* tc: applying changes based on comments

* tc: adding SDK suppression for UUID formatting

* tc: removing the suppression - because I don't think this is right

* tc: adding guid suppression - not sure if it's the correct format

* tc: adding suppressions.yaml

* tc: put suppression in readme file

---------

Co-authored-by: Theodore Chen <theodorechen@microsoft.com>

* [WRP] 2024-07-01-preview change (#29861)

* Add changes for 07-01-preview

* add missing properties

* rename example

* rename example

* Update Schema

* Update type dicriminator

* Fix errors

* Error fix

* Update example and readme

* run prettier

* Rename to fix some schema name conflict

* Update suppressions

* Update comment feedbacks

* run prettier

---------

Co-authored-by: Kayla Seager <1675997+kseager@users.noreply.github.com>
Co-authored-by: Kayla Ames <kaseager@microsoft.com>
Co-authored-by: sagarsumant <sagar.sumant@gmail.com>
Co-authored-by: Sagar Sumant <sasum@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: Theodore Chen <theodoreschen@gmail.com>
Co-authored-by: Theodore Chen <theodorechen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants