-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nguyensteven/2024 09 02 preview acns api #30708
Merged
FumingZhang
merged 2 commits into
Azure:FumingZhang-containerservice-Microsoft.ContainerService-2024-09-02-preview
from
snguyen64:nguyensteven/2024-09-02-preview-acns-api
Sep 26, 2024
Merged
Nguyensteven/2024 09 02 preview acns api #30708
FumingZhang
merged 2 commits into
Azure:FumingZhang-containerservice-Microsoft.ContainerService-2024-09-02-preview
from
snguyen64:nguyensteven/2024-09-02-preview-acns-api
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snguyen64
requested review from
msyyc,
palma21,
matthchr and
a team
as code owners
September 24, 2024 17:24
snguyen64
requested review from
scgbear and
marclerwick
and removed request for
a team
September 24, 2024 17:24
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
snguyen64
changed the base branch from
main
to
FumingZhang-containerservice-Microsoft.ContainerService-2024-09-02-preview
September 24, 2024 17:24
snguyen64
force-pushed
the
nguyensteven/2024-09-02-preview-acns-api
branch
from
September 24, 2024 17:27
c06880f
to
189d9aa
Compare
matthchr
approved these changes
Sep 25, 2024
FumingZhang
merged commit Sep 26, 2024
f5a9b7b
into
Azure:FumingZhang-containerservice-Microsoft.ContainerService-2024-09-02-preview
24 of 28 checks passed
FumingZhang
pushed a commit
that referenced
this pull request
Nov 5, 2024
* feat(retina): update advanced networking api in 2024-09-02-preview * run npx prettier
FumingZhang
added a commit
that referenced
this pull request
Nov 11, 2024
…iew/2024-09-02-preview (#31417) * Adds base for updating Microsoft.ContainerService/aks from version preview/2024-07-02-preview to version preview/2024-09-02-preview * Updates readme * Updates API version in new specs and examples * Nguyensteven/2024 09 02 preview acns api (#30708) * feat(retina): update advanced networking api in 2024-09-02-preview * run npx prettier * {AKS}: remove `default` from networkPlugin (#30845) NetworkPlugin will be defaulted based on k8s version rather than API version going forward. The default value in k8s < 1.30 will remain kubenet while in 1.30+ it will be CNI Overlay. * update (#30976) * add seccomp to kubelet config (#30974) * add seccomp to kubelet config * rewording description for default seccomp profile * add max unavailable (#31378) Co-authored-by: Yingni Zhou <jennifer@Mac.home> * fix breaking change 1042 (#31454) * Update sdk-suppressions.yaml --------- Co-authored-by: Steven Nguyen <30740718+snguyen64@users.noreply.github.com> Co-authored-by: Tyler Lloyd <tyler.lloyd@microsoft.com> Co-authored-by: beilei <beileihuang@microsoft.com> Co-authored-by: Jenniferyingni <Jennyingni@gmail.com> Co-authored-by: Yingni Zhou <jennifer@Mac.home> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
mikeharder
pushed a commit
to mikeharder/azure-rest-api-specs
that referenced
this pull request
Nov 13, 2024
…iew/2024-09-02-preview (Azure#31417) * Adds base for updating Microsoft.ContainerService/aks from version preview/2024-07-02-preview to version preview/2024-09-02-preview * Updates readme * Updates API version in new specs and examples * Nguyensteven/2024 09 02 preview acns api (Azure#30708) * feat(retina): update advanced networking api in 2024-09-02-preview * run npx prettier * {AKS}: remove `default` from networkPlugin (Azure#30845) NetworkPlugin will be defaulted based on k8s version rather than API version going forward. The default value in k8s < 1.30 will remain kubenet while in 1.30+ it will be CNI Overlay. * update (Azure#30976) * add seccomp to kubelet config (Azure#30974) * add seccomp to kubelet config * rewording description for default seccomp profile * add max unavailable (Azure#31378) Co-authored-by: Yingni Zhou <jennifer@Mac.home> * fix breaking change 1042 (Azure#31454) * Update sdk-suppressions.yaml --------- Co-authored-by: Steven Nguyen <30740718+snguyen64@users.noreply.github.com> Co-authored-by: Tyler Lloyd <tyler.lloyd@microsoft.com> Co-authored-by: beilei <beileihuang@microsoft.com> Co-authored-by: Jenniferyingni <Jennyingni@gmail.com> Co-authored-by: Yingni Zhou <jennifer@Mac.home> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.