-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SFRP map types and error model #3083
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/servicefabric/resource-manager/readme.md
|
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/servicefabric/resource-manager/readme.md
|
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
@@ -1581,8 +1513,7 @@ | |||
"in": "path", | |||
"description": "The customer subscription identifier.", | |||
"required": true, | |||
"type": "string", | |||
"x-ms-parameter-location": "method" | |||
"type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to specify a x-ms-parameter-location for global parameters. It can be client/method. But, you must have a value. Please fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarangan12 Fixed.
@sarangan12 Fixed all issues. |
@@ -2124,7 +2097,7 @@ | |||
"description": "The customer subscription identifier.", | |||
"required": true, | |||
"type": "string", | |||
"x-ms-parameter-location": "method" | |||
"x-ms-parameter-location": "client" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this change? This will be breaking change in the SDK. So, Please confirm if you are absolutely sure that this is what you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarangan12 These resources were not part of the SDK until now, so this is not a breaking change.
@sarangan12 Can this PR be merged now? There are other customer integrations waiting on this to be published. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger