-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Azure Container Registry policies api and update OperationDefinition #3094
Conversation
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-libraries-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
3f66115
to
93ffd75
Compare
560cb74
to
a13586d
Compare
@marstr I don't understand why the CI complains when adding values to enum property. Can you please take a look? INFO:swaggertosdk.autorest_tools:TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases |
@lmazuel, is adding enum properties categorically breaking, or is this something to do with the way that value was added? |
@ravbhatnagar may be able to help shed some light here too. |
Yes adding values to an enum is a breaking change. The reason being a strongly typed SDK will not be able to deserialize a value it doesnt understand. To avoid this, enums need to be categorized as modelAsString:true. |
@ravbhatnagar We have set |
a13586d
to
56239b4
Compare
edit: @ravbhatnagar still has the WaitForARMFeedback label on this. We should still wait for his approval. |
@ravbhatnagar Can you please review the swagger changes? |
Looks good! |
Ready for me to merge, @ankurkhemani ? |
@marstr Let's wait for the ARM manifest change to be applied .. I will let you know. Thanks! |
Any updates here, or an estimated time-line for when these changes should be applied? |
Closing as stale. Feel free to ping this thread to have it re-opened. |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
@marstr Can you please re-open this PR and merge it? |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger