Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] add POST endpoint for fetching accessProfiles #3098

Merged
merged 5 commits into from
May 21, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"parameters": {
"api-version": "2017-08-31",
"subscriptionId": "subid1",
"resourceGroupName": "rg1",
"resourceName": "clustername1",
"roleName": "clusterUser"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/subid1/resourcegroups/rg1/providers/Microsoft.ContainerService/managedClusters/clustername1/accessProfiles/clusterUser",
"location": "location1",
"name": "clusterUser",
"properties": {
"kubeConfig": "kubeConfig1"
},
"type": "Microsoft.ContainerService/ManagedClusters/AccessProfiles"
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@
],
"operationId": "ManagedClusters_GetUpgradeProfile",
"summary": "Gets upgrade profile for a managed cluster.",
"description": "Gets the details of the upgrade profile for a managed cluster with a specified resource group and name.",
"deprecated": true,
"description": "Use ManagedClusters_ListCredential instead.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are deprecating the wrong operation. I believe you should deprecate operationId ManagedClusters_GetAccessProfiles, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, my mistake. I'll fix.

"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
Expand Down Expand Up @@ -154,6 +155,58 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/accessProfiles/{roleName}/listCredential": {
"post": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mboersma If this operation is preferred to ManagedClusters_GetAccessProfiles, you should declare it as deprecated (deprecated: True and update the description to say something generic like "Use ListCredential instead").

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmazuel done.

"tags": [
"ManagedClusters"
],
"operationId": "ManagedClusters_ListCredential",
"summary": "Gets an access profile of a managed cluster.",
"description": "Gets the accessProfile for the specified role name of the managed cluster with a specified resource group and name.",
"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
{
"name": "resourceName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the managed cluster resource."
},
{
"name": "roleName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the role for managed cluster accessProfile resource."
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/ManagedClusterAccessProfile"
}
}
},
"x-ms-examples": {
"Get Managed Cluster": {
"$ref": "./examples/ManagedClustersListCredential.json"
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/accessProfiles/{roleName}": {
"get": {
"tags": [
Expand Down
2 changes: 1 addition & 1 deletion specification/containerservices/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ python:
payload-flattening-threshold: 2
namespace: azure.mgmt.containerservice
package-name: azure-mgmt-containerservice
package-version: 3.0.1
package-version: 3.1.0
clear-output-folder: true
```
``` yaml $(python) && $(python-mode) == 'update'
Expand Down