Add APIs for integration runtime sharing feature. #3124

zhangyd2015 · 2018-05-23T05:04:33Z

Add APIs for integration runtime sharing feature.
Add two fields 'pushedVersion' 'latestVersion' into SelfHostedIntegrationRuntimeStatus
Fixed issue #2057

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Add two fields 'pushedVersion' 'latestVersion' into SelfHostedIntegrationRuntimeStatus Fixed issue #2057

zhangyd2015 · 2018-05-23T05:06:54Z

...tafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/datafactory.json

@@ -564,7 +651,7 @@
          "200": {
            "description": "OK.",
            "schema": {
-              "$ref": "#/definitions/IntegrationRuntimeStatusResponse"
+              "$ref": "#/definitions/IntegrationRuntimeResource"


Here is to fix issue #2057

This fix should go into new API version since it is a breaking change. I'm adding it in my PR.

Need to remove from here.

AutorestCI · 2018-05-23T05:07:15Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpfos_9x_c/rest/specification/datafactory/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpfos_9x_c/sdk', '--use=@microsoft.azure/autorest.python@~3.0', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4280; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0->3.0.52)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
FailFast:

   at System.Diagnostics.Debug.Assert(Boolean condition, String message, String detailMessage)
   at AutoRest.Extensions.SwaggerExtensions.FlattenProperty(Property propertyToFlatten, HashSet`1 typesToDelete) in /opt/vsts/work/1/s/autorest.common/src/SwaggerExtensions.cs:line 220
   at AutoRest.Extensions.SwaggerExtensions.FlattenModels(CodeModel codeModel) in /opt/vsts/work/1/s/autorest.common/src/SwaggerExtensions.cs:line 95
   at AutoRest.Python.Azure.TransformerPya.TransformCodeModel(CodeModel cm) in /opt/vsts/work/1/s/src/azure/TransformerPya.cs:line 33
   at AutoRest.Python.Program.<ProcessInternal>d__3.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 107
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& currentTask)
   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
   at System.Threading.Tasks.Task`1.TrySetResult(TResult result)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetExistingTaskResult(TResult result)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetResult(TResult result)
   at Microsoft.Perks.JsonRPC.Connection.<Request>d__37`1.MoveNext() in /opt/vsts/work/1/s/autorest.common/src/JsonRpc/Connection.cs:line 371
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& currentTask)
   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
   at System.Threading.Tasks.Task`1.TrySetResult(TResult result)
   at System.Threading.Tasks.TaskCompletionSource`1.TrySetResult(TResult result)
   at Microsoft.Perks.JsonRPC.CallerResponse`1.SetCompleted(JToken result) in /opt/vsts/work/1/s/autorest.common/src/JsonRpc/CallerResponse.cs:line 57
   at Microsoft.Perks.JsonRPC.Connection.<>c__DisplayClass27_0.<<Process>b__0>d.MoveNext() in /opt/vsts/work/1/s/autorest.common/src/JsonRpc/Connection.cs:line 289
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Perks.JsonRPC.Connection.<>c__DisplayClass27_0.<Process>b__0()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

   at System.Environment.FailFast(System.String, System.Exception)
   at AutoRest.Extensions.SwaggerExtensions.FlattenProperty(AutoRest.Core.Model.Property, System.Collections.Generic.HashSet`1<System.String>)
   at AutoRest.Extensions.SwaggerExtensions.FlattenModels(AutoRest.Core.Model.CodeModel)
   at AutoRest.Python.Azure.TransformerPya.TransformCodeModel(AutoRest.Core.Model.CodeModel)
   at AutoRest.Python.Program+<ProcessInternal>d__3.MoveNext()
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Action, Boolean, System.Threading.Tasks.Task ByRef)
   at System.Threading.Tasks.Task.RunContinuations(System.Object)
   at System.Threading.Tasks.Task`1[[System.Nullable`1[[System.Boolean, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].TrySetResult(System.Nullable`1<Boolean>)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Nullable`1[[System.Boolean, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].SetExistingTaskResult(System.Nullable`1<Boolean>)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Nullable`1[[System.Boolean, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].SetResult(System.Nullable`1<Boolean>)
   at Microsoft.Perks.JsonRPC.Connection+<Request>d__37`1[[System.Nullable`1[[System.Boolean, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Action, Boolean, System.Threading.Tasks.Task ByRef)
   at System.Threading.Tasks.Task.RunContinuations(System.Object)
   at System.Threading.Tasks.Task`1[[System.Nullable`1[[System.Boolean, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].TrySetResult(System.Nullable`1<Boolean>)
   at System.Threading.Tasks.TaskCompletionSource`1[[System.Nullable`1[[System.Boolean, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].TrySetResult(System.Nullable`1<Boolean>)
   at Microsoft.Perks.JsonRPC.CallerResponse`1[[System.Nullable`1[[System.Boolean, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].SetCompleted(Newtonsoft.Json.Linq.JToken)
   at Microsoft.Perks.JsonRPC.Connection+<>c__DisplayClass27_0+<<Process>b__0>d.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[[System.__Canon, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.__Canon ByRef)
   at Microsoft.Perks.JsonRPC.Connection+<>c__DisplayClass27_0.<Process>b__0()
   at System.Threading.Tasks.Task`1[[System.__Canon, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].InnerInvoke()
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
FATAL: python/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.python' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.python' terminated.

AutorestCI · 2018-05-23T05:08:21Z

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#18

zhangyd2015 · 2018-05-23T05:08:56Z

...tafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/datafactory.json

-            "type": "string",
-            "description": "The resource type.",
-            "readOnly": true
+  "definitions": {


Most of the differences in "definitions" is format changes.

Can you guys eliminate these format changes to make sure important changes are not missed?

AutorestCI · 2018-05-23T05:09:17Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2770

AutorestCI · 2018-05-23T05:10:03Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2008

annatisch · 2018-05-23T14:03:58Z

Thanks @zhangyd2015 - there are some model validation errors - could you take a look?
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/382499293

annatisch · 2018-05-23T14:16:15Z

...tafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/datafactory.json

+        "tags": [
+          "factories"
+        ],
+        "operationId": "Factories_ListSharedIntegrationRuntime",


This operation should use the x-ms-pageable extension

@annatisch Done.

annatisch · 2018-05-23T14:16:34Z

...tafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/datafactory.json

+        "tags": [
+          "factories"
+        ],
+        "operationId": "Factories_ListSharedFactory",


This operation should use the x-ms-pageable extension

@annatisch Done.

…time and Factories_ListSharedFactory

AutorestCI · 2018-05-24T02:30:13Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

zhangyd2015 · 2018-05-24T06:25:56Z

@annatisch Fixed the model validation errors introduced by my PR. For rest of the validation errors for integration runtime, I guess it might be to oav tool error which can't handle the model well.

annatisch · 2018-05-24T16:21:22Z

@zhangyd2015 - this error looks like it should be fixable (factoryId should be factoryResourceId):

{ code: 'REQUEST_VALIDATION_ERROR',
  id: 'OAV109',
  message: 'Found errors in validating the request for x-ms-example "Factories_ConfigureFactoryRepo" in operation "Factories_ConfigureFactoryRepo".',
  innerErrors: 
   [ { code: 'INVALID_REQUEST_PARAMETER',
       errors: 
        [ { code: 'OBJECT_ADDITIONAL_PROPERTIES',
            params: [ [ 'factoryId' ] ],
            message: 'Additional properties not allowed: factoryId',
            path: [],
            description: 'Factory\'s VSTS repo information.' } ],
       in: 'body',
       message: 'Invalid parameter (factoryRepoUpdate): Value failed JSON Schema validation',
       name: 'factoryRepoUpdate',
       path: 
        [ 'paths',
          '/subscriptions/{subscriptionId}/providers/Microsoft.DataFactory/locations/{locationId}/configureFactoryRepo',
          'post',
          'parameters',
          '3' ] } ] }

I will take a look at the others.

zhangyd2015 · 2018-05-25T02:19:21Z

@annatisch I am using oav version 0.4.38 which will report model validation error. Before I upgraded my oav, I remembered no such model validation error with old version.

annatisch · 2018-05-25T14:42:02Z

@zhangyd2015 - thanks for the fix - it would be really great if we could get these last 5 examples passing:

IntegrationRuntimes_ListByFactory
IntegrationRuntimes_Create
IntegrationRuntimes_Get
IntegrationRuntimes_GetStatus
IntegrationRuntimes_Start

Take for example IntegrationRuntimes_Start.

The swagger states this operation returns IntegrationRuntimeStatusResponse.
The IntegrationRuntimeStatusResponse object has properties of type IntegrationRuntimeStatus.
However if we look at IntegrationRuntimeStatus, it has two type properties - one is a reference to an enum, the other is an optional object in the response. Because of the ordering, only the second one is being recognized, so all examples that use the type property with the enum value 'Managed' are being found as errors.
And finally, if we look at the example response body, there is a typeProperties field that is not in the specification for this object.

Another common error in the above examples seems to be the use of 'S1' as a value for the 'catalogPricingTier' enum, when the only valid values are "Basic", "Standard", "Premium", "PremiumRS".

zhangyd2015 · 2018-05-27T14:23:50Z

@annatisch All the model validation errors have been fixed.

annatisch · 2018-05-29T14:33:12Z

Thanks @zhangyd2015 - the PR looks good to me. Once @ravbhatnagar signs off on the new ARM APIs then we're good to go :)

hvermis · 2018-05-31T02:17:16Z

...tafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/datafactory.json

@@ -375,6 +375,99 @@
        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/sharedFactory": {
+      "post": {


The operation name should be an action, it should contain a verb since it is post.

hvermis · 2018-05-31T02:18:28Z

...tafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/datafactory.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/sharedIntegrationRuntime": {


Same here. Unless you want to model them as sub resources, then it should be plural. But I prefer action here.

annatisch · 2018-06-12T03:13:12Z

@ravbhatnagar - are you able to sign-off on the changes made?

annatisch · 2018-06-12T03:14:13Z

@hvermis - can you confirm whether your feedback has all been addressed?

ravbhatnagar · 2018-06-12T18:25:13Z

we should be able to close this today. Apologies for the delay here but not an expert on msi so wanted to make sure the right thing is being done here.

zhangyd2015 · 2018-06-15T05:23:02Z

@ravbhatnagar I've renamed the API "grantAccess/revokeAccess" as your suggestion.

ravbhatnagar · 2018-06-20T18:25:50Z

Looks good as per discussion on skype. These are getting added to preview api version. When ARM enables support for listing child resources at a higher scope, these APis will be replaced with that. At that point, there wont be a need for /addIdentity and removeIdentity Apis also. Signing off for now.

annatisch · 2018-06-20T19:33:00Z

Thanks @zhangyd2015 and @ravbhatnagar
There's one further ARM violation in the linter CI:

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/integrationRuntimes/{integrationRuntimeName}
has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response."

Is it possible to correct this at this point?

hvermis · 2018-06-20T19:52:04Z

@annatisch that violation is a breaking change and we are fixing it in our new API version

annatisch · 2018-06-20T19:53:56Z

Thanks @hvermis! @ravbhatnagar - do you approve my adding a suppression for this?

annatisch · 2018-06-25T18:27:57Z

ping @ravbhatnagar

zhangyd2015 · 2018-06-26T01:07:12Z

@annatisch Since this issue is not a regression introduced by this pull request, can we just merge this pull request and track this issue in separate thread?

annatisch · 2018-06-26T01:09:22Z

Thanks @zhangyd2015 - yes I'm happy to do that for the linter error.
However currently CI is failing due to Autorest crashing that I'm trying to diagnose - I will forward you the email conversation.

hvermis · 2018-06-26T01:59:28Z

@zhangyd2015 Now that we have new API version out, this change should go there instead of 09-01. Can you please move it?

zhangyd2015 · 2018-06-26T02:23:45Z

@annatisch Please hold on the PR merge, I will let you know when we are ready to do that.
Thanks!

annatisch · 2018-06-26T02:44:26Z

Sure thing @zhangyd2015.
I had a chat offline and we thing the cause of the broken CI is this line here:
https://github.com/Azure/azure-rest-api-specs/pull/3124/files#diff-bf6d272fbfeeed92d1fc24a2bb8706a8R3218

We think the x-ms-client-flatten extension should be removed here because:

This extension should not be combined with polymorphic models.
This will be a breaking change for generated SDKs
This extension probably shouldn't be used where additional parameters exist alongside the flattened parameters - although we have no firm guidance on this.

Is there a particular reason you chose to flatten these properties? (i.e. the linter tool suggested it).
Otherwise could you try removing it? Hopefully that will fix the build.

hvermis · 2018-06-28T19:50:19Z

@annatisch @zhangyd2015 Flattening is added to make authoring easier for our customers. Remove additionalProperties if you have to, as that property is there to keep any future properties that older SDK version doesn't know about, and doesn't help in all cases anyway because of polymorphic limitations.

zhangyd2015 · 2018-06-29T01:40:30Z

Thanks @annatisch and @hvermis.

If you select the option "Hide whitespace changes" in "Diff settings", you can find "x-ms-client-flatten" is not introduced in this PR, it should be there for long time.

For additionalProperties, it is not only used for future properties, but also works for list properties. If we remove it, the model validation will be broken somehow.

annatisch · 2018-06-29T17:30:11Z

Thanks @zhangyd2015 and @hvermis -
It turns out I was mistaken about the location of the invalid line.
It is actually these four locations on the models:

These models are all polymorphic and the x-ms-client-flatten extension cannot be combined with polymorphic models. Could these statements be removed?

hvermis · 2018-06-29T21:13:33Z

@annatisch, @zhangyd2015 We should not remove flatten directives. Instead remove the additionalProeprties from property classes and this will be fixed. I added those additionalProperties, but they never worked as I wanted.

annatisch · 2018-06-29T21:23:24Z

@hvermis - unfortunately in this case the additionalProperties are not the issue. Polymorphic models should not be flattened.

zhangyd2015 · 2018-07-02T13:56:52Z

@annatisch, @hvermis, @ravbhatnagar Thanks for the help. We've decided not implementing the preview API, and waiting for the official implementation from ARM level. So I will abandon this PR and create new PR on GA version (version 2018-06-01).

Thank you guys a lot!

annatisch · 2018-07-02T14:19:14Z

Thanks @zhangyd2015 - I will close it.
When you submit the PR for the GA version you can reference this one to streamline the review :)

AutorestCI · 2018-07-02T14:27:59Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2136

Add APIs for integration runtime sharing feature.

5dc066e

Add two fields 'pushedVersion' 'latestVersion' into SelfHostedIntegrationRuntimeStatus Fixed issue #2057

azuresdkci assigned annatisch May 23, 2018

azuresdkci requested a review from annatisch May 23, 2018 05:05

zhangyd2015 commented May 23, 2018

View reviewed changes

AutorestCI mentioned this pull request May 23, 2018

[AutoPR datafactory/resource-manager] Add APIs for integration runtime sharing feature. Azure/azure-sdk-for-python#2611

Closed

AutorestCI mentioned this pull request May 23, 2018

[AutoPR datafactory/resource-manager] Add APIs for integration runtime sharing feature. AutorestCI/azure-libraries-for-java#188

Open

zhangyd2015 commented May 23, 2018

View reviewed changes

AutorestCI mentioned this pull request May 23, 2018

[AutoPR datafactory/resource-manager] Add APIs for integration runtime sharing feature. Azure/azure-sdk-for-node#2898

Closed

AutorestCI mentioned this pull request May 23, 2018

[AutoPR datafactory/resource-manager] Add APIs for integration runtime sharing feature. Azure/azure-sdk-for-go#1893

Closed

annatisch requested changes May 23, 2018

View reviewed changes

Addming x-ms-pageable extension to Factories_ListSharedIntegrationRun…

4f707d6

…time and Factories_ListSharedFactory

Fixed model validation errors

26be99a

annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 24, 2018

Fixed Factories_ConfigureFactoryRepo model validation error.

d7d3e98

Fixed model validation errors

8431d68

fix selfhosted ir status

fbec41e

hvermis reviewed May 31, 2018

View reviewed changes

hvermis approved these changes Jun 13, 2018

View reviewed changes

zhangyd2015 added 2 commits June 13, 2018 17:59

Add back additionalProperties into IntegrationRuntime

284b4b5

Rename API grantAccess/revokeAccess to addIdentity/removeIdentity

203234b

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 20, 2018

annatisch closed this Jul 2, 2018

AutorestCI mentioned this pull request Jul 2, 2018

[AutoPR datafactory/resource-manager] Add APIs for integration runtime sharing feature. Azure/azure-sdk-for-java#2168

Closed

zhangyd2015 mentioned this pull request Jul 3, 2018

[ADF v2]Add integration runtime sharing feature. #3345

Merged

10 tasks

Add APIs for integration runtime sharing feature. #3124

Add APIs for integration runtime sharing feature. #3124

Conversation

zhangyd2015 commented May 23, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented May 23, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 23, 2018 • edited Loading

Automation for azure-libraries-for-java

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented May 23, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 23, 2018 • edited Loading

Automation for azure-sdk-for-go

annatisch commented May 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented May 24, 2018 • edited Loading

Automation for azure-sdk-for-ruby

zhangyd2015 commented May 24, 2018

annatisch commented May 24, 2018 • edited Loading

zhangyd2015 commented May 25, 2018

annatisch commented May 25, 2018 • edited Loading

zhangyd2015 commented May 27, 2018

annatisch commented May 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annatisch commented Jun 12, 2018

annatisch commented Jun 12, 2018

ravbhatnagar commented Jun 12, 2018 • edited Loading

zhangyd2015 commented Jun 15, 2018

ravbhatnagar commented Jun 20, 2018

annatisch commented Jun 20, 2018

hvermis commented Jun 20, 2018

annatisch commented Jun 20, 2018

annatisch commented Jun 25, 2018

zhangyd2015 commented Jun 26, 2018

annatisch commented Jun 26, 2018

hvermis commented Jun 26, 2018

zhangyd2015 commented Jun 26, 2018

annatisch commented Jun 26, 2018

hvermis commented Jun 28, 2018

zhangyd2015 commented Jun 29, 2018

annatisch commented Jun 29, 2018

hvermis commented Jun 29, 2018

annatisch commented Jun 29, 2018

zhangyd2015 commented Jul 2, 2018

annatisch commented Jul 2, 2018

AutorestCI commented Jul 2, 2018 • edited Loading

Automation for azure-sdk-for-java

zhangyd2015 commented May 23, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 23, 2018 •

edited

Loading

AutorestCI commented May 23, 2018 •

edited

Loading

AutorestCI commented May 23, 2018 •

edited

Loading

AutorestCI commented May 23, 2018 •

edited

Loading

AutorestCI commented May 24, 2018 •

edited

Loading

annatisch commented May 24, 2018 •

edited

Loading

annatisch commented May 25, 2018 •

edited

Loading

ravbhatnagar commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jul 2, 2018 •

edited

Loading