Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new property SegmentCount to SMSReceived Event #31764

Merged
merged 14 commits into from
Jan 16, 2025
Merged

Added new property SegmentCount to SMSReceived Event #31764

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bf58b3a
Added new property SegmentCount to SMSReceived Event
grangasamy-msft Dec 4, 2024
7251407
Adding bug fixes
grangasamy-msft Dec 6, 2024
12c3905
Space Bug fix
grangasamy-msft Dec 6, 2024
9345587
Correcting Typo mistake
grangasamy-msft Dec 10, 2024
04aa399
Changing segmentCount to required parameter
grangasamy-msft Dec 18, 2024
e8327a7
replaced the json files back to the original content
grangasamy-msft Dec 20, 2024
7879cf0
Adding required parameter to AzureComm json file.
grangasamy-msft Jan 6, 2025
3aef3de
removing timestamp as required parameter
grangasamy-msft Jan 6, 2025
76d0a21
code fix
grangasamy-msft Jan 6, 2025
c58a2fb
reverting json
grangasamy-msft Jan 6, 2025
5677019
Pulling the latest main
grangasamy-msft Jan 6, 2025
4d33dbd
trying to fix package.json
grangasamy-msft Jan 6, 2025
bb99b5e
fixing the json file
grangasamy-msft Jan 6, 2025
553734e
fixes
JoshLove-msft Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...e.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,10 @@ model AcsSmsReceivedEventData extends AcsSmsEventBaseProperties {

/** The time at which the SMS was received */
@madeRequired(ServiceApiVersions.v2024_01_01)
receivedTimestamp: utcDateTime;
receivedTimestamp?: utcDateTime;

/** Number of segments in the message */
segmentCount: int32;
}

//TODO: This might need some fixing
Expand Down
3 changes: 2 additions & 1 deletion ...on/eventgrid/Azure.Messaging.EventGrid.SystemEvents/examples/2018-01-01/sms_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"From": "15555555555",
"To": "15555555555",
"Message": "Great to connect with ACS events",
"ReceivedTimestamp": "2020-09-18T00:27:45.32Z"
"ReceivedTimestamp": "2020-09-18T00:27:45.32Z",
"SegmentCount": 1
},
"specversion": "1.0",
"operationId": "SMSReceivedEventName",
Expand Down
3 changes: 2 additions & 1 deletion ...on/eventgrid/Azure.Messaging.EventGrid.SystemEvents/examples/2024-01-01/sms_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"From": "15555555555",
"To": "15555555555",
"Message": "Great to connect with ACS events",
"ReceivedTimestamp": "2020-09-18T00:27:45.32Z"
"ReceivedTimestamp": "2020-09-18T00:27:45.32Z",
"SegmentCount": 1
},
"specversion": "1.0",
"operationId": "SMSReceivedEventName",
Expand Down
10 changes: 9 additions & 1 deletion ...grid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement 

Brownfield services will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.
"swagger": "2.0",
"info": {
"version": "2018-01-01",
Expand Down Expand Up @@ -1357,8 +1357,16 @@
"description": "The time at which the SMS was received",
"format": "date-time",
"type": "string"
},
"segmentCount": {
"description": "Number of segments in the message",
"format": "int32",
"type": "integer"
}
}
},
"required": [
"segmentCount"
]
},
"AcsRecordingFileStatusUpdatedEventData": {
"description": "Schema of the Data property of an EventGridEvent for a Microsoft.Communication.RecordingFileStatusUpdated event.",
Expand Down
3 changes: 2 additions & 1 deletion .../Microsoft.Communication/stable/2018-01-01/examples/cloud-events-schema/sms_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"From": "15555555555",
"To": "15555555555",
"Message": "Great to connect with ACS events",
"ReceivedTimestamp": "2020-09-18T00:27:45.32Z"
"ReceivedTimestamp": "2020-09-18T00:27:45.32Z",
"SegmentCount": 1
},
"specversion": "1.0"
}
3 changes: 2 additions & 1 deletion ...ne/Microsoft.Communication/stable/2018-01-01/examples/event-grid-schema/sms_received.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"From": "15555555555",
"To": "15555555555",
"Message": "Great to connect with ACS events",
"ReceivedTimestamp": "2020-09-18T00:27:45.32Z"
"ReceivedTimestamp": "2020-09-18T00:27:45.32Z",
"SegmentCount": 1
},
"eventType": "Microsoft.Communication.SMSReceived",
"dataVersion": "1.0",
Expand Down
8 changes: 8 additions & 0 deletions ...ion/eventgrid/data-plane/Microsoft.EventGrid/stable/2018-01-01/GeneratedSystemEvents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2429,12 +2429,20 @@
"type": "string",
"format": "date-time",
"description": "The time at which the SMS was received"
},
"segmentCount": {
"type": "integer",
"format": "int32",
"description": "Number of segments in the message"
}
},
"allOf": [
{
"$ref": "#/definitions/AcsSmsEventBaseProperties"
}
],
"required": [
"segmentCount"
]
},
"AcsUserDisconnectedEventData": {
Expand Down
7 changes: 6 additions & 1 deletion ...ion/eventgrid/data-plane/Microsoft.EventGrid/stable/2024-01-01/GeneratedSystemEvents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2482,10 +2482,15 @@
"type": "string",
"format": "date-time",
"description": "The time at which the SMS was received"
},
"segmentCount": {
"type": "integer",
"format": "int32",
"description": "Number of segmensts in the message"
}
},
"required": [
"receivedTimestamp"
"segmentCount"
],
"allOf": [
{
Expand Down
Loading