Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] add nodeResourceGroup property #3203

Merged
merged 3 commits into from
Jun 8, 2018
Merged

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jun 8, 2018

nodeResourceGroup is an optional read-only property returned for a managed cluster by the v20180331 API.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2708

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit d8e6990 into Azure:master Jun 8, 2018
@mboersma mboersma deleted the aks-add-node-rg branch June 8, 2018 22:22
@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp_7_c18cf/rest/specification/containerservices/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp_7_c18cf/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.100', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.100->2.1.100)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-09"} .
FATAL: swagger-document/compose - FAILED
FATAL: Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
).
Process() cancelled due to exception : '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
).
Failure during batch task - {"tag":"package-2017-09"} -- Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
)..
  Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
).

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#174

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2848

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants