Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] Update nodejs config to use 2018-02-preview api-version #3251

Merged
merged 2 commits into from
Jun 18, 2018

Conversation

djyou
Copy link
Member

@djyou djyou commented Jun 15, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2780

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2774

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1390

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@djyou djyou changed the title [ACR] Update default tag to 2018-02-preview [do not merge][ACR] Update default tag to 2018-02-preview Jun 15, 2018
@djyou djyou changed the title [do not merge][ACR] Update default tag to 2018-02-preview [ACR] Update default tag to 2018-02-preview Jun 16, 2018
@@ -7,7 +7,7 @@ Please also specify `--node-sdks-folder=<path to root folder of your azure-sdk-f
nodejs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may consider the following solution without updating the default so that you can limit the chagne to nodejs.

nodejs:
  azure-arm: true
  package-name: azure-arm-containerregistry
  package-version: 2.3.0
  output-folder: $(node-sdks-folder)/lib/services/containerRegistryManagement
  generate-license-txt: true
  generate-package-json: true
  generate-readme-md: true

input-file:
- Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json
- Microsoft.ContainerRegistry/preview/2018-02-01-preview/containerregistry_build.json  

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djyou - I'm ready to sign-off and merge - let me know if you wish to push this suggested change to the nodejs config before I do so :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as suggested. This may however introduce more maintenance confusion though. /cc @daschult

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djyou - does this mean that you only want to publish the Nodejs SDK at this time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since it's a preview version, we will publish the SDK when necessary.

@djyou djyou changed the title [ACR] Update default tag to 2018-02-preview [ACR] Update nodejs config to use 2018-02-preview api-version Jun 18, 2018
@annatisch annatisch merged commit d5e4013 into Azure:master Jun 18, 2018
@djyou djyou deleted the doyou/nodejs branch June 20, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants