Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] Fix list builds odata query #3313

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Conversation

djyou
Copy link
Member

@djyou djyou commented Jun 27, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@djyou
Copy link
Member Author

djyou commented Jun 27, 2018

/cc @northtyphoon @sajayantony

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2780

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2774

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2129

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2146

@marstr
Copy link
Member

marstr commented Jun 27, 2018

Ready for me to merge, @djyou?

On a side note, I'm surprised that you're moving away from an array and to a CSV format. Any reason for the change?

@djyou
Copy link
Member Author

djyou commented Jun 27, 2018

The backend implementation doesn't support odata querying from an array very well so we comprised to using a CSV string instead.

Yes, please merge. Thanks!

@marstr marstr merged commit cce65bc into Azure:master Jun 27, 2018
@djyou djyou deleted the doyou/listbuilds branch June 27, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants