Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] suppress two autorest ARM linter errors #3388

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jul 11, 2018

Suppresses two autorest --azure-validator errors that the AKS swagger currently emits.
cc: @ifeoluwaokunoren @ravbhatnagar @vladimirjoanovic

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 11, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jul 11, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Jul 11, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1487

@AutorestCI
Copy link

AutorestCI commented Jul 11, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2230

@AutorestCI
Copy link

AutorestCI commented Jul 11, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@dsgouda
Copy link
Contributor

dsgouda commented Jul 11, 2018

@mboersma were these suppressions approved, please send an email offline with the approval.

@mboersma mboersma force-pushed the aks-linter-suppression branch from ce2c4f1 to c53de20 Compare July 11, 2018 22:05
@mboersma mboersma changed the title [AKS] suppress ARM linter errors [AKS] suppress two autorest ARM linter errors Jul 11, 2018
@mboersma mboersma force-pushed the aks-linter-suppression branch from c53de20 to 88dddc7 Compare July 12, 2018 01:58
@vladimirjoanovic
Copy link

ARM team approves the 2 suppressed ARM linter errors

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 19450c4 into Azure:master Jul 17, 2018
@mboersma mboersma deleted the aks-linter-suppression branch July 17, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants