Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump logic management Node.js package version to 2.0.0 #3451

Merged
1 commit merged into from
Jul 19, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@ghost ghost self-assigned this Jul 19, 2018
@ghost ghost requested review from amarzavery and RikkiGibson July 19, 2018 16:59
@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2960

@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1496

@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3200

kazrael2119 pushed a commit to kazrael2119/azure-rest-api-specs that referenced this pull request Aug 7, 2024
* `

* `

* Revert "`"

This reverts commit c26fc6a.
danieljurek pushed a commit that referenced this pull request Oct 15, 2024
* `

* `

* Revert "`"

This reverts commit c26fc6a.
danieljurek pushed a commit that referenced this pull request Oct 15, 2024
* `

* `

* Revert "`"

This reverts commit c26fc6a.
danieljurek pushed a commit that referenced this pull request Oct 16, 2024
* `

* `

* Revert "`"

This reverts commit c26fc6a.
danieljurek pushed a commit that referenced this pull request Oct 24, 2024
* `

* `

* Revert "`"

This reverts commit c26fc6a.
danieljurek pushed a commit that referenced this pull request Oct 25, 2024
* `

* `

* Revert "`"

This reverts commit c26fc6a.
danieljurek pushed a commit that referenced this pull request Oct 25, 2024
* `

* `

* Revert "`"

This reverts commit c26fc6a.
danieljurek added a commit that referenced this pull request Oct 25, 2024
* test breaking change mlc in js (#3451)

* `

* `

* Revert "`"

This reverts commit c26fc6a.

* Update specificationRepositoryConfiguration.json (#3457)

* Update specificationRepositoryConfiguration.json (#3459)

* Update specificationRepositoryConfiguration.json (#3462)

Revert python repo branch change as it was deleted.

* Update specificationRepositoryConfiguration.json (#3463)

* Migrate typespec-validation.yml to GH Actions

* path, fetch depth

* Introduce error

* Test a feature that AI says will collapse logs (doubtful it'll work)

* Revert "Test a feature that AI says will collapse logs (doubtful it'll work)"

This reverts commit 04aed83.

* Log $LASTEXITCODE

* Invalid syntax

* Use error logging, remove continue-on-error because that is different behavior in GitHub Actions compared to ignoreLASTEXITCODE

* Errors also get annotations in GitHub Actions

* String replacement

* Revert Logging-Functions.ps1

* Test composite action

* File location

* Invocation

* Add typespec-validation-all.yml

* Migrate typespec-validation-all.yml

* Revert main.tsp invalid spec

* fetch-depth: 2

* Long paths

* checkout@v4

* Remove pipelines

* *.yml -> *.yaml

* Do not change specificationRepositoryConfiguration.json

* Job names (for checks)

* Add Skip/Take logic and matrix

* Syntax

* Rename

* Remove "shell"

* Try defaults.run.shell (unlikely to work)

* bash

* Name for actions/setup-node@v4 does not appear in the logs. Remove.

* Use sharding semantics

* Shard

* Review feedback

* Review feedback

* +1

* Revert "Shard"... Display is confusing because it starts at 0 and doesn't reach total-shards. Math is not allowed in expressions.

This reverts commit 035bec7.

* Shard only if TotalShards > 0

* Remove description (schema validaiton does not pass, let's see what GH Actions says)

* The `description` property is not absolutely required by GH Actions at this time but adding back in because schema requires it.

* Add array functions and tests

* Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they are accurate)

* Add trailing newline

* Add trailing newline

* Update .github/workflows/typespec-validation.yaml

Co-authored-by: Mike Harder <mharder@microsoft.com>

* Review feedback

* Update eng/scripts/TypeSpec-Validation.ps1

Co-authored-by: Mike Harder <mharder@microsoft.com>

---------

Co-authored-by: Wanpeng Li <wanl@microsoft.com>
Co-authored-by: Peng Jiahui <46921893+Alancere@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Ray Chen <raychen@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Oct 29, 2024
* test breaking change mlc in js (Azure#3451)

* `

* `

* Revert "`"

This reverts commit c26fc6a.

* Update specificationRepositoryConfiguration.json (Azure#3457)

* Update specificationRepositoryConfiguration.json (Azure#3459)

* Update specificationRepositoryConfiguration.json (Azure#3462)

Revert python repo branch change as it was deleted.

* Update specificationRepositoryConfiguration.json (Azure#3463)

* Migrate typespec-validation.yml to GH Actions

* path, fetch depth

* Introduce error

* Test a feature that AI says will collapse logs (doubtful it'll work)

* Revert "Test a feature that AI says will collapse logs (doubtful it'll work)"

This reverts commit 04aed83.

* Log $LASTEXITCODE

* Invalid syntax

* Use error logging, remove continue-on-error because that is different behavior in GitHub Actions compared to ignoreLASTEXITCODE

* Errors also get annotations in GitHub Actions

* String replacement

* Revert Logging-Functions.ps1

* Test composite action

* File location

* Invocation

* Add typespec-validation-all.yml

* Migrate typespec-validation-all.yml

* Revert main.tsp invalid spec

* fetch-depth: 2

* Long paths

* checkout@v4

* Remove pipelines

* *.yml -> *.yaml

* Do not change specificationRepositoryConfiguration.json

* Job names (for checks)

* Add Skip/Take logic and matrix

* Syntax

* Rename

* Remove "shell"

* Try defaults.run.shell (unlikely to work)

* bash

* Name for actions/setup-node@v4 does not appear in the logs. Remove.

* Use sharding semantics

* Shard

* Review feedback

* Review feedback

* +1

* Revert "Shard"... Display is confusing because it starts at 0 and doesn't reach total-shards. Math is not allowed in expressions.

This reverts commit 035bec7.

* Shard only if TotalShards > 0

* Remove description (schema validaiton does not pass, let's see what GH Actions says)

* The `description` property is not absolutely required by GH Actions at this time but adding back in because schema requires it.

* Add array functions and tests

* Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they are accurate)

* Add trailing newline

* Add trailing newline

* Update .github/workflows/typespec-validation.yaml

Co-authored-by: Mike Harder <mharder@microsoft.com>

* Review feedback

* Update eng/scripts/TypeSpec-Validation.ps1

Co-authored-by: Mike Harder <mharder@microsoft.com>

---------

Co-authored-by: Wanpeng Li <wanl@microsoft.com>
Co-authored-by: Peng Jiahui <46921893+Alancere@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Ray Chen <raychen@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
haagha pushed a commit that referenced this pull request Nov 19, 2024
* test breaking change mlc in js (#3451)

* `

* `

* Revert "`"

This reverts commit c26fc6a.

* Update specificationRepositoryConfiguration.json (#3457)

* Update specificationRepositoryConfiguration.json (#3459)

* Update specificationRepositoryConfiguration.json (#3462)

Revert python repo branch change as it was deleted.

* Update specificationRepositoryConfiguration.json (#3463)

* Migrate typespec-validation.yml to GH Actions

* path, fetch depth

* Introduce error

* Test a feature that AI says will collapse logs (doubtful it'll work)

* Revert "Test a feature that AI says will collapse logs (doubtful it'll work)"

This reverts commit 04aed83.

* Log $LASTEXITCODE

* Invalid syntax

* Use error logging, remove continue-on-error because that is different behavior in GitHub Actions compared to ignoreLASTEXITCODE

* Errors also get annotations in GitHub Actions

* String replacement

* Revert Logging-Functions.ps1

* Test composite action

* File location

* Invocation

* Add typespec-validation-all.yml

* Migrate typespec-validation-all.yml

* Revert main.tsp invalid spec

* fetch-depth: 2

* Long paths

* checkout@v4

* Remove pipelines

* *.yml -> *.yaml

* Do not change specificationRepositoryConfiguration.json

* Job names (for checks)

* Add Skip/Take logic and matrix

* Syntax

* Rename

* Remove "shell"

* Try defaults.run.shell (unlikely to work)

* bash

* Name for actions/setup-node@v4 does not appear in the logs. Remove.

* Use sharding semantics

* Shard

* Review feedback

* Review feedback

* +1

* Revert "Shard"... Display is confusing because it starts at 0 and doesn't reach total-shards. Math is not allowed in expressions.

This reverts commit 035bec7.

* Shard only if TotalShards > 0

* Remove description (schema validaiton does not pass, let's see what GH Actions says)

* The `description` property is not absolutely required by GH Actions at this time but adding back in because schema requires it.

* Add array functions and tests

* Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they are accurate)

* Add trailing newline

* Add trailing newline

* Update .github/workflows/typespec-validation.yaml

Co-authored-by: Mike Harder <mharder@microsoft.com>

* Review feedback

* Update eng/scripts/TypeSpec-Validation.ps1

Co-authored-by: Mike Harder <mharder@microsoft.com>

---------

Co-authored-by: Wanpeng Li <wanl@microsoft.com>
Co-authored-by: Peng Jiahui <46921893+Alancere@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Ray Chen <raychen@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
* test breaking change mlc in js (Azure#3451)

* `

* `

* Revert "`"

This reverts commit c26fc6a.

* Update specificationRepositoryConfiguration.json (Azure#3457)

* Update specificationRepositoryConfiguration.json (Azure#3459)

* Update specificationRepositoryConfiguration.json (Azure#3462)

Revert python repo branch change as it was deleted.

* Update specificationRepositoryConfiguration.json (Azure#3463)

* Migrate typespec-validation.yml to GH Actions

* path, fetch depth

* Introduce error

* Test a feature that AI says will collapse logs (doubtful it'll work)

* Revert "Test a feature that AI says will collapse logs (doubtful it'll work)"

This reverts commit 04aed83.

* Log $LASTEXITCODE

* Invalid syntax

* Use error logging, remove continue-on-error because that is different behavior in GitHub Actions compared to ignoreLASTEXITCODE

* Errors also get annotations in GitHub Actions

* String replacement

* Revert Logging-Functions.ps1

* Test composite action

* File location

* Invocation

* Add typespec-validation-all.yml

* Migrate typespec-validation-all.yml

* Revert main.tsp invalid spec

* fetch-depth: 2

* Long paths

* checkout@v4

* Remove pipelines

* *.yml -> *.yaml

* Do not change specificationRepositoryConfiguration.json

* Job names (for checks)

* Add Skip/Take logic and matrix

* Syntax

* Rename

* Remove "shell"

* Try defaults.run.shell (unlikely to work)

* bash

* Name for actions/setup-node@v4 does not appear in the logs. Remove.

* Use sharding semantics

* Shard

* Review feedback

* Review feedback

* +1

* Revert "Shard"... Display is confusing because it starts at 0 and doesn't reach total-shards. Math is not allowed in expressions.

This reverts commit 035bec7.

* Shard only if TotalShards > 0

* Remove description (schema validaiton does not pass, let's see what GH Actions says)

* The `description` property is not absolutely required by GH Actions at this time but adding back in because schema requires it.

* Add array functions and tests

* Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they are accurate)

* Add trailing newline

* Add trailing newline

* Update .github/workflows/typespec-validation.yaml

Co-authored-by: Mike Harder <mharder@microsoft.com>

* Review feedback

* Update eng/scripts/TypeSpec-Validation.ps1

Co-authored-by: Mike Harder <mharder@microsoft.com>

---------

Co-authored-by: Wanpeng Li <wanl@microsoft.com>
Co-authored-by: Peng Jiahui <46921893+Alancere@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Ray Chen <raychen@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants