Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Fabric 6.3 REST API specs remove unsupported versions #3472

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

vipul-modi
Copy link

@vipul-modi vipul-modi commented Jul 21, 2018

Added Service Fabric 6.3 REST API specs and removed specs for unsupported versions

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

vipulm-azure-rest-api-specs\specification\servicefabric\data-plane>autorest --validation --csharp --model-validator=true --semantic-validator=true
AutoRest code generation utility [version: 2.0.4280; node: v8.9.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      'C:\Users\vipulm\.autorest\@microsoft.azure_autorest-core@2.0.4280\node_modules\@microsoft.azure\autorest-core\dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.csharp' (~2.2.51->2.2.67)
   Loading AutoRest extension 'oav' (~0.4.20->0.4.61)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.50->2.3.50)

@AutorestCI
Copy link

AutorestCI commented Jul 21, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3002

@AutorestCI
Copy link

AutorestCI commented Jul 21, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jul 21, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2775

@AutorestCI
Copy link

AutorestCI commented Jul 21, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2265

@AutorestCI
Copy link

AutorestCI commented Jul 21, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@vipul-modi vipul-modi closed this Jul 21, 2018
@vipul-modi vipul-modi reopened this Jul 23, 2018
@vipul-modi
Copy link
Author

#sign-off - Please review

@vipul-modi
Copy link
Author

@sarangan12 - Could you please review when you get chance? Please do let me know if you have any questions or comments.

@sarangan12 sarangan12 merged commit f5531e3 into Azure:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants