Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cognitive Services] Update endpoint URL template for LUIS. #3492

Merged
merged 1 commit into from Aug 7, 2018
Merged

[Cognitive Services] Update endpoint URL template for LUIS. #3492

merged 1 commit into from Aug 7, 2018

Conversation

yangyuan
Copy link
Member

@yangyuan yangyuan commented Jul 24, 2018 •
edited by azuresdkci
Loading

Detail background and explainations in here: #3489 Cognitive Services URL template (endpoint)

Please hold for mo-abbas or yshahin or chrimc62 's review.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Jul 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2995

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@yangyuan yangyuan requested a review from mohabghanem July 24, 2018 19:00
@azuresdkci azuresdkci requested a review from marstr July 24, 2018 19:00
@AutorestCI AutorestCI mentioned this pull request Jul 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2302

@yangyuan yangyuan mentioned this pull request Jul 24, 2018
Closed
yshahin
yshahin reviewed Jul 25, 2018
View reviewed changes
.../LUIS/Authoring/stable/v2.0/examples/features/SuccessfulUpdatePatternFeatureInfoRequest.json
@@ -1,6 +1,6 @@
{
"parameters": {
"AzureRegion": "westus",
"Endpoint": "{Endpoint}",
Copy link
Contributor

@yshahin yshahin Jul 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Spacing is not consistent in a lot of the files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple SDKs have this issue. Maybe can do a batch update later.

yshahin
yshahin approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@yshahin yshahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yangyuan
Copy link
Member Author

yangyuan commented Jul 25, 2018 •
edited
Loading

Hi @marstr, we've got a objection from one of the teams. So please hold this PR for now.

@yangyuan yangyuan added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 26, 2018
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yangyuan
Copy link
Member Author

yangyuan commented Aug 2, 2018 •
edited
Loading

Similar to #3505
I am holding this PR for a few days and collect feedbacks in case of back/forth changes.

@yangyuan yangyuan removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 7, 2018
@yangyuan
Copy link
Member Author

yangyuan commented Aug 7, 2018

Hi @marstr, I think we can process this PR now. Please review and merge if looks good.

@marstr marstr merged commit 08ae453 into Azure:master Aug 7, 2018
@mohabghanem mohabghanem mentioned this pull request Aug 7, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstr marstr marstr approved these changes

@yshahin yshahin yshahin approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@mo-abbas mo-abbas Awaiting requested review from mo-abbas

@mohabghanem mohabghanem Awaiting requested review from mohabghanem

Assignees

@marstr marstr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yangyuan @AutorestCI @azuresdkci @yshahin @marstr