-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Release Redisenterprise microsoft.cache 2025 07 01 #35872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Redisenterprise microsoft.cache 2025 07 01 #35872
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2025-05-01-preview to stable/2025-07-01.
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛ |
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
This doesn't even make sense does it? Clusters created with old api versions should still be able to have public network access enabled/disabled can't they? So that people don't need to recreate the cluster to use it the new way? Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/stable/2025-07-01/redisenterprise.json:2118 in bc8813d. [](commit_id = bc8813d, deletion_comment = False) |
My take is this should not really be nullable. People need to know whether public network access is enabled or disabled. Why can't we tell them that, instead of returning null? And why would we want to accept explicit 'null' in a create request? (as opposed to leaving it undefined) Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/stable/2025-07-01/redisenterprise.json:2126 in bc8813d. [](commit_id = bc8813d, deletion_comment = False) |
Just a thought - leaving it named ClusterProperties might be better for backcompat than renaming it to ClusterCreateProperties? Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/stable/2025-07-01/redisenterprise.json:1932 in bc8813d. [](commit_id = bc8813d, deletion_comment = False) |
Also we return it from operations like GET which aren't create operations. In reply to: 3202232049 Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/stable/2025-07-01/redisenterprise.json:1932 in 13a4ad1. [](commit_id = 13a4ad1, deletion_comment = False) |
can we avoid defining the public network access enum twice, and just $ref it from both places? Or do we need separate enums? In reply to: 3202239688 Refers to: specification/redisenterprise/resource-manager/Microsoft.Cache/stable/2025-07-01/redisenterprise.json:2143 in 13a4ad1. [](commit_id = 13a4ad1, deletion_comment = False) |
"resourceState": "Updating", | ||
"redisVersion": "5", | ||
"minimumTlsVersion": "1.2", | ||
"publicNetworkAccess": "Enabled" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we won't allow null in PUT, I had to define because response and request should be same, and in GET response we return null for old caches
@TimLovellSmith yes clusters created with old api versions can set public network access enabled/disabled |
@TimLovellSmith since we are making this as required property, we can't have required in PATCH call |
I basically don't think its a good idea to return 'null' for that. I'd suggest instead: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a concern that using nullable for publicNetworkAccess is inappropriate #resolved
I had a long conversation with the feature team. There are a lot of special extenuating circumstances particular to this API to approve. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.