Added NetworkConfigurationDiagnostic rest API + example #3599

irrogozh · 2018-08-07T18:14:54Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkci · 2018-08-07T18:15:08Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-07T18:27:21Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-08-07T18:32:30Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3154

AutorestCI · 2018-08-07T18:53:56Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3252

AutorestCI · 2018-08-07T19:11:49Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2135

AutorestCI · 2018-08-07T19:18:34Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2469

lmazuel · 2018-08-07T20:15:43Z

Sorry, was the wrong tab, I never meant to close/open the PR :/

MikhailTryakhov · 2018-08-08T16:54:03Z

@irrogozh please don't forget to merge to August branch

…workConfigurationDiagnostic API

ravbhatnagar · 2018-08-14T00:38:40Z

specification/network/resource-manager/Microsoft.Network/stable/2018-06-01/networkWatcher.json

+        "queries"
+      ],
+      "properties": {
+        "targetResourceId": {


what permissions are needed on the target resource to perform the network configuration diagnostic

Probably, read access on NSG.

ravbhatnagar · 2018-08-14T00:39:12Z

specification/network/resource-manager/Microsoft.Network/stable/2018-06-01/networkWatcher.json

+    "NetworkConfigurationDiagnosticResponse": {
+      "description": "Results of network configuration diagnostic on the target resource.",
+      "properties": {
+        "results": {


"value" array is the standard here.

It's not ObjectListPage. Value would be there only in this case...

'results' (as a name for array) was approved by our PMs...

ravbhatnagar · 2018-08-14T00:44:09Z

specification/network/resource-manager/Microsoft.Network/stable/2018-06-01/networkWatcher.json

+            "$ref": "./network.json#/parameters/SubscriptionIdParameter"
+          }
+        ],
+        "responses": {


For all APIs., Model a "default" response to capture all the error states. The schema of this response should comply with ARM RPC error contract. Check Batch RP API spec for a sample.

Done, thank you!

Added NetworkConfigurationDiagnostic rest API + example

6ad7c8a

irrogozh requested a review from MikhailTryakhov as a code owner August 7, 2018 18:14

azuresdkci assigned lmazuel Aug 7, 2018

azuresdkci requested a review from lmazuel August 7, 2018 18:15

AutorestCI mentioned this pull request Aug 7, 2018

[AutoPR network/resource-manager] Added NetworkConfigurationDiagnostic rest API + example Azure/azure-sdk-for-python#3092

Closed

AutorestCI mentioned this pull request Aug 7, 2018

[AutoPR network/resource-manager] Added NetworkConfigurationDiagnostic rest API + example Azure/azure-sdk-for-node#3302

Merged

AutorestCI mentioned this pull request Aug 7, 2018

[AutoPR network/resource-manager] Added NetworkConfigurationDiagnostic rest API + example Azure/azure-sdk-for-java#2305

Merged

lmazuel closed this Aug 7, 2018

lmazuel reopened this Aug 7, 2018

AutorestCI mentioned this pull request Aug 7, 2018

[AutoPR network/resource-manager] Added NetworkConfigurationDiagnostic rest API + example Azure/azure-sdk-for-python#3095

Merged

Removed 'read-only' from queries in NetworkConfigurationDiagnostic API

6909b52

lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 7, 2018

lmazuel requested a review from ravbhatnagar August 7, 2018 21:16

AutorestCI mentioned this pull request Aug 7, 2018

[AutoPR network/resource-manager] Added NetworkConfigurationDiagnostic rest API + example Azure/azure-sdk-for-go#2415

Merged

irrogozh added 3 commits August 10, 2018 10:55

Added long-running-operation-options: final-state-via location to net…

6e6b30b

…workConfigurationDiagnostic API

Added QueryConnectionMonitors API + example

dfeabab

Fixed example name

f12e6b4

ravbhatnagar reviewed Aug 14, 2018

View reviewed changes

irrogozh added 2 commits August 13, 2018 22:40

Added default response to all APIs

00fefeb

Fixed reference to ErrorDetails

9e5daf5

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 15, 2018

irrogozh added 3 commits August 15, 2018 10:54

Fixed response for QueryConnectionMonitors API + fixed example

0858a23

Added properties to ConnectionStateSnapshot

83e3d19

Fixed types for latencies in networkwatcher.json

377e5cc

lmazuel approved these changes Aug 15, 2018

View reviewed changes

lmazuel merged commit eb94056 into Azure:master Aug 15, 2018

lmazuel mentioned this pull request Aug 15, 2018

Added new API to networkwatcher.json and examples #3650

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added NetworkConfigurationDiagnostic rest API + example #3599

Added NetworkConfigurationDiagnostic rest API + example #3599

irrogozh commented Aug 7, 2018

azuresdkci commented Aug 7, 2018

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

lmazuel commented Aug 7, 2018

MikhailTryakhov commented Aug 8, 2018

ravbhatnagar Aug 14, 2018

irrogozh Aug 14, 2018

ravbhatnagar Aug 14, 2018

irrogozh Aug 14, 2018

irrogozh Aug 14, 2018

ravbhatnagar Aug 14, 2018

irrogozh Aug 14, 2018

Added NetworkConfigurationDiagnostic rest API + example #3599

Added NetworkConfigurationDiagnostic rest API + example #3599

Conversation

irrogozh commented Aug 7, 2018

PR information

Quality of Swagger

azuresdkci commented Aug 7, 2018

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-go

lmazuel commented Aug 7, 2018

MikhailTryakhov commented Aug 8, 2018

ravbhatnagar Aug 14, 2018

Choose a reason for hiding this comment

irrogozh Aug 14, 2018

Choose a reason for hiding this comment

ravbhatnagar Aug 14, 2018

Choose a reason for hiding this comment

irrogozh Aug 14, 2018

Choose a reason for hiding this comment

irrogozh Aug 14, 2018

Choose a reason for hiding this comment

ravbhatnagar Aug 14, 2018

Choose a reason for hiding this comment

irrogozh Aug 14, 2018

Choose a reason for hiding this comment

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading