Skip to content

Comments

Convert Dynatrace Swagger to Tsp#36094

Merged
BhanujaAggarwal merged 24 commits intoAzure:mainfrom
mcgallan:Dynatrace-Convert
Nov 10, 2025
Merged

Convert Dynatrace Swagger to Tsp#36094
BhanujaAggarwal merged 24 commits intoAzure:mainfrom
mcgallan:Dynatrace-Convert

Conversation

@mcgallan
Copy link
Member

This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure

Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind.

Please reach out to TypeSpec Discussions Channel if there is any help needed.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 22, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 22, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link

github-actions bot commented Jul 22, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Dynatrace.Observability
TypeSpec Dynatrace.Observability
Go sdk/resourcemanager/dynatrace/armdynatrace
JavaScript @azure/arm-dynatrace
Python azure-mgmt-dynatrace
Java com.azure.resourcemanager:azure-resourcemanager-dynatrace

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager RPaaS TypeSpec Authored with TypeSpec labels Jul 22, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Oct 27, 2025
@pshao25 pshao25 added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk-Approved labels Nov 7, 2025
@pshao25 pshao25 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Nov 7, 2025
@pshao25
Copy link
Member

pshao25 commented Nov 7, 2025

@pshao25 pshao25 closed this Nov 7, 2025
@mcgallan mcgallan reopened this Nov 10, 2025
@pshao25 pshao25 added BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels Nov 10, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 10, 2025
@BhanujaAggarwal BhanujaAggarwal removed the request for review from shivansh257 November 10, 2025 07:41
@BhanujaAggarwal BhanujaAggarwal enabled auto-merge (squash) November 10, 2025 07:42
@BhanujaAggarwal BhanujaAggarwal merged commit d685687 into Azure:main Nov 10, 2025
37 of 41 checks passed
anushkasingh16 pushed a commit to anushkasingh16/azure-rest-api-specs that referenced this pull request Nov 11, 2025
* generated

* update

* update

* update

* update

* update

* update

* update

* fix checkstyle

* resolve breaking

* update

* update

* update

* add location header

---------

Co-authored-by: xiaofeicao <xiaofeicao@microsoft.com>
Co-authored-by: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>
Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com>
Co-authored-by: Bhanuja Aggarwal <Aggarwal.bhanuja@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS rpaas-tsp-conversion TypeSpec Authored with TypeSpec typespec-conversion-w2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants