Microsoft.NetApp first version #3639

grimurjonsson · 2018-08-14T20:46:01Z

Has been previously merged into azure-rest-api-specs-pr: https://github.com/Azure/azure-rest-api-specs-pr/pull/513

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-08-14T20:46:22Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-08-14T20:46:42Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-08-14T20:46:43Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-08-14T20:46:43Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3203

azuresdkci · 2018-08-14T20:50:09Z

Can one of the admins verify this patch?

lmazuel · 2018-08-14T21:16:10Z

specification/netapp/resource-manager/readme.md

+  clear-output-folder: true
+```
+
+## Python


Please split this section into a readme.python.md.
Example:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cdn/resource-manager/readme.python.md

lmazuel · 2018-08-14T21:16:36Z

specification/netapp/resource-manager/readme.md

+```
+
+
+## C#


Please split this section into a readme.csharp.md.
Example:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cdn/resource-manager/readme.csharp.md

lmazuel · 2018-08-14T21:19:57Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

+    "description": "Microsoft NetApp Azure Resource Provider specification",
+    "version": "2017-08-15",
+    "x-ms-code-generation-settings": {
+      "name": "CloudVolumeManagementClient"


Why is that renaming? Shouldn't then rename the package to azure-mgmt-cloudvolume? What is the commercial advertising of this service on https://azure.microsoft.com/en-us/services/ ?

I don't really understand what you mean. If you mean the x-ms-code-generation-settings, then I think I copied that from some document I was pointed out to use as reference. I think it's safe to remove. (I see its not in the cdn.json you're referencing)

x-ms-code-generation-settings/name is the final constructor name in the SDK. So it seemed weird to me to have a package called "netapp", with a constructor called "CloudVolumeManagementClient" :)

Do not remove that node, otherwise the constructor will be called "MicrosoftNetAppClient" which is probably not what you want. Renaming "NetAppManagementClient" I guess makes sense.

Changing to AzureNetAppFilesManagementClient, since thats the name of service on the site you posted.

lmazuel · 2018-08-14T21:21:16Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

+        }
+      ],
+      "get": {
+        "description": "Lists all NetApp accounts in the subscription",


Wrong description since ResourceGroup is a parameter

lmazuel · 2018-08-14T21:24:56Z

specification/netapp/resource-manager/readme.md

+  payload-flattening-threshold: 2
+  namespace: azure.mgmt.netapp
+  package-name: azure-mgmt-netapp
+  package-version: 5.0.0


no reason, changing to 1.0

lmazuel · 2018-08-14T21:26:54Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

+      }
+    },
+    "Operation": {
+      "description": "Storage REST API operation definition.",


Copy/paste issue?

Yes, will fix

lmazuel · 2018-08-14T21:28:09Z

specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json

+          "type": "string",
+          "description": "The origin of operations."
+        },
+        "properties": {


You probably miss a $ref OperationProperties for details here, otherwise this node is interpreted as string (which likely isn't)

AutorestCI · 2018-08-14T22:55:30Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

grimurjonsson · 2018-08-23T19:59:47Z

Ping.

* Remove TrackedResource from Swagger spec "$ref": "../../common/v1/definitions.json#/definitions/TrackedResource" * More updates on referring common types More updates on referring common types * Add UpdateParameters and Updateproperties * Update example * updated example * update examples Introducing new API for Azure Security Center Settings (Azure#3511) * Add new API for Azure Security Center Settings * Changed SettingsPUT API to receive parameter and not definition. * - changed settings parameter name in example and in security parameter definition - changes typo comment on settings get all example reference * changes settings to setting in Settings API * settings kind to setting kind in settings CSM API Update batch resource-manager Node.js package version to 3.1.2 (Azure#3732) IoTHub conf py (Azure#3733) Reports API moved from stable to preview version with addition of documentation of a couple of new APIs (Azure#3640) * Consumption specifications for cost insights and reporting operations * Fixed $ref for ReportConfigDelete * Silly me!! Fixed bad reference again * Fixed schema validation issues * Fixing validation errors around datetime and dynamic respones * Fixed parameters in examples * Fixed parameter name in example * Removed x-ms-odata method for POST op * Fixed ARM review comments * Moved reports and usage analysis from microsoft.consumption to microsoft.costmanagament * Merged with master again * Updated reports api documentation * Undo remove of API from stable version providing description for new introduced property isRecurringCharge fix example issues Microsoft.ResourceGraph public preview spec (Azure#3716) Add new microsoft.logic version (Azure#3683) * Copy of the source version (2016-06-01) to seed the new version (2018-07-01-preview) * Update Microsoft.Logic from 2016-06-01 to 2018-07-01-preview * Remove extra prep files, update the readme Fix Go SDK codegen for containerinstance (Azure#3735) The package-2018-06 tag was incorrecly using the 2018-04 tag. Moved Go SDK config section to its own config file. Microsoft.NetApp first version (Azure#3639) * Microsoft.NetApp first version * Addressing pullrequest comments added back billingperiod

Microsoft.NetApp first version

c82f7e0

AutorestCI mentioned this pull request Aug 14, 2018

[AutoPR netapp/resource-manager] Microsoft.NetApp first version Azure/azure-sdk-for-python#3144

Merged

azuresdkci assigned lmazuel Aug 14, 2018

azuresdkci requested a review from lmazuel August 14, 2018 20:47

lmazuel requested a review from ravbhatnagar August 14, 2018 21:15

lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 14, 2018

lmazuel reviewed Aug 14, 2018

View reviewed changes

Addressing pullrequest comments

51268a3

lmazuel approved these changes Aug 27, 2018

View reviewed changes

lmazuel merged commit fbe5a21 into Azure:master Aug 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft.NetApp first version #3639

Microsoft.NetApp first version #3639

grimurjonsson commented Aug 14, 2018

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

azuresdkci commented Aug 14, 2018

lmazuel Aug 14, 2018

grimurjonsson Aug 14, 2018

lmazuel Aug 14, 2018

grimurjonsson Aug 14, 2018

lmazuel Aug 14, 2018

grimurjonsson Aug 14, 2018

lmazuel Aug 14, 2018 •

edited

Loading

grimurjonsson Aug 14, 2018

lmazuel Aug 14, 2018

grimurjonsson Aug 14, 2018

lmazuel Aug 14, 2018

grimurjonsson Aug 14, 2018

lmazuel Aug 14, 2018

grimurjonsson Aug 14, 2018

lmazuel Aug 14, 2018 •

edited

Loading

grimurjonsson Aug 14, 2018

AutorestCI commented Aug 14, 2018 •

edited

Loading

grimurjonsson commented Aug 23, 2018

		```


		## C#

Microsoft.NetApp first version #3639

Microsoft.NetApp first version #3639

Conversation

grimurjonsson commented Aug 14, 2018

PR information

Quality of Swagger

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Aug 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lmazuel Aug 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lmazuel Aug 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented Aug 14, 2018 • edited Loading

Automation for azure-sdk-for-ruby

grimurjonsson commented Aug 23, 2018

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading

lmazuel Aug 14, 2018 •

edited

Loading

lmazuel Aug 14, 2018 •

edited

Loading

AutorestCI commented Aug 14, 2018 •

edited

Loading