Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebApps - Add ResourceHealthMetadata.json to readme.md for SDK generation #3692

Merged
merged 2 commits into from
Aug 28, 2018

Conversation

nking-1
Copy link

@nking-1 nking-1 commented Aug 21, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2065

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2555

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2218

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3267

@jhendrixMSFT
Copy link
Member

Close then re-open to hopefully fix CI.

@nking-1
Copy link
Author

nking-1 commented Aug 24, 2018

@jhendrixMSFT I made an additional change to fix some problems with the generated SDK. The deleted web app model was not correct in the swagger which broke our APIs in SDKs / Powershell.

Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI to finish.

@panchagnula
Copy link

@jhendrixMSFT , I see that Linter Diff never completes & looking at the details there a some warnings reported. However, we are unable to parse if the new warning from the existing ones - can you help us identify the warning specific to this change? Thank you.

@jhendrixMSFT
Copy link
Member

@panchagnula I spoke with the CI owners about this, it's a known issue that they're working on. In the meantime take a look at the log and search for ResourceHealthMetadata.json to see the warning introduced by this swagger.

@nking-1
Copy link
Author

nking-1 commented Aug 27, 2018

After reviewing the new warnings, I can say we are OK with taking the current swagger as-is. None of the warnings were for critical issues. The devs for those APIs will fix them in the future. The timeline for that dev work is out of scope for our deadlines for the new SDKs, so we'd like to take this swagger update to unblock short-term work.

@jhendrixMSFT jhendrixMSFT merged commit 7941d68 into Azure:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants