-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebApps - Add ResourceHealthMetadata.json to readme.md for SDK generation #3692
Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Close then re-open to hopefully fix CI. |
@jhendrixMSFT I made an additional change to fix some problems with the generated SDK. The deleted web app model was not correct in the swagger which broke our APIs in SDKs / Powershell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for CI to finish.
@jhendrixMSFT , I see that Linter Diff never completes & looking at the details there a some warnings reported. However, we are unable to parse if the new warning from the existing ones - can you help us identify the warning specific to this change? Thank you. |
@panchagnula I spoke with the CI owners about this, it's a known issue that they're working on. In the meantime take a look at the log and search for |
After reviewing the new warnings, I can say we are OK with taking the current swagger as-is. None of the warnings were for critical issues. The devs for those APIs will fix them in the future. The timeline for that dev work is out of scope for our deadlines for the new SDKs, so we'd like to take this swagger update to unblock short-term work. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger