Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added restore deleted apps and get list of deleted apps #3696

Closed
wants to merge 4 commits into from
Closed

added restore deleted apps and get list of deleted apps #3696

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e21541
added restore deleted apps and get list of deleted apps
Aug 21, 2018
f8b1aa1
added hard delete
Aug 22, 2018
6c2f7b1
add parameters
Aug 22, 2018
7689636
JSON valid
lmazuel Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 105 additions & 7 deletions specification/graphrbac/data-plane/stable/1.6/graphrbac.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,104 @@
}
}
},
"/{tenantID}/deletedApplications/{objectId}/restore": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like both of these operations are missing "parameters" definitions and causing semantic failure as seen here: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/418930889#L586

"post": {
"tags": [
"deletedApplications"
],
"operationId": "DeletedApplications_Restore",
"description": "Restores the deleted application in the directory.",
"parameters": [
{
"name": "objectId",
"in": "path",
"required": true,
"type": "string",
"description": "Application object ID."
},
Copy link
Member

@lmazuel lmazuel Aug 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the api version to get apiversion=1.6

          {
            "$ref": "#/parameters/ApiVersionParameter"
          },

{
"$ref": "#/parameters/tenantIDInPath"
}
],
"responses": {
"200": {
"description": "The application was restored successfully.",
"schema": {
"$ref": "#/definitions/Application"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/GraphError"
}
}
}
}
},
"/{tenantID}/deletedApplications": {
"get": {
"tags": [
"deletedApplications"
],
"operationId": "DeletedApplications_Get",
"description": "Gets a list of deleted applications in the directory.",
"parameters": [
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the api version to get apiversion=1.6

          {
            "$ref": "#/parameters/ApiVersionParameter"
          },

"$ref": "#/parameters/tenantIDInPath"
}
],
"responses": {
"200": {
"description": "The applications were retrieved successfully.",
"schema": {
"$ref": "#/definitions/ApplicationListResult"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/GraphError"
}
}
}
}
},
"/{tenantID}/deletedApplications/{applicationObjectId}": {
"delete": {
"tags": [
"Application"
],
"operationId": "Applications_HardDelete",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly the purpose of this operation, the idea is to "purge" deletedApplications and remove for real the application without waiting 30 days. This means the app has to have been deleted before.
If that so, then operationId should be DeletedApplications_Delete

"description": "Hard-delete an application.",
"parameters": [
{
"name": "applicationObjectId",
"in": "path",
"required": true,
"type": "string",
"description": "Application object ID."
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/tenantIDInPath"
}
],
"responses": {
"204": {
"description": "No Content"
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/GraphError"
}
}
}
}
},
"/{tenantID}/applications/{applicationObjectId}": {
"delete": {
"tags": [
Expand Down Expand Up @@ -346,7 +444,7 @@
}
}
}
},
},
"/{tenantID}/applications/{applicationObjectId}/keyCredentials": {
"get": {
"tags": [
Expand Down Expand Up @@ -831,7 +929,7 @@
}
}
}
}
}
},
"/{tenantID}/groups/{objectId}/getMemberGroups": {
"post": {
Expand Down Expand Up @@ -2155,7 +2253,7 @@
{
"$ref": "#/definitions/DirectoryObject"
}
],
],
"properties": {
"appId": {
"type": "string",
Expand Down Expand Up @@ -2233,7 +2331,7 @@
"type": "object"
},
"description": "Request parameters for adding a owner to an application."
},
},
"KeyCredentialListResult": {
"type": "object",
"properties": {
Expand Down Expand Up @@ -2478,7 +2576,7 @@
{
"$ref": "#/definitions/DirectoryObject"
}
],
],
"properties": {
"displayName": {
"type": "string",
Expand Down Expand Up @@ -2617,7 +2715,7 @@
"$ref": "#/definitions/DirectoryObject"
}
],
"type": "object",
"type": "object",
"properties": {
"displayName": {
"type": "string",
Expand Down Expand Up @@ -2818,7 +2916,7 @@
"name": "UserType",
"modelAsString": true
}
},
},
"accountEnabled": {
"type": "boolean",
"description": "Whether the account is enabled."
Expand Down