Add new OsType parameters for Microsoft.Web/availablestacks

[balag0]

No description provided.

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3312

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[AutorestCI]

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2218

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3560

[azuresdkci]

Can one of the admins verify this patch?

[marstr]

I get nervous about extending enum values inside of API Versions for the following reasons:

1. API Versions expose a mechanism for reasoning about availability between regions.
2. While this type already looks to be modeled as a string, applications will need to be retooled to expose/reason about the new options. Without changing API Version, it is hard to build tooling to identify places where the enum list has been updated.

That said, I don't think those grounds are enough to block this or any other individual PR. However, I want to make sure that this conversation is included when considering what changes warrant waiting for an API Version boundary. Better yet, trying to change the culture to one where deploying new API Versions is a lighter-weight, more common operation.

[ravbhatnagar]

Looks good. Signing off from ARM side. Just one minor note - Currently in the response body, i couldnt find a way to know which stack is for Linux or Windows. How do you differentiate that looking at the response. Specially when the filter query parameter is optional so by default in the response both stacks can be present.

[balag0]

The response body will include the type based on the ostype query parameter.
Ex:
Microsoft.Web/availableStacks?osTypeSelected=Linux
Microsoft.Web/availableStacks?osTypeSelected=Windows

if the query parameter is skipped it is implicitly assumed to be Windows and only Windows stacks will be returned.

[naveedaz]

Are there any more concerns? Can we merge this PR?

[marstr]

Talked offline with @naveedaz, merging now.