Add Service Association Link and IP Configuration Profiles on Subnet #3840

Flip-Liquid · 2018-09-07T22:10:30Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-09-07T22:23:45Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3302

azuresdkci · 2018-09-07T22:32:01Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-08T00:31:38Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-09-08T01:26:11Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: go generate ./profiles/...
Finished with return code 1
and output:

[STATUS] Output-Location set to:
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/storage/mgmt/storage/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/network/mgmt/network/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/compute/mgmt/compute/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/keyvault/keyvault/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/keyvault/mgmt/keyvault/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/features/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/links/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/locks/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/policy/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/subscriptions/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/resources/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] 11 packages generated.
[STATUS] Output-Location set to:
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/advisor/mgmt/advisor/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/analysisservices/mgmt/analysisservices/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[ERROR] path 'github.com/Azure/azure-sdk-for-go/services/appinsights/v1/insights' does not resemble a known package path
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/apimanagement/mgmt/apimanagement/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/appinsights/mgmt/insights/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/authorization/mgmt/authorization/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/automation/mgmt/automation/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/azsadmin/mgmt/infrastructureinsights/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/azsadmin/mgmt/fabric/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/batch/batch/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/batch/mgmt/batch/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/batchai/mgmt/batchai/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/computervision/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/contentmoderator/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/customsearch/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/entitysearch/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/face/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/imagesearch/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/luis/programmatic/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/luis/runtime/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/newssearch/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/spellcheck/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/textanalytics/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/videosearch/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/websearch/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/mgmt/cognitiveservices/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/compute/mgmt/compute/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/containerservice/mgmt/containerservice/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/consumption/mgmt/consumption/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/containerregistry/mgmt/containerregistry/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/containerservice/mgmt/containerservice/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cosmos-db/mgmt/documentdb/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/customerinsights/mgmt/customerinsights/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/datacatalog/mgmt/datacatalog/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/datalake/analytics/catalog/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/datalake/analytics/job/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/datalake/analytics/mgmt/account/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/datalake/store/filesystem/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/datalake/store/mgmt/account/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/provisioningservices/mgmt/iothub/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/devtestlabs/mgmt/dtl/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/dns/mgmt/dns/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/domainservices/mgmt/aad/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/eventgrid/eventgrid/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/eventgrid/mgmt/eventgrid/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/eventhub/mgmt/eventhub/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/graphrbac/graphrbac/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/iothub/mgmt/devices/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/keyvault/mgmt/keyvault/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/keyvault/keyvault/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/logic/mgmt/logic/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/machinelearning/mgmt/webservices/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/marketplaceordering/mgmt/marketplaceordering/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/mediaservices/mgmt/media/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/mobileengagement/mgmt/mobileengagement/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/mysql/mgmt/mysql/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/network/mgmt/network/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/notificationhubs/mgmt/notificationhubs/models.go
[ERROR] path 'github.com/Azure/azure-sdk-for-go/services/operationalinsights/v1/operationalinsights' does not resemble a known package path
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/operationalinsights/mgmt/operationalinsights/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/postgresql/mgmt/postgresql/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/powerbidedicated/mgmt/powerbidedicated/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/powerbiembedded/mgmt/powerbiembedded/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/recoveryservices/mgmt/recoveryservices/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/recoveryservices/mgmt/backup/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/recoveryservices/mgmt/siterecovery/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/redis/mgmt/redis/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/relay/mgmt/relay/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/reservations/mgmt/reservations/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resourcehealth/mgmt/resourcehealth/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/features/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/locks/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/policy/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/resources/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/subscriptions/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/links/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/scheduler/mgmt/scheduler/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/search/mgmt/search/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/servicebus/mgmt/servicebus/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/servicefabric/servicefabric/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/servicefabric/mgmt/servicefabric/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/sql/mgmt/sql/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/storage/mgmt/storage/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/storageimportexport/mgmt/storageimportexport/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/storsimple8000series/mgmt/storsimple/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/streamanalytics/mgmt/streamanalytics/models.go
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/timeseriesinsights/mgmt/timeseriesinsights/models.go
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/trafficmanager/mgmt/trafficmanager/models.go
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Success formatting profile.
[STATUS] Writing File: /tmp/tmp2orx8bw2/src/github.com/Azure/azure-sdk-for-go/profiles/latest/web/mgmt/web/models.go
[STATUS] Success formatting profile.
[STATUS] 87 packages generated.
# command-line-arguments
fatal error: runtime: out of memory

runtime stack:
runtime.throw(0x64b1d4, 0x16)
	/usr/local/go/src/runtime/panic.go:608 +0x72
runtime.sysMap(0xc008000000, 0x4000000, 0x7f9fd8)
	/usr/local/go/src/runtime/mem_linux.go:156 +0xc7
runtime.(*mheap).sysAlloc(0x7e1560, 0x4000000, 0x431bdc, 0xc000000300)
	/usr/local/go/src/runtime/malloc.go:619 +0x1c7
runtime.(*mheap).grow(0x7e1560, 0x1, 0x0)
	/usr/local/go/src/runtime/mheap.go:920 +0x42
runtime.(*mheap).allocSpanLocked(0x7e1560, 0x1, 0x7f9fe8, 0x400)
	/usr/local/go/src/runtime/mheap.go:848 +0x337
runtime.(*mheap).alloc_m(0x7e1560, 0x1, 0x22, 0x7f419b11bfff)
	/usr/local/go/src/runtime/mheap.go:692 +0x119
runtime.(*mheap).alloc.func1()
	/usr/local/go/src/runtime/mheap.go:759 +0x4c
runtime.(*mheap).alloc(0x7e1560, 0x1, 0x7f419b010022, 0x7f419b1aac28)
	/usr/local/go/src/runtime/mheap.go:758 +0x8a
runtime.(*mcentral).grow(0x7e3118, 0x0)
	/usr/local/go/src/runtime/mcentral.go:232 +0x94
runtime.(*mcentral).cacheSpan(0x7e3118, 0x7f419b1aac28)
	/usr/local/go/src/runtime/mcentral.go:106 +0x2f8
runtime.(*mcache).refill(0x7f419d5dc6c0, 0xc00052c122)
	/usr/local/go/src/runtime/mcache.go:122 +0x95
runtime.(*mcache).nextFree.func1()
	/usr/local/go/src/runtime/malloc.go:749 +0x32
runtime.systemstack(0x0)
	/usr/local/go/src/runtime/asm_amd64.s:351 +0x66
runtime.mstart()
	/usr/local/go/src/runtime/proc.go:1229

goroutine 1 [running]:
runtime.systemstack_switch()
	/usr/local/go/src/runtime/asm_amd64.s:311 fp=0xc00052bf38 sp=0xc00052bf30 pc=0x454a90
runtime.(*mcache).nextFree(0x7f419d5dc6c0, 0x4b5322, 0xc007c18cf0, 0x22, 0xc007ab952f)
	/usr/local/go/src/runtime/malloc.go:748 +0xb6 fp=0xc00052bf90 sp=0xc00052bf38 pc=0x40b0f6
runtime.mallocgc(0x100, 0x636520, 0xc00052c401, 0x0)
	/usr/local/go/src/runtime/malloc.go:903 +0x793 fp=0xc00052c030 sp=0xc00052bf90 pc=0x40ba43
runtime.newobject(0x636520, 0x22)
	/usr/local/go/src/runtime/malloc.go:1032 +0x38 fp=0xc00052c060 sp=0xc00052c030 pc=0x40be28
cmd/link/internal/objfile.(*objReader).readSym(0xc00052c4f0)
	/usr/local/go/src/cmd/link/internal/objfile/objfile.go:249 +0x61a fp=0xc00052c260 sp=0xc00052c060 pc=0x516b5a
cmd/link/internal/objfile.(*objReader).loadObjFile(0xc00052c4f0)
	/usr/local/go/src/cmd/link/internal/objfile/objfile.go:127 +0x460 fp=0xc00052c448 sp=0xc00052c260 pc=0x515df0
cmd/link/internal/objfile.Load(0x7cec20, 0xc000502000, 0xc00050b5a0, 0xc007c7e9c0, 0x177ed, 0xc007f7f540, 0x4a)
	/usr/local/go/src/cmd/link/internal/objfile/objfile.go:69 +0x1c4 fp=0xc00052c618 sp=0xc00052c448 pc=0x5157a4
cmd/link/internal/ld.ldobj(0xc000508000, 0xc00050b5a0, 0xc007c7e9c0, 0x17857, 0xc007f7f540, 0x4a, 0xc000501840, 0x42, 0x0)
	/usr/local/go/src/cmd/link/internal/ld/lib.go:1534 +0xc90 fp=0xc00052c8d0 sp=0xc00052c618 pc=0x5726b0
cmd/link/internal/ld.loadobjfile(0xc000508000, 0xc007c7e9c0)
	/usr/local/go/src/cmd/link/internal/ld/lib.go:846 +0x4d9 fp=0xc00052ca88 sp=0xc00052c8d0 pc=0x56c009
cmd/link/internal/ld.(*Link).loadlib(0xc000508000)
	/usr/local/go/src/cmd/link/internal/ld/lib.go:361 +0x16a fp=0xc00052cce8 sp=0xc00052ca88 pc=0x5688da
cmd/link/internal/ld.Main(0x7cec20, 0x10, 0x20, 0x1, 0x7, 0x10, 0x64cd8e, 0x1b, 0x649ed2, 0x14, ...)
	/usr/local/go/src/cmd/link/internal/ld/main.go:207 +0xa2d fp=0xc00052ce80 sp=0xc00052cce8 pc=0x58214d
main.main()
	/usr/local/go/src/cmd/link/main.go:65 +0x227 fp=0xc00052df98 sp=0xc00052ce80 pc=0x5da0f7
runtime.main()
	/usr/local/go/src/runtime/proc.go:201 +0x207 fp=0xc00052dfe0 sp=0xc00052df98 pc=0x42ba67
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1333 +0x1 fp=0xc00052dfe8 sp=0xc00052dfe0 pc=0x4569f1
profiles/preview/generate.go:17: running "go": exit status 2

AutorestCI · 2018-09-08T01:58:06Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-09-08T02:52:47Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpi87_x9xs/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpi87_x9xs/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@^2.1.43']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.79)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

dsgouda

Looks good apart from a few comments

dsgouda · 2018-09-07T22:34:32Z

specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/virtualNetwork.json

@@ -823,6 +824,48 @@
    }
  },
  "definitions": {
+    "ServiceAssociationLinkFormat": {


A better name would be ServiceAssociationLinkProperties

Sure, will change this to ServiceAssociationLinkPropertiesFormat, since this appears to be the pattern in the rest of the file.

dsgouda · 2018-09-10T16:44:37Z

...icrosoft.Network/stable/2018-08-01/examples/VirtualNetworkGetWithServiceAssociationLink.json

+		"virtualNetworkName": "test-vnet"
+	},
+	"responses": {
+		"200": {


nit: replace tab with 2 spaces and indent

Could you clarify? Do you mean tab == 2 spaces (as opposed to 4)? These are already spaces, not tabs.

Yep, 2 space tabs instead of 4

dsgouda · 2018-09-10T16:45:10Z

specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/virtualNetwork.json

+          "$ref": "#/definitions/ServiceAssociationLinkFormat",
+          "description": "Resource navigation link properties format."
+        },
+        "name": {


Please check if this is readonly

The name of the service association link should not be marked as read only

dsgouda

LGTM subject to CIs passing

* Trusted Root certificate (#3668) * Rebased master to monthly network branch (#3687) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Update dns management Node.js version number to 3.0.0 (#3675) * Update batchai Node.js package version to 2.0.2 (#3664) * Update nofiticationhubs management Node.js package version to 2.0.0 (#3665) * WebApps - Add BackupName to backup API models (#3560) * WebApps - Add BackupName to replace non-ARM-compliant Name property on Backup API models * Revert breaking change to BackupItem. BackupItemName property will be fine in place of BackupName for now. * Update authorization management Node.js package version to 5.0.1 (#3676) * Update storagesync management Node.js package version to 1.0.0 (#3677) * add checknameavailability (#3608) * add checknameavailability * move checkname parameter to definition section * fix brackets * fix parameter name in checknameavailability exanple * update code owners for PowerBIDedicated * New Batch data plane API version 2018-08-01.7.0 (#3657) * Add new batch version 2018-08-01.7.0 * Update the new API * Fix up output from OAD, it does not output valid JSON * update OAV (#3678) * Update storage management Node.js package version to 5.2.0 (#3679) * Update compute.json and disk.json for some issues and add zone and rolling upgrade. (#3642) * Breaking change tool correctly handles multiple files with same name * Fix to breaking changes table generation * Trusted Root certificate (#3668) * Updated Microsoft.Network version to 2018-08-01 (#3672) * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * Added AddressPrefixes on Subnet properties (#3714) * Added address prefixes to subnet * Added example of multiple address prefixes. * Python Network conf 2018-08-01 * Changes to include required properties for outbound rule (#3728) * Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change * Fix Python 2018-08 conf * Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes #3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example * Azure Firewall FQDN Tag top level resource (#3744) * Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation * Vtapfinal (#3684) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme * Azure Firewall NAT Rule Collection (#3745) * NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages * Do not allow ICMP as Network protocol (#3742) * Adding linkedResourceType and hostedWorkloads to nic (#3780) * Adding support for interface endpoints (#3783) * Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources * Added Trusted root certificate changes to new API version (#3731) * Add ExpressRoute gateway resource (#3776) * Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments. * Adding support for delegations on a subnet (#3805) * Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure * Correct issues for SDK generation (#3818) * Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions. * Rename TargetUrls to TargetFqdns (#3739) * Add Network Profile swagger and examples (#3806) * add network profile swagger and examples * add x-ms-client-flatten property as per feedback * appease travis by fixing model + examples * vtapswaggerupdate (#3837) * Add Service Association Link and IP Configuration Profiles on Subnet (#3840) * add service association links for virtual network * add ipconfig profiles on subnet * fixed example issue * Review for tabfix and properties fromat rename * Vtap swagger update and made the property as readonly (#3845) * vtapswaggerupdate * Adding readonly property * Updated AppGW Autoscale Configuration (#3838) * VPN gateway new API for Reset VPN client PSK (#3800) * Brooklyn Ignite Swagger changes (#3715) * Brooklyn Ignite Swagger changes * Add missing example file changes * Add virtual hub route table * Fix travis build error * VPN profile bugfix * Fix casing for NRP automapping * Fix parsing errors * remove BgpSettings from P2SVpnGateway object * Added AddressPrefixes on Subnet properties (#3714) * Added address prefixes to subnet * Added example of multiple address prefixes. * Python Network conf 2018-08-01 * Changes to include required properties for outbound rule (#3728) * Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change * Fix Python 2018-08 conf * Fix swagger contract errors with NRP * Fix network swagger * Fix virtualHub Properties for SDK and PS JSON serializer compliance * Fix bugs * Changing Cortex swagger to match NRP * Bug fixes * bugFix3 * Bug fix * Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes #3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example * Azure Firewall FQDN Tag top level resource (#3744) * Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation * Vtapfinal (#3684) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme * Azure Firewall NAT Rule Collection (#3745) * NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages * Do not allow ICMP as Network protocol (#3742) * Adding linkedResourceType and hostedWorkloads to nic (#3780) * Adding support for interface endpoints (#3783) * Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources * Added Trusted root certificate changes to new API version (#3731) * Add ExpressRoute gateway resource (#3776) * Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments. * Adding support for delegations on a subnet (#3805) * Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure * Correct issues for SDK generation (#3818) * Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions. * Rename TargetUrls to TargetFqdns (#3739) * Fix travis errors in examples * Fixed error examples for P2S cortex resources * Fix swagger * Fix Semantic validation error * network swagger fix * Fix travis * Fix travis errors * Revert version change * Dummy changes for CI restart * Swagger changes (#3857) * Relocated readOnly property * Readded provisioning state to interfaceEndpoint.json * Updated networkInterface.json * Updated serviceEndpointPolicy.json * Update virtualNetworkTap.json * Fix semantic issue * Multiple changes * More example fixes * Dummy commit * Fixed duplicate * changes to swagger in interface endpoints and subnet delegation (#3860) * Revert "Trusted Root certificate (#3668)" This reverts commit 3ff4b52. * fixed api version in azure firewall example * Review comments incorporation (#3859)

add service association links for virtual network

26e8a0c

Flip-Liquid requested a review from MikhailTryakhov as a code owner September 7, 2018 22:10

Flip-Liquid changed the title ~~Add Service Association Link on Subnet~~ Add Service Association Link and IP Configuration Profiles on Subnet Sep 7, 2018

add ipconfig profiles on subnet

4a663e4

AutorestCI mentioned this pull request Sep 7, 2018

[AutoPR network/resource-manager] Add Service Association Link on Subnet Azure/azure-sdk-for-python#3302

Merged

azuresdkci assigned dsgouda Sep 7, 2018

azuresdkci requested a review from dsgouda September 7, 2018 22:32

fixed example issue

aa04ea5

AutorestCI mentioned this pull request Sep 8, 2018

[AutoPR network/resource-manager] Add Service Association Link and IP Configuration Profiles on Subnet Azure/azure-sdk-for-node#3548

Closed

dsgouda suggested changes Sep 10, 2018

View reviewed changes

Review for tabfix and properties fromat rename

1b9baca

dsgouda approved these changes Sep 10, 2018

View reviewed changes

dsgouda merged commit c60ac4a into Azure:Network-September-Release Sep 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Service Association Link and IP Configuration Profiles on Subnet #3840

Add Service Association Link and IP Configuration Profiles on Subnet #3840

Flip-Liquid commented Sep 7, 2018

AutorestCI commented Sep 7, 2018 •

edited

Loading

azuresdkci commented Sep 7, 2018

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

dsgouda left a comment

dsgouda Sep 7, 2018

Flip-Liquid Sep 10, 2018

dsgouda Sep 10, 2018

Flip-Liquid Sep 10, 2018

dsgouda Sep 10, 2018

dsgouda Sep 10, 2018

Flip-Liquid Sep 10, 2018

dsgouda left a comment

Add Service Association Link and IP Configuration Profiles on Subnet #3840

Add Service Association Link and IP Configuration Profiles on Subnet #3840

Conversation

Flip-Liquid commented Sep 7, 2018

PR information

Quality of Swagger

AutorestCI commented Sep 7, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Sep 7, 2018

AutorestCI commented Sep 8, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Sep 8, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Sep 8, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Sep 8, 2018 • edited Loading

Automation for azure-sdk-for-node

dsgouda left a comment

Choose a reason for hiding this comment

dsgouda Sep 7, 2018

Choose a reason for hiding this comment

Flip-Liquid Sep 10, 2018

Choose a reason for hiding this comment

dsgouda Sep 10, 2018

Choose a reason for hiding this comment

Flip-Liquid Sep 10, 2018

Choose a reason for hiding this comment

dsgouda Sep 10, 2018

Choose a reason for hiding this comment

dsgouda Sep 10, 2018

Choose a reason for hiding this comment

Flip-Liquid Sep 10, 2018

Choose a reason for hiding this comment

dsgouda left a comment

Choose a reason for hiding this comment

AutorestCI commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading

AutorestCI commented Sep 8, 2018 •

edited

Loading