Bringing conformance to the Disk version used in root tags.

[marstr]

@dashult discovered the discrepancy between the tags package-2018-06 and package-2018-06-exclude-gallery. The difference is causing the modeler to choke on duplicate type definitions for the TypeScript and Node.js generators.

This is related to #3854

---

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3669

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[azuresdkci]

Can one of the admins verify this patch?

[marstr]

The missing examples causing the linter step of CI to fail should have been introduced by @carissasun in PR #3854.

@carissasun, would you like to add those examples and push them to my branch, or shall I open an issue to track getting them added?

[lmazuel]

@marstr That's funny, because if you look at the linter of #3854, it's clean:
https://github.com/Azure/azure-rest-api-specs/runs/17100940

[marstr]

That's funny, because if you look at the linter of #3854, it's clean

@lmazuel, it's because the default tag (package-2018-06-exclude-gallery) didn't include any references to disk at the updated API Version. :) The linter didn't run over any tag that included that file, so it didn't notice the missing examples.

[carissasun]

What's the problem here? I built the project on my local branch and the build didn't complain

[marstr]

@carissasun says:
What's the problem here? I built the project on my local branch and the build didn't complain

The build wouldn't be a problem, but the linter will complain that we lose test coverage of this API. The linter was only executing over the default tag, package-2018-06-exclude-gallery; therefore before this PR it was using the old API Version of disk for testing. When I upgraded the version of disk, the linter discovered that the examples for disk 2018-06-01 are missing and should have been included in #3854.

[hyonholee]

@marstr Could you also update the default tag from package-2018-06-exclude-gallery to package-2018-06
? Now gallery is public preview, and we want to add gallery to official client library.

[marstr]

@hyonholee, want me to just remove package-2018-06-exclude-gallery all together? We believe that the C# library is the only one using it, so if we move the default tag, exclude-gallery will become unused and just another thing to maintain.

[hyonholee]

@marstr Actually, the default tag is just updated by another PR. You can ignore my previous comment. Thanks.

[marstr]

I'm going to go ahead and merge this PR. However, the examples should be added at some point.

[AutorestCI]

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js