Updated comments and introduced AvailabilitySetSkuType … #3971

robhat1 · 2018-09-20T19:03:46Z

Updated comments and introduced AvailabilitySetSkuType to help users use predefined constants for specifying the name of Availability Set SKU.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…use predefined constants

AutorestCI · 2018-09-20T19:04:23Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmpxanh4vot/rest/specification/compute/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpxanh4vot/azure-sdk-for-js', '--typescript', '--use=@microsoft.azure/autorest.typescript@2.0.516']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4286/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4286)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (2.0.516->2.0.516)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'StorageAccountTypes' and different values: Standard_LRS,Premium_LRS,StandardSSD_LRS,UltraSSD_LRS vs. Standard_LRS,Premium_LRS,StandardSSD_LRS
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in c:\publish\autorest.modeler\src\ObjectBuilder.cs:line 150
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in c:\publish\autorest.modeler\src\SchemaBuilder.cs:line 217
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in c:\publish\autorest.modeler\src\SchemaBuilder.cs:line 48
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in c:\publish\autorest.modeler\src\SchemaBuilder.cs:line 133
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in c:\publish\autorest.modeler\src\SchemaBuilder.cs:line 133
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in c:\publish\autorest.modeler\src\SwaggerModeler.cs:line 348
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in c:\publish\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in c:\publish\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: typescript/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
  Error: Plugin imodeler1 reported failure.

azuresdkci · 2018-09-20T19:04:58Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-20T19:07:44Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-09-20T19:13:58Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3383

AutorestCI · 2018-09-20T19:31:44Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

jhendrixMSFT · 2018-09-20T19:36:19Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

@@ -4312,6 +4312,18 @@
      },
      "description": "The instance view of a resource."
    },
+    "AvailabilitySetSkuType": {


I don't see this referenced anywhere, is that expected?

Yes, the main idea is to provide a set of constants to the users to specify possible values for skuName while creating Availability Set.

Unfortunately we had used the same SKU object at different places and it does not mean the same when used in context of an AvailabilitySet as compared to VMScaleSet or in GetSKUs APIs. Hence this is just to help customers to tell them what are the possible values when creating an Availability Set.

So these values go in the Sku.Name field? I don't think adding a new type that isn't referenced is the best way to solve this, isn't updating the description sufficient?

No it is not. We don't want users to guess the values and type anything random in there. Do you any side-effect of having it? It seems more helpful than just have comments.

Sorry I should have rephrased that, since this type isn't referenced the code generators throw it away. If you look at some of the generated PRs you'll see that AvailabilitySetSkuType isn't added to the models. So since you can't update the models the best you can do is update the docs.

I had checked the generated C# code. It shows up as a static class with 2 string variables there.

Interesting, it doesn't appear for other languages. @fearthecowboy can you comment on this?

Ugh nevermind I was looking at the wrong SDK PR.

AutorestCI · 2018-09-20T19:36:52Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmp32ew_3wk/rest/specification/compute/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp32ew_3wk/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.99']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.99->2.1.99)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'StorageAccountTypes' and different values: Standard_LRS,Premium_LRS,StandardSSD_LRS,UltraSSD_LRS vs. Standard_LRS,Premium_LRS,StandardSSD_LRS
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\ObjectBuilder.cs:line 147
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 217
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 48
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 133
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 133
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SwaggerModeler.cs:line 310
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: nodejs/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
  Error: Plugin imodeler1 reported failure.

AutorestCI · 2018-09-20T19:38:03Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2780

Updated comments and introduced AvailabilitySetSkuType to help users …

ad369e6

…use predefined constants

azuresdkci assigned jhendrixMSFT Sep 20, 2018

azuresdkci requested a review from jhendrixMSFT September 20, 2018 19:04

AutorestCI mentioned this pull request Sep 20, 2018

[AutoPR compute/resource-manager] Updated comments and introduced AvailabilitySetSkuType … Azure/azure-sdk-for-python#3394

Merged

jhendrixMSFT reviewed Sep 20, 2018

View reviewed changes

AutorestCI mentioned this pull request Sep 20, 2018

[AutoPR compute/resource-manager] Updated comments and introduced AvailabilitySetSkuType … Azure/azure-sdk-for-go#2779

Merged

jhendrixMSFT approved these changes Sep 21, 2018

View reviewed changes

jhendrixMSFT merged commit be88f66 into Azure:master Sep 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated comments and introduced AvailabilitySetSkuType … #3971

Updated comments and introduced AvailabilitySetSkuType … #3971

robhat1 commented Sep 20, 2018

AutorestCI commented Sep 20, 2018 •

edited

Loading

azuresdkci commented Sep 20, 2018

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

jhendrixMSFT Sep 20, 2018

robhat1 Sep 20, 2018 •

edited

Loading

robhat1 Sep 20, 2018

jhendrixMSFT Sep 20, 2018

robhat1 Sep 20, 2018

jhendrixMSFT Sep 20, 2018

robhat1 Sep 20, 2018

jhendrixMSFT Sep 20, 2018

jhendrixMSFT Sep 21, 2018

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

Updated comments and introduced AvailabilitySetSkuType … #3971

Updated comments and introduced AvailabilitySetSkuType … #3971

Conversation

robhat1 commented Sep 20, 2018

PR information

Quality of Swagger

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-js

azuresdkci commented Sep 20, 2018

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-java

Choose a reason for hiding this comment

robhat1 Sep 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

robhat1 Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading