Front Door publicpreview #3973

jmelvinwork · 2018-09-20T20:20:04Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Front Door public preview

jmelvinwork · 2018-09-20T20:20:44Z

@keburek

AutorestCI · 2018-09-20T20:20:52Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-09-20T20:20:55Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3410

AutorestCI · 2018-09-20T20:21:49Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-09-20T20:22:17Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-09-20T20:23:30Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-09-20T20:23:59Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

specification/frontdoor/resource-manager/readme.nodejs.md

azuresdkci · 2018-09-20T20:42:18Z

Can one of the admins verify this patch?

jmelvinwork · 2018-09-20T21:20:10Z

This was signed off in the internal repo already.

KrisBash

Sign off from ARM

jmelvinwork · 2018-09-21T16:32:10Z

@lmazuel Can you please review this today? We want to get this merged ASAP

@dashult requested that his review be dismissed offline, because he committed to fixing it himself later.

jmelvinwork · 2018-09-21T17:04:23Z

The linter says the following:
_Potential new ARM errors

R3023 - OperationsAPIImplementation
Operations API must be implemented for '/providers/Microsoft.Network/operations'.
at specification/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/webapplicationfirewall.json:36_

But we are using NRP's Microsoft.Network/operations API, which is defined under /network/...
How do we fix this error?

…tions/ API Add suppression for operationsAPIImplementation as we use NRP's operations/ API

…i-specs into frontdoor-public-preview

jmelvinwork · 2018-09-21T18:34:16Z

The linter says the following:

Potential new ARM errors
R3023 - OperationsAPIImplementation
Operations API must be implemented for '/providers/Microsoft.Network/operations'.
at specification/frontdoor/resource-manager/Microsoft.Network/preview/2018-08-01-preview/webapplicationfirewall.json:36

But we are using NRP's Microsoft.Network/operations API, which is defined under /network/...
How do we fix this error?

Laurent helped me out. Thanks, Laurent!

jmelvinwork · 2018-09-21T18:36:33Z

Did not mean to close PR! Sorry

Fix typo

Fix indentation

lmazuel · 2018-09-21T20:17:33Z

vim.exe.stackdump

@@ -0,0 +1,19 @@
+Stack trace:


Please remove that file.

...or/resource-manager/Microsoft.Network/preview/2018-08-01-preview/webapplicationfirewall.json

WebApplicationFirewallPolicy Swagger did not contain the return value ResourceState.

lmazuel · 2018-09-21T22:09:21Z

@jmelvinwork My last fixes fixed the CLI, and I think it's what you intended. Merging the PR since you told me you want it merge today.
Still, you own this, please double-check my commits and let me know if you have any concerns. Ideally, let me know if you don't have concerns too :)
Thanks!

jmelvinwork and others added 2 commits September 20, 2018 13:12

Front Door public preview

0c6b09f

Front Door public preview

Merge pull request #1 from jmelvinwork/frontdoor-public-preview

9a15da0

Front Door public preview

AutorestCI mentioned this pull request Sep 20, 2018

[AutoPR frontdoor/resource-manager] Front Door publicpreview Azure/azure-sdk-for-python#3396

Closed

AutorestCI mentioned this pull request Sep 20, 2018

[AutoPR frontdoor/resource-manager] Front Door publicpreview Azure/azure-sdk-for-node#3658

Closed

AutorestCI mentioned this pull request Sep 20, 2018

[AutoPR frontdoor/resource-manager] Front Door publicpreview Azure/azure-sdk-for-go#2781

Merged

ghost suggested changes Sep 20, 2018

View reviewed changes

specification/frontdoor/resource-manager/readme.nodejs.md Show resolved Hide resolved

specification/frontdoor/resource-manager/readme.nodejs.md Show resolved Hide resolved

specification/frontdoor/resource-manager/readme.nodejs.md Show resolved Hide resolved

azuresdkci assigned lmazuel Sep 20, 2018

azuresdkci requested a review from lmazuel September 20, 2018 20:42

KrisBash approved these changes Sep 20, 2018

View reviewed changes

KrisBash added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 20, 2018

ghost previously approved these changes Sep 21, 2018

View reviewed changes

jmelvinwork added 2 commits September 21, 2018 11:32

Add suppression for operationsAPIImplementation as we use NRP's opera…

edcfd78

…tions/ API Add suppression for operationsAPIImplementation as we use NRP's operations/ API

Merge branch 'master' of https://github.com/jmelvinwork/azure-rest-ap…

622f362

…i-specs into frontdoor-public-preview

jmelvinwork closed this Sep 21, 2018

jmelvinwork reopened this Sep 21, 2018

AutorestCI mentioned this pull request Sep 21, 2018

[AutoPR frontdoor/resource-manager] Front Door publicpreview Azure/azure-sdk-for-python#3403

Merged

AutorestCI mentioned this pull request Sep 21, 2018

[AutoPR frontdoor/resource-manager] Front Door publicpreview Azure/azure-sdk-for-node#3668

Merged

jmelvinwork added 2 commits September 21, 2018 12:32

Fix typo

fce79d7

Fix typo

Fix indentation

18ea849

Fix indentation

lmazuel requested changes Sep 21, 2018

View reviewed changes

jmelvinwork and others added 2 commits September 21, 2018 13:58

Fix resourceState in definition

3f60c25

WebApplicationFirewallPolicy Swagger did not contain the return value ResourceState.

Fix resourceState case

43b2263

lmazuel approved these changes Sep 21, 2018

View reviewed changes

Delete vim.exe.stackdump

1635ed3

lmazuel merged commit 5682ce2 into Azure:master Sep 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Front Door publicpreview #3973

Front Door publicpreview #3973

jmelvinwork commented Sep 20, 2018

jmelvinwork commented Sep 20, 2018

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

azuresdkci commented Sep 20, 2018

jmelvinwork commented Sep 20, 2018

KrisBash left a comment

jmelvinwork commented Sep 21, 2018

jmelvinwork commented Sep 21, 2018

jmelvinwork commented Sep 21, 2018

The linter says the following:

jmelvinwork commented Sep 21, 2018

lmazuel Sep 21, 2018

lmazuel commented Sep 21, 2018

Front Door publicpreview #3973

Front Door publicpreview #3973

Conversation

jmelvinwork commented Sep 20, 2018

PR information

Quality of Swagger

jmelvinwork commented Sep 20, 2018

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Sep 20, 2018

jmelvinwork commented Sep 20, 2018

KrisBash left a comment

Choose a reason for hiding this comment

jmelvinwork commented Sep 21, 2018

jmelvinwork commented Sep 21, 2018

The linter says the following: _Potential new ARM errors

jmelvinwork commented Sep 21, 2018

The linter says the following:

jmelvinwork commented Sep 21, 2018

lmazuel Sep 21, 2018

Choose a reason for hiding this comment

lmazuel commented Sep 21, 2018

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

The linter says the following:
_Potential new ARM errors