Skip to content

Improving AKS TypeSpec definitions - reduce size of common models#40221

Merged
FumingZhang merged 1 commit intomainfrom
fuming/aks-typespec-improvements-p2-v2
Feb 14, 2026
Merged

Improving AKS TypeSpec definitions - reduce size of common models#40221
FumingZhang merged 1 commit intomainfrom
fuming/aks-typespec-improvements-p2-v2

Conversation

@FumingZhang
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Improving AKS TypeSpec definitions - reduce size of common models

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.ContainerService
Go sdk/resourcemanager/containerservice/armcontainerservice
Java com.azure.resourcemanager:azure-resourcemanager-containerservice-generated
JavaScript @azure/arm-containerservice
Python azure-mgmt-containerservice

matthchr
matthchr previously approved these changes Feb 6, 2026
@FumingZhang FumingZhang force-pushed the fuming/aks-typespec-improvements-p2-v2 branch from 936c80f to ce18c5c Compare February 9, 2026 07:42
@FumingZhang FumingZhang marked this pull request as ready for review February 10, 2026 05:23
@FumingZhang FumingZhang requested a review from palma21 as a code owner February 10, 2026 05:23
@FumingZhang FumingZhang changed the base branch from fuming/aks-typespec-improvements-p2 to main February 10, 2026 05:23
@FumingZhang FumingZhang dismissed matthchr’s stale review February 10, 2026 05:23

The base branch was changed.

@github-actions github-actions bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 10, 2026
@FumingZhang FumingZhang added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Feb 10, 2026
@FumingZhang
Copy link
Member Author

/azp run

@FumingZhang FumingZhang enabled auto-merge (squash) February 10, 2026 05:57
@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@gary-x-li gary-x-li added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 13, 2026
@FumingZhang FumingZhang force-pushed the fuming/aks-typespec-improvements-p2-v2 branch from ce18c5c to 0ab04b9 Compare February 14, 2026 03:03
@FumingZhang FumingZhang merged commit e7ba92f into main Feb 14, 2026
41 checks passed
@FumingZhang FumingZhang deleted the fuming/aks-typespec-improvements-p2-v2 branch February 14, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Container Service PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants