Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network october release #4040

Merged
merged 12 commits into from
Oct 30, 2018
Merged

Network october release #4040

merged 12 commits into from
Oct 30, 2018

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Sep 28, 2018

No description provided.

irrogozh and others added 5 commits September 14, 2018 10:48
@irrogozh @lmazuel
Updated NetworkConfigurationDiagnostic API + example (#3905)
4b3ae81
@anton-evseev @jianghaolu
Fix incorrect API versions in Network's examples (#3954)
d5b22d7 
* Fixed incorrect API versions in 2018-08-01's examples Added missing example for serviceEndpointPolicy.json

* Fixed incorrect API version in 2018-07-01 example
@azhao155 @jianghaolu
swagger change for application gateway waf global config and exclusio…
69fc43d 
…n list (#3972)

* swagger change for application gateway waf global config and exclusion list

* address the comments
@KaiChiLin @jianghaolu
add customer error spec for Application Gateway (#3985)
26fc76c 
* add customer error spec for Application Gateway

* fix property name issue
@fanymanea @dsgouda
Add ICMP to the list of supported protocols (#3993)
3820caa
@lmazuel lmazuel added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 28, 2018
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#357

@AutorestCI AutorestCI mentioned this pull request Sep 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Sep 28, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3463

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmptlrdf6y1/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmptlrdf6y1/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.103']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.103->2.1.103)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

@AutorestCI AutorestCI mentioned this pull request Sep 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2565

@AutorestCI AutorestCI mentioned this pull request Sep 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#3174

@KaiChiLin @jianghaolu
change appgw custom error status code enum and fix a typo of customEr…
a6ea587 
…rorConfigurations (#4050)

* add customer error spec for Application Gateway

* fix property name issue

* change appgw custom error status code enum and fix a typo of customErrorConfiguration
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@srividyathirumala @sergey-shandar
Add ExpressRoutePort swagger (#4104)
758c143 
* Add ExpressRoutePort details to readme.md

* ExpressRoutePort swagger

* Refer SubscriptionIdParameter and ApiVersionParameter from network.json
@MikhailTryakhov
Copy link
Contributor

@lmazuel LGTM, re-ran failed job, now looks ready to be merged

MikhailTryakhov
MikhailTryakhov suggested changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to wait until NRP 109 will be deployed in national clouds

@anton-evseev @dsgouda
Cherry pick NRP's changes from master to October branch (#4251)
6c4312e 
* Remove error code from swagger (#4103)

* Modifying example templates : enabling Ipv6 support for Private Peering (#4232)

* Modifying example templates : enabling Ipv6 support for Private Peering

* Resolving oav validation error
@jianghaolu
Copy link
Contributor

@MikhailTryakhov Please let me know when this can be merged. Thanks!

khannarhea and others added 2 commits October 29, 2018 12:32
@khannarhea @sergey-shandar
Changes to add operation id for outbound rules (#4320)
e8f2b49 
* Changes to add operation id for outbound rules

* Changes to make outbound rule similar to load balancing rule

* fix failures - add example json files

* fix failures

* Fixed line endings, specs, examples
@wdehrich @lmazuel
Change one parameter (#4339)
b5843bc 
* Change parameter in most recent version

* Fix example
MikhailTryakhov
MikhailTryakhov approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be merged

@MikhailTryakhov MikhailTryakhov removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 30, 2018
@MikhailTryakhov
Copy link
Contributor

@jianghaolu please merge

@lmazuel lmazuel merged commit bc2b135 into master Oct 30, 2018
This was referenced Oct 30, 2018
Merged
Closed
Closed
@jianghaolu
Copy link
Contributor

@AutorestCI regenerate azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Nov 6, 2018
Closed
@salameer salameer deleted the network-october-release branch February 20, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikhailTryakhov MikhailTryakhov MikhailTryakhov approved these changes

@jianghaolu jianghaolu jianghaolu approved these changes

Assignees

@jianghaolu jianghaolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.