Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parameter enableMultipleWriteLocations in Cosmos DB #4041

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

shurd
Copy link
Contributor

@shurd shurd commented Sep 29, 2018

To support multi-master, we are adding the parameter enableMultipleWriteLocations to the DatabaseAccountCreateUpdateParameters property so that users can enable this feature when creating an account.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 29, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 29, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2781

@AutorestCI
Copy link

AutorestCI commented Sep 29, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 29, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2445

@AutorestCI
Copy link

AutorestCI commented Sep 29, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3751

@AutorestCI
Copy link

AutorestCI commented Sep 29, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2890

@hovsepm
Copy link
Contributor

hovsepm commented Oct 1, 2018

@shurd please fix Model Validator errors:

>>>>> Files changed in this PR are as follows:
specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/cosmos-db.json
specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/examples/CosmosDBDatabaseAccountCreateMulti.json
>>>> Number of swaggers found in this PR: 1
>>>>> Files deleted in this PR are as follows:
[]
Validating "examples" and "x-ms-examples" in  specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/cosmos-db.json:
 error : 
operationId: DatabaseAccounts_OfflineRegion
scenario: CosmosDBDatabaseAccountOfflineRegion
source: request
responseCode: ALL
severity: 0
errorCode: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
errorDetails:
  code: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
  id: OAV105
  message: >-
    In operation "DatabaseAccounts_OfflineRegion", parameter
    regionParameterForOffline is required in the swagger spec but is not present
    in the provided example parameter values.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''
 error : 
operationId: DatabaseAccounts_OnlineRegion
scenario: CosmosDBDatabaseAccountOnlineRegion
source: request
responseCode: ALL
severity: 0
errorCode: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
errorDetails:
  code: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
  id: OAV105
  message: >-
    In operation "DatabaseAccounts_OnlineRegion", parameter
    regionParameterForOnline is required in the swagger spec but is not present
    in the provided example parameter values.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''

@hovsepm hovsepm merged commit 69f9b36 into Azure:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants