Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Bus: moved VNet and IpFilter rules from 2018-preview to 2017 API version #4245

Merged
merged 5 commits into from
Oct 17, 2018
Merged

Service Bus: moved VNet and IpFilter rules from 2018-preview to 2017 API version #4245

merged 5 commits into from
Oct 17, 2018

Conversation

v-Ajnava
Copy link
Member

@v-Ajnava v-Ajnava commented Oct 16, 2018 •
edited
Loading

2018-preview : ARM approved PR - #3754

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from lmazuel October 16, 2018 21:25
@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3633

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#213

This was referenced Oct 16, 2018
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3887

@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3052

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@v-Ajnava
Copy link
Member Author

2018-preview : ARM approved PR - #3754

@lmazuel
Copy link
Member

lmazuel commented Oct 16, 2018

@v-Ajnava could you take a look at the few issues the CI has on this file (even if nto introduced by this very PR)?
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/442392929

Let me know what you think, thanks!

@v-Ajnava
Copy link
Member Author

@lmazuel , I looked in to it, but including the 'type' missing property in spec will generate ARM error. I have removed the 'type' from example. 'type' for the DisasterRecoveryConfig is a readonly with only one enum value as 'MetadataReplication' '(in future we will be having different replication type). we will fix the RP by changing the name of property and than introduce in swagger.

lmazuel
lmazuel approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lmazuel lmazuel merged commit 41ebc86 into Azure:master Oct 17, 2018
v-Ajnava pushed a commit to v-Ajnava/azure-rest-api-specs that referenced this pull request Oct 24, 2018
Revert "Service Bus: moved VNet and IpFilter rules from 2018-preview …
5609359 
…to 2017 API version (Azure#4245)"

This reverts commit 41ebc86.

# Conflicts:
#	specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json
@v-Ajnava v-Ajnava mentioned this pull request Oct 24, 2018
Merged
10 tasks
annatisch pushed a commit that referenced this pull request Oct 29, 2018
@annatisch
Service Bus: Revert PR 4245 from 2017 (#4323)
6e127e6 
* Revert "Service Bus: moved VNet and IpFilter rules from 2018-preview to 2017 API version (#4245)"

This reverts commit 41ebc86.

# Conflicts:
#	specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

* lint fixes

* lint fix
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@nagiesek
flatten resources for AzureStackHCI (#4245)
047fe57 
* flatten resources

* more flattening

* further flattening

* more flattening

* more flattening
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

Assignees

@lmazuel lmazuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-Ajnava @AutorestCI @azuresdkci @lmazuel