-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new api-version for Azure SignalR service #4329
Conversation
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-nodeUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-jsUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-rubyUnable to detect any generation context from this PR. |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juniwang please reorganize your PR in a way that it will have 2 commits. First one would be simply copy of the existing base version. Second would be all the changes. In that way we will be able to see diff and review.
Automation for azure-sdk-for-javaUnable to detect any generation context from this PR. |
…sion preview/2021-04-01-preview (#4369) * [Hub Generated] Review request for Microsoft.MobileNetwork to add version preview/2021-04-01-preview (#4303) * msazuredev/12524 merge sim and simProfile * fix duplicated example warning * Remove spurious mobile network Sims_ListByMobileNetwork operation (#4317) * Dev mobilenetwork microsoft.mobile network 2021 04 01 preview 6452 (#4329) * mobile network name pattern after confirmed with Fiona * iccid, imsi, ki and opc code pattern * make sim examples comply with patterns * Update mobileNetwork.json (#4319) * Update mobileNetwork.json * Create SimIdListByNetwork.json * Rename SimIdListByNetwork.json to SimIdListByMobileNetwork.json Co-authored-by: jiandongcui <85569904+jiandongcui@users.noreply.github.com> * fix examples for deleted sims field in mobile network * resolve r2063 * resolve lint error * resolve more lint error * prettier fix format * examples in 2021-04-01 should use api-version 2021-04-01-preview * Add Go multi-api section Co-authored-by: nickweeds2 <80526218+nickweeds2@users.noreply.github.com> Co-authored-by: samaddip <66083466+samaddip@users.noreply.github.com> Co-authored-by: Sathiyan Sivathas <sathiyan.sivathas@microsoft.com>
Azure SignalR Service is adding a new api-version
2018-10-01
since we already went GA. However there is no new API comparing to the spec for2018-03-01-preview
. We only changed the version in readme files, spec and examples.Quality control:
All validations documented at https://github.com/Azure/adx-documentation-pr/wiki/Azure-Swagger-Tools passed.