Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Devtestlabs/2018-09-15 #4357

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Add Devtestlabs/2018-09-15 #4357

merged 4 commits into from
Oct 31, 2018

Conversation

jviau
Copy link

@jviau jviau commented Oct 30, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

This PR adds devtestlabs/2018-09-15 stable release. This swagger has already been reviewed and approved here: https://github.com/Azure/azure-rest-api-specs-pr/pull/579.

jviau
jviau commented Oct 30, 2018
View reviewed changes
specification/devtestlabs/resource-manager/readme.go.md Outdated
@@ -35,3 +36,13 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s
``` yaml $(tag) == 'package-2015-05-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/devtestlabs/mgmt/2015-05-21-preview/$(namespace)
```


### Tag: package-2018-09 and go
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is new from the already reviewed and approved PR. I was not sure if I had to add it or not. Let me know if it should be reverted.

jviau
jviau commented Oct 30, 2018
View reviewed changes
specification/devtestlabs/resource-manager/readme.ruby.md Outdated
@@ -24,3 +25,13 @@ Please also specify `--ruby-sdks-folder=<path to the root directory of your azur
namespace: "Azure::DevTestLabs::Mgmt::V2016_05_15"
output-folder: $(ruby-sdks-folder)/management/azure_mgmt_devtestlabs/lib
```

### Tag: package-2018-09 and ruby
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is new from the already reviewed and approved PR. I was not sure if I had to add it or not. Let me know if it should be reverted.

@azuresdkci azuresdkci requested a review from hovsepm October 30, 2018 16:54
@AutorestCI AutorestCI mentioned this pull request Oct 30, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3724

@AutorestCI AutorestCI mentioned this pull request Oct 30, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1839

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 30, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#368

@AutorestCI AutorestCI mentioned this pull request Oct 30, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3191

@AutorestCI AutorestCI mentioned this pull request Oct 30, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3995

@AutorestCI AutorestCI mentioned this pull request Oct 30, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2553

@hovsepm
Copy link
Contributor

hovsepm commented Oct 30, 2018

@jviau please rework you PR in a way that first commit is a copy of the existing swagger with the new name and folder structure and the second commit is update with you changes. Otherwise it is not clear what was changed since the last version.

@ryansbenson ryansbenson added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 30, 2018
ryansbenson
ryansbenson approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jviau jviau force-pushed the devtestlabs/2018-09-15 branch from c0b9171 to 6af1914 Compare October 30, 2018 18:04
@jviau
Copy link
Author

jviau commented Oct 30, 2018

@hovsepm sorry, thought that was only needed for the review PR. I have reworked the commits as requested now.

@hovsepm hovsepm closed this Oct 30, 2018
@hovsepm hovsepm reopened this Oct 30, 2018
This was referenced Oct 30, 2018
Merged
Merged
@hovsepm
Copy link
Contributor

hovsepm commented Oct 30, 2018

  • tag: package-2016-05

Is there any specific reason Java multi-api does not contain the new API version?

Refers to: specification/devtestlabs/resource-manager/readme.md:146 in 6af1914. [](commit_id = 6af1914, deletion_comment = False)

This was referenced Oct 30, 2018
Merged
Merged
@jviau
Copy link
Author

jviau commented Oct 30, 2018

@hovsepm thank you for catching that. I have added it.

@lmazuel
Copy link
Member

lmazuel commented Oct 30, 2018

@AutorestCI rebuild azure-sdk-for-java

@jviau
Copy link
Author

jviau commented Oct 31, 2018

Anything else I need to do before this can be merged in?

@hovsepm hovsepm merged commit eae1345 into Azure:master Oct 31, 2018
@jviau
Copy link
Author

jviau commented Oct 31, 2018

@hovsepm thank you for merging this in! For getting the .NET nuget updated and published: do I do that, or is that done for me?

@jviau jviau deleted the devtestlabs/2018-09-15 branch October 31, 2018 22:26
@hovsepm
Copy link
Contributor

hovsepm commented Oct 31, 2018

For .NEt you will need to create a PR from this swagger to https://github.com/Azure/azure-sdk-for-net repository. Refer to the readme.md file there.

@jviau jviau mentioned this pull request Oct 31, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansbenson ryansbenson ryansbenson approved these changes

@hovsepm hovsepm hovsepm approved these changes

Assignees

@hovsepm hovsepm

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jviau @AutorestCI @azuresdkci @hovsepm @lmazuel @ryansbenson