Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly add MongoDbTasks.json to 2018-07-15 #4358

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Explicitly add MongoDbTasks.json to 2018-07-15 #4358

merged 2 commits into from
Nov 2, 2018

Conversation

vchske
Copy link
Contributor

@vchske vchske commented Oct 30, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@vchske vchske requested a review from hitenjava as a code owner October 30, 2018 19:39
@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3475

@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#387

@vchske
Copy link
Contributor Author

vchske commented Oct 30, 2018

Changes to Mongo classes aren't being recreated in SDK generation because MongoDbTasks.json isn't explicitly being called out as needing to be looked at. What's happening is that most of the Mongo classes are mentioning other classes (base classes) which are explicitly called out (e.g. Commands.json). I am told that a fix will be made in the future to more accurately walk up the tree. But in the meantime, in order for some of these changes to be recognized by autorest this json file needs to be explicitly mentioned.

@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4009

@AutorestCI
Copy link

AutorestCI commented Oct 30, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@vchske
Copy link
Contributor Author

vchske commented Nov 1, 2018

@praries880 Could I ask when this merge might be able to take place? We are blocked on CLI development until the auto SDK generation creates some classes not generated without this edit to our readme.md. Thank you for any help with this.

@praries880 praries880 merged commit 301939d into Azure:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants