Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove security contact phone field mandatory fields #4417

Merged
merged 4 commits into from
Nov 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"parameters": {
"api-version": "2017-08-01-preview",
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
"securityContactName": "john",
"securityContactName": "default1",
"securityContact": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
"name": "john",
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
"name": "default1",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "john@contoso.com",
Expand All @@ -18,8 +18,8 @@
"responses": {
"200": {
"body": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
"name": "john",
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
"name": "default1",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "john@contoso.com",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"parameters": {
"api-version": "2017-08-01-preview",
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
"securityContactName": "default2",
"securityContact": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
"name": "default2",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "chen@contoso.com",
"alertNotifications": "On",
"alertsToAdmins": "On"
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
"name": "default2",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "chen@contoso.com",
"alertNotifications": "On",
"alertsToAdmins": "On"
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parameters": {
"api-version": "2017-08-01-preview",
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
"securityContactName": "john"
"securityContactName": "default1"
},
"responses": {
"204": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
"parameters": {
"api-version": "2017-08-01-preview",
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
"securityContactName": "john"
"securityContactName": "default1"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
"name": "john",
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
"name": "default1",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "john@contoso.com",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"parameters": {
"api-version": "2017-08-01-preview",
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
"securityContactName": "default2"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
"name": "default2",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "chen@contoso.com",
"alertNotifications": "On",
"alertsToAdmins": "On"
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"200": {
"body": {
"value": [{
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
"name": "john",
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
"name": "default1",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "john@contoso.com",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"parameters": {
"api-version": "2017-08-01-preview",
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23"
},
"responses": {
"200": {
"body": {
"value": [{
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
"name": "default2",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "chen@contoso.com",
"alertNotifications": "On",
"alertsToAdmins": "On"
}
}]
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
"securityContactName": "john",
"securityContact": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
"name": "john",
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
"name": "default1",
"type": "Microsoft.Security/securityContacts",
"properties": {
"phone": "(214)275-4038",
Expand All @@ -16,8 +16,8 @@
"responses": {
"200": {
"body": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
"name": "john",
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
"name": "default1",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "john@contoso.com",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"parameters": {
"api-version": "2017-08-01-preview",
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
"securityContactName": "default2",
"securityContact": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
"name": "default2",
"type": "Microsoft.Security/securityContacts",
"properties": {
"alertNotifications": "On"
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
"name": "default2",
"type": "Microsoft.Security/securityContacts",
"properties": {
"email": "chen@contoso.com",
"alertNotifications": "On",
"alertsToAdmins": "Off"
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,11 @@
"/subscriptions/{subscriptionId}/providers/Microsoft.Security/securityContacts": {
"get": {
"x-ms-examples": {
"Update security contact data": {
"$ref": "./examples/SecurityContacts/GetSecurityContactsSubscription_example.json"
"Update security contact data minimal": {
"$ref": "./examples/SecurityContacts/GetSecurityContactsSubscription_min_example.json"
},
"Update security contact data full": {
"$ref": "./examples/SecurityContacts/GetSecurityContactsSubscription_full_example.json"
}
},
"tags": ["Security Contacts"],
Expand Down Expand Up @@ -269,8 +272,11 @@
"/subscriptions/{subscriptionId}/providers/Microsoft.Security/securityContacts/{securityContactName}": {
"get": {
"x-ms-examples": {
"Get security contact data": {
"$ref": "./examples/SecurityContacts/GetSecurityContact_example.json"
"Get security contact data minimal": {
"$ref": "./examples/SecurityContacts/GetSecurityContact_min_example.json"
},
"Get security contact data full": {
"$ref": "./examples/SecurityContacts/GetSecurityContact_full_example.json"
}
},
"tags": ["Security Contacts"],
Expand Down Expand Up @@ -300,8 +306,11 @@
},
"put": {
"x-ms-examples": {
"Create security contact data": {
"$ref": "./examples/SecurityContacts/CreateSecurityContact_example.json"
"Create security contact data minimal": {
"$ref": "./examples/SecurityContacts/CreateSecurityContact_min_example.json"
},
"Create security contact data full": {
"$ref": "./examples/SecurityContacts/CreateSecurityContact_full_example.json"
}
},
"tags": ["Security Contacts"],
Expand Down Expand Up @@ -361,8 +370,11 @@
},
"patch": {
"x-ms-examples": {
"Update security contact data": {
"$ref": "./examples/SecurityContacts/UpdateSecurityContact_example.json"
"Update security contact data minimal": {
"$ref": "./examples/SecurityContacts/UpdateSecurityContact_min_example.json"
},
"Update security contact data full": {
"$ref": "./examples/SecurityContacts/UpdateSecurityContact_full_example.json"
}
},
"tags": ["Security Contacts"],
Expand Down Expand Up @@ -1179,7 +1191,6 @@
},
"required": [
"email",
"phone",
"alertNotifications",
eliagrady marked this conversation as resolved.
Show resolved Hide resolved
"alertsToAdmins"
]
Expand Down