Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master #4450

Merged
merged 7 commits into from
Nov 20, 2018
Merged

Master #4450

merged 7 commits into from
Nov 20, 2018

Conversation

mjfrb
Copy link
Contributor

@mjfrb mjfrb commented Nov 13, 2018

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 13, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Nov 13, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 13, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3841

@AutorestCI AutorestCI mentioned this pull request Nov 13, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 13, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4145

@AutorestCI AutorestCI mentioned this pull request Nov 13, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 13, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#538

@AutorestCI
Copy link

AutorestCI commented Nov 13, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Nov 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 13, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@jhendrixMSFT
Copy link
Member

@mjfrb has this API been reviewed by ARM yet?

@mjfrb
Copy link
Contributor Author

mjfrb commented Nov 14, 2018

Yes, this needs to be reviewed by ARM, I've sent mail requesting this

@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 14, 2018
@mjfrb
Copy link
Contributor Author

mjfrb commented Nov 19, 2018

It's my understanding that Guarav signed off on this.

@ravbhatnagar
Copy link
Contributor

This was reviewed in person by ARM. Signing off from ARM side. @mjfrb - Just one thing, you dont need to model the API for tracking the status of long running operation in swagger. It comes from the header. But removing may mean a breaking change.

@ravbhatnagar ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 19, 2018
@ravbhatnagar ravbhatnagar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 19, 2018
jhendrixMSFT
jhendrixMSFT requested changes Nov 19, 2018
View reviewed changes
...source-manager/Microsoft.Subscription/preview/2018-11-01-preview/examples/getOperations.json Outdated
"provider": "Microsoft Subscription",
"resource": "Resources",
"operation": "Create a subscription",
"description": "Create an Azure subscription."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description isn't part of the schema and is causing validation errors, see the log.

Menton Joe Frable added 2 commits November 19, 2018 22:07
@jhendrixMSFT jhendrixMSFT merged commit bc4f7d5 into Azure:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilcobmsft wilcobmsft wilcobmsft approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mjfrb @azuresdkci @AutorestCI @jhendrixMSFT @ravbhatnagar @wilcobmsft